Project

General

Profile

Bug #1

Test Ticket

Added by Josh Paetzel almost 10 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Important
Assignee:
-
Category:
-
Target version:
-
Seen in:
Severity:
Reason for Closing:
Reason for Blocked:
Needs QA:
Yes
Needs Doc:
Yes
Needs Merging:
Yes
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

This is a test of the ticket system

History

#1 Updated by Josh Paetzel almost 10 years ago

I'm not sure milestones and versions make sense

#2 Updated by Josh Paetzel almost 10 years ago

I think we are getting closer

#3 Updated by Josh Paetzel almost 10 years ago

  • Status changed from Unscreened to Closed

#4 Updated by Jordan Hubbard over 5 years ago

  • Target version deleted (2)

#5 Avatar?id=14398&size=24x24 Updated by Kris Moore almost 5 years ago

Commit: fa45e18ba07dab04041cbf226117fd0aeb241e22
https://github.com/pcbsd/pcbsd/commit/fa45e18ba07dab04041cbf226117fd0aeb241e22
Author: Eric Turgeon <>
Date: 2015-08-04 (Tue, 04 Aug 2015)

Log Message:
-----------
Merge pull request #1 from asxbsd/master

adding error checking on mounts

#6 Avatar?id=14398&size=24x24 Updated by Kris Moore almost 5 years ago

Commit: daeba4841bd4f5f5892127c7a5322cff23deb116
https://github.com/pcbsd/freebsd-ports/commit/daeba4841bd4f5f5892127c7a5322cff23deb116
Author: danfe <>
Date: 2015-10-19 (Mon, 19 Oct 2015)

Log Message:
-----------
Get rid of hand-rolled `do-build' and `do-install' targets which serve the
sole purpose to avoid using our standard MAKE_ENV.

They were introduced in r279589 as part of "update to 0.0.6" PR 159499 by
Kato (duh!) some four years ago; in r359185 bapt@ had mentioned that "lots
of invocation of MAKE_CMD here are wrong as they do not properly respect
MAKE_ENV" (which is ironic as avoiding MAKE_ENV is their only point) but
the the real problem was neither fixed nor rationale for ugly work-around
explained.

The port builds itself through a series of recursive make(1) calls, and is
using variables to pass various bits of internal state to submakes. This
approach typically requires strict discipline and can be hard to implement
correctly, to an extent being considered harmful [Miller 1997].

Incidentally, ${MAKE_ENV} includes variables that are 1) used by the port's
own build logic and 2) are not handled in a robust way by it.

Problem #1: consider the following code from `Makefile.rules.gnu.in':

ifndef LIBDIR
LIBDIR=.
endif

This is roughly equivalent to the following:

ifeq ($(origin LIBDIR), undefined)
LIBDIR=.
else # use whatever LIBDIR value make(1) can deduce
endif

Knowing that LIBDIR is set to some other value (`..') by inner makefiles,
that code can be rewritten more elaborately like this:

ifeq ($(origin LIBDIR), undefined)
LIBDIR=.
else ifeq ($(origin LIBDIR), file) # use LIBDIR value set by some Makefile
else # use whatever LIBDIR value make(1) can deduce
endif

Now, because LIBDIR is passed to make(1) via MAKE_ENV and the code above
does not have "ifeq ($(origin LIBDIR), environment)" check, the build was
affected by unexpected bogus value of it and subsequently failed. Since
the only valid place we can expect "our" LIBDIR to come from is makefiles,
we can inhibit unwanted pollution from the environment by rewriting the
initial code like this:

ifneq ($(origin LIBDIR), file)
LIBDIR=.
endif

Problem #2 is similar: checking for CFLAGS and LDFLAGS to protect their
initial assignment is very fragile as many frameworks akin to the Ports
Collection would provide some default values. While it is usually safe
to append to them, it is almost always a bad idea to use them verbatim.

Apparently, these checks were put there to support resetting CFLAGS and
LDFLAGS in `util/Makefile', but since removing them does not hurt do so
regardless of small pollution in that one case that does not affect the
build in any noticeable way.

#7 Avatar?id=14398&size=24x24 Updated by Kris Moore almost 5 years ago

Commit: f18dd19cb6d15370efad7880633d759dfdd768b5
https://github.com/pcbsd/pcbsd/commit/f18dd19cb6d15370efad7880633d759dfdd768b5
Author: Sean Zipperer <>
Date: 2015-11-30 (Mon, 30 Nov 2015)

Log Message:
-----------
Merge pull request #1 from pcbsd/master

catch up with base

#8 Avatar?id=14398&size=24x24 Updated by Kris Moore over 4 years ago

Commit: f81a8efcdbdb822aa1fba397416351ffb1b55da7
https://github.com/pcbsd/freebsd-ports/commit/f81a8efcdbdb822aa1fba397416351ffb1b55da7
Author: mandree <>
Date: 2015-12-29 (Tue, 29 Dec 2015)

Log Message:
-----------
Update to upstream release 1.42.13.

Changelog: <http://e2fsprogs.sourceforge.net/e2fsprogs-release.html#1.42.13>

#9 Avatar?id=14398&size=24x24 Updated by Kris Moore over 4 years ago

Commit: f81a8efcdbdb822aa1fba397416351ffb1b55da7
https://github.com/pcbsd/freebsd-ports/commit/f81a8efcdbdb822aa1fba397416351ffb1b55da7
Author: mandree <>
Date: 2015-12-29 (Tue, 29 Dec 2015)

Log Message:
-----------
Update to upstream release 1.42.13.

Changelog: <http://e2fsprogs.sourceforge.net/e2fsprogs-release.html#1.42.13>

Also available in: Atom PDF