Project

General

Profile

Feature #14355

Add Comment column in Storage section (for zvol and datasets)

Added by DENNY VANDEMAELE over 3 years ago. Updated about 2 years ago.

Status:
Resolved
Priority:
Nice to have
Assignee:
William Grzybowski
Category:
GUI (new)
Target version:
Estimated time:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
Yes
Needs Doc:
Yes
Needs Merging:
Yes
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:

Description

Hello,

The comment sections come in very handy in the Sharing section for each share. Especially when you setup a unique share and don't look at it for a year, you can refer to the comments.

Can we Add a Comment column in Storage section for zvols and datasets? Currently I have to keep notes in another program about the zvols/datasets.


Related issues

Related to FreeNAS - Feature #14356: Add status field to zvols/datasets showing if they are readonly or not.Resolved2016-03-30
Blocked by FreeNAS - Bug #18582: Allow utf8 in zfs optionResolved2016-10-28

Associated revisions

Revision 893cf208 (diff)
Added by neharathod about 3 years ago

Comments for datasets/zvols Ticket: #14355

Revision 3e74eb0c (diff)
Added by William Grzybowski about 3 years ago

fix(gui): do not show datasets/zvols comments as inherit Ticket: #14355

Revision 8c0c4d14 (diff)
Added by William Grzybowski about 3 years ago

fix(gui): show comments on dataset edit dialog Ticket: #14355

Revision 45db564e (diff)
Added by William Grzybowski about 3 years ago

fix(gui): setting comments in zvol Ticket: #14355

Revision 00fcf4db (diff)
Added by William Grzybowski about 3 years ago

fix(gui): show current value of comments when editing zvol Ticket: #14355

Revision ef077e8e (diff)
Added by neharathod about 3 years ago

Comments for datasets/zvols Ticket: #14355 (cherry picked from commit 893cf20821adfe9ed7512082b4b7fc47f9379a22)

Revision 89febaa0 (diff)
Added by William Grzybowski about 3 years ago

fix(gui): do not show datasets/zvols comments as inherit Ticket: #14355 (cherry picked from commit 3e74eb0cac049ec819bc8d5c1d6a01c65ac5dd3e)

Revision e6a1ff18 (diff)
Added by William Grzybowski about 3 years ago

fix(gui): show comments on dataset edit dialog Ticket: #14355 (cherry picked from commit 8c0c4d14331e13519b631feb7612706748bf8ae4)

Revision 930a16e4 (diff)
Added by William Grzybowski about 3 years ago

fix(gui): setting comments in zvol Ticket: #14355 (cherry picked from commit 45db564e2e3d50d81e3d3870eaab636a598242cb)

Revision 8630b4e7 (diff)
Added by William Grzybowski about 3 years ago

fix(gui): show current value of comments when editing zvol Ticket: #14355 (cherry picked from commit 00fcf4db14036c99648ea266aee2881d15f10dc1)

Revision a151162d (diff)
Added by neharathod about 3 years ago

Comments for datasets/zvols Ticket: #14355 (cherry picked from commit 893cf20821adfe9ed7512082b4b7fc47f9379a22)

Revision fc01176d (diff)
Added by William Grzybowski about 3 years ago

fix(gui): do not show datasets/zvols comments as inherit Ticket: #14355 (cherry picked from commit 3e74eb0cac049ec819bc8d5c1d6a01c65ac5dd3e)

Revision c36cf894 (diff)
Added by William Grzybowski about 3 years ago

fix(gui): show comments on dataset edit dialog Ticket: #14355 (cherry picked from commit 8c0c4d14331e13519b631feb7612706748bf8ae4)

Revision 39450db7 (diff)
Added by William Grzybowski about 3 years ago

fix(gui): setting comments in zvol Ticket: #14355 (cherry picked from commit 45db564e2e3d50d81e3d3870eaab636a598242cb)

Revision 3a613e28 (diff)
Added by William Grzybowski about 3 years ago

fix(gui): show current value of comments when editing zvol Ticket: #14355 (cherry picked from commit 00fcf4db14036c99648ea266aee2881d15f10dc1)

History

#1 Updated by Jordan Hubbard over 3 years ago

  • Assignee set to Anonymous
  • Priority changed from No priority to Nice to have
  • Target version set to Unspecified

Neha: This can be implemented fairly simply as a ZFS property (org.freenas:description) and a little bit of UI programming to show / allow editing of this new column.

#2 Updated by Jordan Hubbard over 3 years ago

  • Related to Feature #14356: Add status field to zvols/datasets showing if they are readonly or not. added

#3 Updated by Anonymous over 3 years ago

  • Status changed from Unscreened to Screened

#4 Updated by Anonymous over 3 years ago

Yes, the comment field can be added to the zvol/dataset forms and simply displayed alongwith other information for each zvol/dataset.
I am working on the implementation of this feature and done with 40% of the task.

#5 Updated by Anonymous over 3 years ago

Hi Jordan, I have implemented this feature and done with the Unit Testing.
I'll put the changes on a branch and create a pull request on github for the same

#6 Updated by Anonymous over 3 years ago

  • Status changed from Screened to Ready For Release

#7 Updated by Dru Lavigne over 3 years ago

Is there an associated commit? Also, is this the correct target version?

#8 Updated by Anonymous over 3 years ago

Yes, I have made a commit and pulled a request on git for this ticket.

#9 Updated by Anonymous over 3 years ago

  • Status changed from Ready For Release to Fix In Progress

#10 Avatar?id=14398&size=24x24 Updated by Kris Moore over 3 years ago

  • Target version changed from Unspecified to 9.10.1-U1

Is this still being looked at?

#11 Updated by Anonymous over 3 years ago

Hi Kris,
Please refer to Pull Request #137 for the required fix.

#12 Avatar?id=14398&size=24x24 Updated by Kris Moore over 3 years ago

  • Status changed from Fix In Progress to Needs Developer Review
  • Assignee changed from Anonymous to William Grzybowski

Over to william for review

#13 Updated by William Grzybowski over 3 years ago

  • Status changed from Needs Developer Review to Fix In Progress
  • Assignee changed from William Grzybowski to Anonymous

Commented on github.

#14 Updated by Dru Lavigne over 3 years ago

Neha, will the fixed PR be in in time for U1?

#15 Updated by Anonymous over 3 years ago

Yes Dru, I'll be making the PR today.

#16 Avatar?id=14398&size=24x24 Updated by Kris Moore over 3 years ago

  • Target version changed from 9.10.1-U1 to 9.10.2

#17 Avatar?id=14398&size=24x24 Updated by Kris Moore about 3 years ago

  • Status changed from Fix In Progress to Needs Developer Review
  • Assignee changed from Anonymous to William Grzybowski

Pull request is here, over to William for review.

https://github.com/freenas/freenas/pull/201

#18 Updated by William Grzybowski about 3 years ago

This will need another review since I had to change a lot of things in this PR.

#19 Updated by William Grzybowski about 3 years ago

  • Blocks Bug #18582: Allow utf8 in zfs option added

#20 Updated by William Grzybowski about 3 years ago

  • Blocks deleted (Bug #18582: Allow utf8 in zfs option)

#21 Updated by William Grzybowski about 3 years ago

  • Blocked by Bug #18582: Allow utf8 in zfs option added

#22 Updated by William Grzybowski about 3 years ago

  • Assignee changed from William Grzybowski to Suraj Ravichandran

#23 Updated by Suraj Ravichandran about 3 years ago

  • Status changed from Needs Developer Review to Reviewed
  • Assignee changed from Suraj Ravichandran to William Grzybowski
  • % Done changed from 0 to 100

This thing check out (but was in no way fun to review)

One minor thing is that we would want dataset edit to have the same change as zvol's edit had in this commit: https://github.com/freenas/freenas/commit/45db564e (it basically is a code cleanup along with the addition of logic that prevents making the description zfs prop-> org.freenas:description inheritable)

Other than that its all good.

Have discussed this with william, but since this change is a nice to have at best, I am moving on. Marking as reviewed.

#24 Updated by Vaibhav Chauhan about 3 years ago

  • Status changed from Reviewed to Ready For Release

#25 Updated by Dru Lavigne about 2 years ago

  • Status changed from Ready For Release to Resolved

Also available in: Atom PDF