Project

General

Profile

Bug #16573

vfs objects = zfs_space makes samba 4.4 unhappy

Added by Josh Paetzel about 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Critical
Assignee:
Josh Paetzel
Category:
OS
Target version:
Seen in:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
Yes
Needs Doc:
Yes
Needs Merging:
Yes
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Which is no shock, it's code we wrote.

Associated revisions

Revision e50eda88 (diff)
Added by Josh Paetzel about 3 years ago

Remove zfs_space until 26573 is fixed.

This stops smbd core dumps.

Ticket: #16573

Revision eb13c307 (diff)
Added by Josh Paetzel almost 3 years ago

Revert "Remove zfs_space until 26573 is fixed."

This reverts commit e50eda888064dd02c26076d42f393d119c374fd2.

Ticket: #16573

History

#1 Updated by Josh Paetzel about 3 years ago

Samba 4.4 is in FreeNAS nightlies now, but 9.10.1 will have samba 4.3

#2 Updated by John Hixson about 3 years ago

  • Status changed from Unscreened to Screened

#3 Updated by John Hixson about 3 years ago

I currently have higher priority items and won't be able to get to this until resolved. Who maintains samba now anyhow?

#4 Updated by Josh Paetzel about 3 years ago

The milestone is set to 9.10.2, which is a couple months away.

9.10.1 (in a few weeks) will still be using samba 4.3

#5 Updated by Jordan Hubbard about 3 years ago

Just to answer the question above - Samba is a group project at iX. Nobody "maintains it" as a single thing, though Jakub has been syncing the port, since it's just too big for one person (and Jakub has a TODO list at least 10 miles longer than anyone else at iX, so don't ask him to be that one person, thanks).

#6 Updated by John Hixson about 3 years ago

  • Private changed from No to Yes

I'm making this private since I think the response to my question is a bit extreme and doesn't need to be seen by the public.

#7 Avatar?id=14398&size=24x24 Updated by Kris Moore about 3 years ago

  • Private changed from Yes to No

John,

I'm not sure quite what the offense was here. The point made was that we don't have a dedicated Samba maintainer right now. It's more or less whoever can get to something first depending upon priorities.

In this case, I think the thought was since you were probably involved in the original work, you may be best suited to fix any bitrot to make it work with 4.4. Is that right jpaetzel?

#8 Updated by John Hixson almost 3 years ago

Kris Moore wrote:

John,

I'm not sure quite what the offense was here. The point made was that we don't have a dedicated Samba maintainer right now. It's more or less whoever can get to something first depending upon priorities.

According to the port itself, Jakub is the maintainer. If Jakub has a TODO list 10 miles longer than anyone else at iX, I would be happy to take over as maintainer.

In this case, I think the thought was since you were probably involved in the original work, you may be best suited to fix any bitrot to make it work with 4.4. Is that right jpaetzel?

I'd be happy to do so.

#9 Updated by Josh Paetzel almost 3 years ago

The ticket is assigned to you. The milestone is correct. This is a blocker for samba 4.4 in FreeNAS 9.10.2

#10 Updated by gear head almost 3 years ago

Sorry guys for stating the obvious. I installed the lasted 9.10.1 from 8/25 and it include samba 4.4

#11 Updated by Josh Paetzel almost 3 years ago

  • Priority changed from Critical to Blocks Until Resolved

I am changing the priority here as we cannot release with samba 4.4 until this issue is resolved.

#12 Updated by Jakub Klama almost 3 years ago

  • Assignee changed from John Hixson to Josh Paetzel

Fxed in v4-4-stable branch of samba repo (c04488cb4779262e50ccf18e1532f36f84441d83).

Passing back to Josh on his request.

#13 Updated by Josh Paetzel almost 3 years ago

  • Status changed from Screened to Closed
  • Priority changed from Blocks Until Resolved to Critical

The needed fixes have been done to samba 4.4.x, we are set to close this one out.

Also available in: Atom PDF