Project

General

Profile

Bug #19118

wrongly creating wrong BE name when there are wrongful duplicates

Added by Sean Fagan about 3 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Expected
Assignee:
Vaibhav Chauhan
Category:
OS
Target version:
9.10.2
Seen in:
N/A
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
Yes
Needs Doc:
Yes
Needs Merging:
Yes
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

E.g., if someone does a release with a version of BETA2, and then decides it's bad and then does another release with version also set to BETA2, anyone who happened to update to the first BETA2 will have problems updating to the second BETA2 unless they're patient enough to wait for a subsequent update.

Filing this in FN9, but it came up as an issue in FN10, because they share freenas-pkgtools.

Associated revisions

Revision 62387652 (diff)
Added by Sean Fagan about 3 years ago

Try to create a different BE name if the requested version name already exists. This is a bit hacked on at this point, so it may be time to review the logic in the function in more depth. Ticket: #19118

History

#1 Updated by Sean Fagan about 3 years ago

  • Status changed from Fix In Progress to 19

commit:623876528fefba4497989a9239060c64e5477985 in freenas-pkgtools, also in the branch FIX-19118

#2 Avatar?id=14398&size=24x24 Updated by Kris Moore about 3 years ago

  • Target version set to 9.10.2

#3 Updated by Vaibhav Chauhan about 3 years ago

this code is already in 9.10.2-STABLE branch of freenas-pkgtools repo, can this be marked RFR ?

#4 Updated by Sean Fagan about 3 years ago

  • Status changed from 19 to Ready For Release
  • Assignee changed from Sean Fagan to Vaibhav Chauhan

Yes.

#5 Avatar?id=14398&size=24x24 Updated by Kris Moore over 2 years ago

  • Seen in changed from Unspecified to N/A

#6 Updated by Dru Lavigne almost 2 years ago

  • Status changed from Ready For Release to Resolved

Also available in: Atom PDF