Project

General

Profile

Bug #19406

Remove Snapshot Replication column

Added by Warren Block almost 2 years ago. Updated 12 months ago.

Status:
Resolved
Priority:
Nice to have
Assignee:
William Grzybowski
Category:
GUI (new)
Target version:
11.1-BETA1
Seen in:
9.10.1-U4
Sprint:
Severity:
New
Backlog Priority:
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
Yes
Needs Merging:
Yes
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Snapshots that have been replicated are supposed to show an "OK" in the Replication column for successful replications. They currently show nothing at all.

It would also be useful information for the user to know not just that the replication completed, but the date and time it completed (or failed).

snapshots.jpg (61.7 KB) snapshots.jpg Warren Block, 12/05/2016 10:45 AM
replicationtasks.jpg (57.5 KB) replicationtasks.jpg Warren Block, 02/22/2017 09:13 AM
snapshots.jpg (54.4 KB) snapshots.jpg Warren Block, 02/22/2017 09:13 AM
Screen Shot 2017-05-05 at 2.43.58 PM.png (351 KB) Screen Shot 2017-05-05 at 2.43.58 PM.png Bonnie Follweiler, 05/05/2017 11:45 AM
Screen Shot 2017-05-05 at 2.44.34 PM.png (255 KB) Screen Shot 2017-05-05 at 2.44.34 PM.png Bonnie Follweiler, 05/05/2017 11:45 AM
Screen Shot 2017-05-05 at 2.44.52 PM.png (330 KB) Screen Shot 2017-05-05 at 2.44.52 PM.png Bonnie Follweiler, 05/05/2017 11:45 AM
Screen Shot 2017-05-05 at 2.43.40 PM.png (327 KB) Screen Shot 2017-05-05 at 2.43.40 PM.png Bonnie Follweiler, 05/05/2017 11:45 AM
Screen Shot 2017-05-30 at 2.40.23 PM.png (393 KB) Screen Shot 2017-05-30 at 2.40.23 PM.png Bonnie Follweiler, 05/30/2017 11:58 AM
Screen Shot 2017-05-30 at 2.40.47 PM.png (406 KB) Screen Shot 2017-05-30 at 2.40.47 PM.png Bonnie Follweiler, 05/30/2017 11:58 AM
Screen Shot 2017-05-30 at 2.41.01 PM.png (406 KB) Screen Shot 2017-05-30 at 2.41.01 PM.png Bonnie Follweiler, 05/30/2017 11:58 AM
Screen Shot 2017-05-30 at 2.41.18 PM.png (403 KB) Screen Shot 2017-05-30 at 2.41.18 PM.png Bonnie Follweiler, 05/30/2017 11:58 AM
Screen Shot 2017-10-18 at 3.46.12 PM.png (86.3 KB) Screen Shot 2017-10-18 at 3.46.12 PM.png Bonnie Follweiler, 10/18/2017 12:47 PM
8001
9220
9221
10990
10991
10992
10993
11285
11286
11287
11288
12744

Associated revisions

Revision c5c5df16 (diff)
Added by William Grzybowski over 1 year ago

fix(gui): snapshot replication status in datagrid

Ticket: #19406

Revision 1bae8e2f (diff)
Added by William Grzybowski over 1 year ago

fix(gui): snapshot replication status in datagrid

Ticket: #19406
(cherry picked from commit c5c5df16068c2bc68d24216c633d194c98e3b168)

Revision 08c386bc (diff)
Added by William Grzybowski over 1 year ago

fix(gui): snapshot replication status in datagrid

Ticket: #19406
(cherry picked from commit c5c5df16068c2bc68d24216c633d194c98e3b168)

Revision 0fb4de47 (diff)
Added by William Grzybowski over 1 year ago

fix(gui): check remote snapshot correctly for root remote dataset

Ticket: #19406

Revision e44f5752 (diff)
Added by Warren Block over 1 year ago

Mention the OK that is now back in the Replication column of snapshots.

Ticket: #19406

Revision a496ba5b (diff)
Added by William Grzybowski 12 months ago

rm(gui): remove `replication` column in Snapshots UI

Ticket: #19406

Revision 1e2a674f (diff)
Added by William Grzybowski 12 months ago

fix(gui): pep8

Ticket: #19406

Revision 0304b952 (diff)
Added by William Grzybowski 12 months ago

rm(gui): remove `replication` column in Snapshots UI

Ticket: #19406

Revision cc1358a3 (diff)
Added by William Grzybowski 12 months ago

fix(gui): pep8

Ticket: #19406

Revision 27561e5e (diff)
Added by Dru Lavigne 12 months ago

Remove replication column.
Ticket: #19406

History

#1 Avatar?id=14398&size=24x24 Updated by Kris Moore almost 2 years ago

  • Assignee set to William Grzybowski
  • Priority changed from No priority to Nice to have
  • Target version set to 9.10.2-U1

#2 Updated by William Grzybowski almost 2 years ago

  • Status changed from Unscreened to Screened

#3 Avatar?id=14398&size=24x24 Updated by Kris Moore almost 2 years ago

  • Target version changed from 9.10.2-U1 to 9.10.2-U2

#4 Updated by William Grzybowski over 1 year ago

  • Status changed from Screened to Needs Developer Review

#5 Avatar?id=14398&size=24x24 Updated by Kris Moore over 1 year ago

  • Status changed from Needs Developer Review to Reviewed

#6 Updated by Vaibhav Chauhan over 1 year ago

  • Status changed from Reviewed to Ready For Release

#7 Updated by Warren Block over 1 year ago

9220
9221

As of FreeNAS-9.10.2-INTERNAL2-U2 (81004f2), the Snapshots/Replication column is still blank, even after replication succeeded.

#8 Updated by William Grzybowski over 1 year ago

  • Status changed from Unscreened to 15
  • Target version changed from 9.10.2-U2 to 9.10.3

Well, it works for me. I will need either logs or access to your machine/vm.

#9 Avatar?id=14398&size=24x24 Updated by Kris Moore over 1 year ago

  • Status changed from 15 to Closed: Insufficient Info

#10 Updated by William Grzybowski over 1 year ago

  • Status changed from Closed: Insufficient Info to Screened

Warren has offered to give me access to the machine but I did not had time to look yet.

#11 Updated by William Grzybowski over 1 year ago

  • Status changed from Screened to Resolved

#12 Avatar?id=14398&size=24x24 Updated by Kris Moore over 1 year ago

  • Target version changed from 9.10.3 to 11.0

#15 Updated by Vaibhav Chauhan over 1 year ago

  • Target version changed from 11.0 to 11.0-RC

#16 Updated by Bonnie Follweiler over 1 year ago

Tested this today and it still doesn't indicate that a successful replication happened - even though it did

#17 Updated by Bonnie Follweiler over 1 year ago

  • Status changed from Resolved to 15

#19 Updated by Bonnie Follweiler over 1 year ago

11285
11286
11287
11288

as discussed:
Both ways are successful but one way prevents the OK from showing up in the Replication column.
If the replication path is the same name as the tank (ie tankb/tankb) the replication OK column is blank. If it not, the replication Column is filled in (OK) except for the ones that the replication path is the same name. Both path's are successful. I have included screenshots

#20 Updated by William Grzybowski over 1 year ago

  • Target version changed from 11.0-RC to 11.1

#21 Updated by William Grzybowski over 1 year ago

  • Status changed from 15 to Screened

#22 Updated by William Grzybowski 12 months ago

  • Status changed from Screened to Needs Developer Review
  • Assignee changed from William Grzybowski to Vladimir Vinogradenko

https://github.com/freenas/freenas/pull/352

Talked to Kris. We have decided to remove that column since so many things can go wrong and replication status should have everything we need.

#23 Updated by William Grzybowski 12 months ago

  • Subject changed from Snapshot Replication column is blank for snapshots that have been replicated to Remove Snapshot Replication column

#24 Updated by Vladimir Vinogradenko 12 months ago

  • Status changed from Needs Developer Review to Reviewed by Developer

#25 Updated by Dru Lavigne 12 months ago

  • Target version changed from 11.1 to 11.1-BETA1

#26 Updated by William Grzybowski 12 months ago

  • Status changed from Reviewed by Developer to Ready For Release
  • Assignee changed from Vladimir Vinogradenko to William Grzybowski

#27 Updated by Bonnie Follweiler 12 months ago

12744

Test passed in FreeNAS-11-MASTER-201710180506
Screenshot provided

#28 Updated by Dru Lavigne 12 months ago

  • Status changed from Ready For Release to Resolved

Also available in: Atom PDF