Project

General

Profile

Bug #19418

NFSv4.1 restart patch

Added by Josh Paetzel about 3 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Expected
Assignee:
Vaibhav Chauhan
Category:
OS
Target version:
Seen in:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
Yes
Needs Doc:
Yes
Needs Merging:
Yes
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

When the NFSv4.1 server restarts if any clients have any files open those need to be recovered gracefully (NFS v4 has a nfsstablerestart file just for this purpose)

nfsd41recovery.patch (2.68 KB) nfsd41recovery.patch Josh Paetzel, 12/05/2016 07:16 PM

Associated revisions

Revision 97f7557d (diff)
Added by rmacklem about 3 years ago

Fix the NFSv4.1 server for Open reclaim after a reboot. The NFSv4.1 server failed to update the nfs-stablerestart file for a client when the client was issued its first Open. As such, recovery of Opens after a server reboot failed with NFSERR_NOGRACE. This patch fixes this. It also changes the code so that it malloc()'s the 1024 byte array instead of allocating it on the kernel stack for both NFSv4.0 and NFSv4.1. Note that this bug only affected NFSv4.1 and only when clients attempted to reclaim Opens after a server reboot. MFC after: 2 weeks Ticket: #19418 (cherry picked from commit 05c246d986e23dd5251e37e40bf398ee14b93dff)

Revision 97f7557d (diff)
Added by rmacklem about 3 years ago

Fix the NFSv4.1 server for Open reclaim after a reboot. The NFSv4.1 server failed to update the nfs-stablerestart file for a client when the client was issued its first Open. As such, recovery of Opens after a server reboot failed with NFSERR_NOGRACE. This patch fixes this. It also changes the code so that it malloc()'s the 1024 byte array instead of allocating it on the kernel stack for both NFSv4.0 and NFSv4.1. Note that this bug only affected NFSv4.1 and only when clients attempted to reclaim Opens after a server reboot. MFC after: 2 weeks Ticket: #19418 (cherry picked from commit 05c246d986e23dd5251e37e40bf398ee14b93dff)

Revision 1249e017 (diff)
Added by rmacklem about 3 years ago

Fix the NFSv4.1 server for Open reclaim after a reboot. The NFSv4.1 server failed to update the nfs-stablerestart file for a client when the client was issued its first Open. As such, recovery of Opens after a server reboot failed with NFSERR_NOGRACE. This patch fixes this. It also changes the code so that it malloc()'s the 1024 byte array instead of allocating it on the kernel stack for both NFSv4.0 and NFSv4.1. Note that this bug only affected NFSv4.1 and only when clients attempted to reclaim Opens after a server reboot. MFC after: 2 weeks Ticket: #19418 (cherry picked from commit 05c246d986e23dd5251e37e40bf398ee14b93dff) (cherry picked from commit 97f7557d3c0c32f1a000537cc3378abd7d9237a3)

Revision 1249e017 (diff)
Added by rmacklem about 3 years ago

Fix the NFSv4.1 server for Open reclaim after a reboot. The NFSv4.1 server failed to update the nfs-stablerestart file for a client when the client was issued its first Open. As such, recovery of Opens after a server reboot failed with NFSERR_NOGRACE. This patch fixes this. It also changes the code so that it malloc()'s the 1024 byte array instead of allocating it on the kernel stack for both NFSv4.0 and NFSv4.1. Note that this bug only affected NFSv4.1 and only when clients attempted to reclaim Opens after a server reboot. MFC after: 2 weeks Ticket: #19418 (cherry picked from commit 05c246d986e23dd5251e37e40bf398ee14b93dff) (cherry picked from commit 97f7557d3c0c32f1a000537cc3378abd7d9237a3)

Revision f3d08d73 (diff)
Added by rmacklem almost 3 years ago

Fix the NFSv4.1 server for Open reclaim after a reboot. The NFSv4.1 server failed to update the nfs-stablerestart file for a client when the client was issued its first Open. As such, recovery of Opens after a server reboot failed with NFSERR_NOGRACE. This patch fixes this. It also changes the code so that it malloc()'s the 1024 byte array instead of allocating it on the kernel stack for both NFSv4.0 and NFSv4.1. Note that this bug only affected NFSv4.1 and only when clients attempted to reclaim Opens after a server reboot. MFC after: 2 weeks Ticket: #19418 (cherry picked from commit 05c246d986e23dd5251e37e40bf398ee14b93dff)

Revision f3d08d73 (diff)
Added by rmacklem almost 3 years ago

Fix the NFSv4.1 server for Open reclaim after a reboot. The NFSv4.1 server failed to update the nfs-stablerestart file for a client when the client was issued its first Open. As such, recovery of Opens after a server reboot failed with NFSERR_NOGRACE. This patch fixes this. It also changes the code so that it malloc()'s the 1024 byte array instead of allocating it on the kernel stack for both NFSv4.0 and NFSv4.1. Note that this bug only affected NFSv4.1 and only when clients attempted to reclaim Opens after a server reboot. MFC after: 2 weeks Ticket: #19418 (cherry picked from commit 05c246d986e23dd5251e37e40bf398ee14b93dff)

History

#1 Updated by Josh Paetzel about 3 years ago

  • Status changed from Investigation to Needs Developer Review
  • Assignee changed from Josh Paetzel to Vaibhav Chauhan

#2 Updated by Vaibhav Chauhan about 3 years ago

  • Status changed from Needs Developer Review to Ready For Release
  • Priority changed from No priority to Expected

this is an upstream FreeBSD patch.

#3 Updated by Dru Lavigne almost 2 years ago

  • Status changed from Ready For Release to Resolved

Also available in: Atom PDF