Project

General

Profile

Bug #19589

freenasOS's logging mangles with logging._handlers even in the presence of existing loggers

Added by Suraj Ravichandran almost 3 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Expected
Assignee:
Suraj Ravichandran
Category:
OS
Target version:
Seen in:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
Yes
Needs Doc:
Yes
Needs Merging:
Yes
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

freenasOS has logging setup in its init method that does one of the two things:
1. If logging handlers are already present for a logger then it does not configure the root logger with any handlers
2. else it sets up logging to syslog.

Now, in the 1st case it should not even configure the other handlers and such via logging.config.dictConfig or any such method since that would override other handlers previously present.

Thanks to William for bringing this to my notice

Associated revisions

Revision b3451810 (diff)
Added by Suraj Ravichandran almost 3 years ago

If any handlers are found just do not configure logging at all. Ticket: #19589

Revision 9cd7a5a6 (diff)
Added by Suraj Ravichandran almost 3 years ago

If any handlers are found just do not configure logging at all. Ticket: #19589 (cherry picked from commit b34518104e6d880db417cc8f2a317139916b46bc)

History

#1 Updated by Suraj Ravichandran almost 3 years ago

@release engineer: I have also cherrypicked this to FIX-19589 which was branched off 9.10.2-STABLE branch of freenas-pkgtools repo

#2 Updated by William Grzybowski almost 3 years ago

  • Status changed from Needs Developer Review to Reviewed
  • Assignee changed from William Grzybowski to Suraj Ravichandran

LGTM

#3 Updated by Vaibhav Chauhan almost 3 years ago

  • Status changed from Reviewed to Ready For Release

#4 Updated by Dru Lavigne almost 2 years ago

  • Status changed from Ready For Release to Resolved

Also available in: Atom PDF