Project

General

Profile

Bug #21782

Autosnap on recursive + prefix matching datasets broken

Added by Richard Kojedzinszky over 4 years ago. Updated about 4 years ago.

Status:
Resolved
Priority:
Critical
Assignee:
William Grzybowski
Category:
Middleware
Target version:
Seen in:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
Yes
Needs Doc:
Yes
Needs Merging:
Yes
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Consider the following dataset structure:

st/rec
st/rec/a
st/rec/b
st/record

Create a recursive snapshot task on st/rec, set retention time to 1d with shortest period interval
Create a non-rec snapshot task on st/record, with any setting, but with longer interval
Create a non-rec snapshot task on st/rec/a, with any setting, but with longer interval

With these settings, as st/rec will be snapshotted on every run, all other recursiv tasks will be removed in the script.

And also, with the wrong prefix matching st/record will also be removed from pending tasks, thus not creating snapshots for them at all.

I suggest when comparing recursive tasks we should compare the retention time as well, and fix prefix matching.

https://github.com/rkojedzinszky/freenas/commit/5f52ddb75c9217ebb780637ae728f453d3401425

Regards,

Associated revisions

Revision f1789844 (diff)
Added by Richard Kojedzinszky over 4 years ago

autosnap fix for recursive corner cases (cherry picked from commit b738ac800cf18dfdc87957c8b1f338fb090b4c02) Ticket: #21782

History

#1 Avatar?id=14398&size=24x24 Updated by Kris Moore over 4 years ago

  • Assignee set to William Grzybowski
  • Priority changed from No priority to Nice to have
  • Target version set to 9.10.3

Seems to make sense. Over to william to review and possibly pull that patch in.

#2 Updated by William Grzybowski over 4 years ago

  • Status changed from Unscreened to Screened

#3 Updated by William Grzybowski over 4 years ago

  • Priority changed from Nice to have to Critical

#4 Updated by William Grzybowski over 4 years ago

  • Status changed from Screened to Resolved

Commit cherry-picked. Thanks!

#5 Avatar?id=14398&size=24x24 Updated by Kris Moore over 4 years ago

  • Target version changed from 9.10.3 to 11.0

#7 Updated by Vaibhav Chauhan about 4 years ago

  • Target version changed from 11.0 to 11.0-RC

Also available in: Atom PDF