Project

General

Profile

Feature #23340

Avatar?id=14398&size=50x50

Need at least two themes - Light / Dark

Added by Kris Moore over 4 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority:
Nice to have
Assignee:
James Nixon
Category:
GUI (new)
Estimated time:
8.00 h
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
Yes
Needs Doc:
Yes
Needs Merging:
Yes
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:

Description

For the new Angular UI, we need at least two themes, a Dark (Similar to old Corral) and Light theme. Some sort of drop-down / selector should be available (obviously).


Related issues

Has duplicate FreeNAS - Feature #23507: FreeNAS 11 GUI - Request user selectable color schemeClosed: Duplicate2017-04-23

History

#1 Updated by James Nixon over 4 years ago

  • Status changed from Unscreened to Screened

#2 Avatar?id=14398&size=24x24 Updated by Kris Moore over 4 years ago

  • Target version changed from 9.10.4 to 11.1

#3 Avatar?id=14398&size=24x24 Updated by Kris Moore over 4 years ago

  • Has duplicate Feature #23507: FreeNAS 11 GUI - Request user selectable color scheme added

#4 Updated by James Nixon over 4 years ago

  • Status changed from Screened to Fix In Progress
Started on a dark (black/blue) theme called "Murky",
  • this is colorScheme update
  • along with other UI enhancements needed to smooth it over
  • Once Murky theme is finished I'll clone it to begin the light (white/blue) theme, "Manatee"

I tried to branch freenas/webui so my pull request doesnt merge over master, but got denied
"remote: Permission to freenas/webui.git denied to jnix3"

here's a pull request that'll overwrite the current theme, not sure thats ideal
https://github.com/freenas/webui/pull/1

#5 Updated by Mårten Larsson over 4 years ago

Would be nice if the new color themes can be validated by a color blind person.
For example, in 11.0 RC is is very hard for a red/green colorblind person to see
the difference of the on/off icons in the services view.

#6 Avatar?id=14398&size=24x24 Updated by Kris Moore over 4 years ago

James,

Committed your theme pull request. But yes, we should ensure at least one theme is color blind accessible.

#7 Updated by James Nixon over 4 years ago

Kris Moore wrote:

James,

Committed your theme pull request. But yes, we should ensure at least one theme is color blind accessible.

Noted, Im currently researching color-blind friendly palettes to use, so far looks like if i avoid using red and green together that will help a lot. I checked this out, https://github.com/Parakleta/environment/tree/master/solarized-colourblind for palette inspiration. I'll try a colorblind friendly palette for both the dark and light theme. Thanks!

#8 Avatar?id=14398&size=24x24 Updated by Kris Moore almost 4 years ago

  • Status changed from Fix In Progress to Ready For Release
  • Target version changed from 11.1 to 11.1-BETA1

This is done

#9 Updated by Dru Lavigne almost 4 years ago

  • Status changed from Ready For Release to Resolved
  • Target version changed from 11.1-BETA1 to Master - FreeNAS Nightlies

Also available in: Atom PDF