Project

General

Profile

Bug #23790

False positives from smartmontools

Added by Paul Warwicker over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Important
Assignee:
Sean Fagan
Category:
Middleware
Target version:
Seen in:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
Yes
Needs Doc:
Yes
Needs Merging:
Yes
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

It is possible to get false positives from smartmontools. I have reported this to the smartmon projects and they have fixed the problem with the fix applied to the next anticipated release (6.6). There is no indication when that will be.

Please refer to https://www.smartmontools.org/ticket/746#comment:2 for more details

Seen in FreeNAS-Corral-10.0.4 but this is not listed as a version in webform

Thanks
-paul

smartd (688 KB) smartd Sean Fagan, 05/10/2017 11:42 AM
smartctl (739 KB) smartctl Sean Fagan, 05/10/2017 11:42 AM

Associated revisions

Revision 2b35b1bc (diff)
Added by Sean Fagan over 3 years ago

Cherry-pick a change from the authors. Ticket: #23790

History

#1 Updated by Bonnie Follweiler over 3 years ago

#2 Updated by William Grzybowski over 3 years ago

  • Status changed from Unscreened to Screened
  • Priority changed from No priority to Important
  • Target version set to 11.1

Thanks for the heads up but I guess we will have to wait for the smartmontools 6.6 make an appearance in FreeBSD.

#3 Avatar?id=14398&size=24x24 Updated by Kris Moore over 3 years ago

  • Assignee changed from William Grzybowski to Sean Fagan

Load balancing!

#4 Updated by Sean Fagan over 3 years ago

  • Status changed from Screened to Unscreened

#5 Updated by Sean Fagan over 3 years ago

So the options are to wait for the new release to be, um, released, and then have the freebsd port updated, or to create our own version of the port with its own patches.

That' about right?

#6 Avatar?id=14398&size=24x24 Updated by Kris Moore over 3 years ago

Yea, this one we probably need to just sit on until its fixed upstream. Unless we want to bring the fixed patch into our ports tree in the form of a files/ patch?

Looks like this is the fixed commit?

https://www.smartmontools.org/changeset/4425

#7 Updated by Sean Fagan over 3 years ago

That's what I meant about having our own version of the port.

#8 Updated by Sean Fagan over 3 years ago

  • Status changed from Unscreened to Investigation

#9 Updated by Sean Fagan over 3 years ago

Can you try the attached versions of the smart tools? (They go in /usr/local/sbin)

#10 Updated by Paul Warwicker over 3 years ago

Sean Fagan wrote:

Can you try the attached versions of the smart tools? (They go in /usr/local/sbin)

Thanks for building this.

Slight improvement. The overall assessment is now that the drive has passed, which is the expected output, but preceding this is still a SMART Status command failed message. The layout and content of that message is now slightly different to the released version.

Updated version

[root@oracle] /mnt/oracle01/local/data/uploads# ./smartctl -H /dev/ada0
smartctl 6.5 2016-05-07 r4318 [FreeBSD 11.0-STABLE amd64] (local build)
Copyright (C) 2002-16, Bruce Allen, Christian Franke, www.smartmontools.org

=== START OF READ SMART DATA SECTION ===
SMART Status command failed
Please get assistance from http://www.smartmontools.org/
Register values returned from SMART Status command are:
ERR=0x00, SC=0xff, LL=0xff, LM=0xff, LH=0xff, DEV=...., STS=....
SMART Status not supported: Invalid ATA output register values

SMART overall-health self-assessment test result: PASSED
Warning: This result is based on an Attribute check.

[root@oracle]

Released version

[root@oracle] /mnt/oracle01/local/data/uploads# /usr/local/sbin/smartctl -H /dev/ada0
smartctl 6.5 2016-05-07 r4318 [FreeBSD 11.0-STABLE amd64] (local build)
Copyright (C) 2002-16, Bruce Allen, Christian Franke, www.smartmontools.org

=== START OF READ SMART DATA SECTION ===
Error SMART Status command failed
Please get assistance from
http://www.smartmontools.org/
Register values returned from SMART Status command are:
CMD=0xb0
FR =0xda
NS =0xffff
SC =0xff
CL =0xff
CH =0xff
RETURN =0x0000

SMART overall-health self-assessment test result: FAILED!
Drive failure expected in less than 24 hours. SAVE ALL DATA.
No failed Attributes found.

[root@oracle]

Updated version (expected output - different drive)

[root@oracle] /mnt/oracle01/local/data/uploads# ./smartctl -H /dev/ada3
smartctl 6.5 2016-05-07 r4318 [FreeBSD 11.0-STABLE amd64] (local build)
Copyright (C) 2002-16, Bruce Allen, Christian Franke, www.smartmontools.org

=== START OF READ SMART DATA SECTION ===
SMART overall-health self-assessment test result: PASSED

[root@oracle]

#11 Updated by Sean Fagan over 3 years ago

Which leaves me mostly inclined to put it in the build, but what do you think?

The disadvantage of putting it into our build is we need to make sure we notice when the freebsd port is updated. :)

#12 Avatar?id=14398&size=24x24 Updated by Kris Moore over 3 years ago

Sean,

Yea, lets go ahead and merge this into our ports tree. If you bump PORTREV when we merge to a newer quarterly branch it should throw some merge conflicts and remind us to drop that patch.

If you can do that soon, we can get a FIX branch made and sneak it into 11.0 as well.

#13 Updated by Sean Fagan over 3 years ago

I was actually going to put it into freenas/nas_ports

I can put it into the ports repo, however.

#14 Updated by Sean Fagan over 3 years ago

  • Status changed from 15 to 19
  • Assignee changed from Sean Fagan to Vaibhav Chauhan

Okay, it's FIX-23790 in ports. Over to VB to integrate, I guess.

#15 Updated by Vaibhav Chauhan over 3 years ago

can this be set to Needs Review?

#16 Updated by Vaibhav Chauhan over 3 years ago

  • Status changed from 19 to 15
  • Assignee changed from Vaibhav Chauhan to Sean Fagan

#17 Updated by Sean Fagan over 3 years ago

  • Status changed from 15 to Needs Developer Review

Sure, go ahead.

#18 Updated by Vaibhav Chauhan over 3 years ago

  • Assignee changed from Sean Fagan to Kris Moore

can you please review?

#19 Avatar?id=14398&size=24x24 Updated by Kris Moore over 3 years ago

  • Status changed from Needs Developer Review to Reviewed
  • Assignee changed from Kris Moore to Sean Fagan
  • Target version changed from 11.1 to 11.0

Took a look, appears good here! Sean, can you make a FIX branch so we can sneak this into 11.0 or do you have some other concerns that would prevent doing it?

#20 Updated by Sean Fagan over 3 years ago

See above, it was already in a fix branch.

#21 Avatar?id=14398&size=24x24 Updated by Kris Moore over 3 years ago

Oh, I missed that. Target is set for 11.0 now though, VB should be able to take it from here. Thanks Sean!

#22 Updated by Vaibhav Chauhan over 3 years ago

I have merged the changes in freenas/11.0-stable, but there were bunch of merge conflicts, all that information is over there,

https://github.com/freenas/ports/compare/b5a47a31ccc6...ab49b8dd10a2

#23 Updated by Vaibhav Chauhan over 3 years ago

  • Status changed from Reviewed to Merged

#24 Updated by Vaibhav Chauhan over 3 years ago

  • Target version changed from 11.0 to 11.0-RC3

#25 Updated by Vaibhav Chauhan over 3 years ago

  • Status changed from Merged to Resolved

#26 Avatar?id=14398&size=24x24 Updated by Kris Moore over 3 years ago

  • Seen in changed from Unspecified to N/A

Also available in: Atom PDF