Project

General

Profile

Bug #23923

Add validation for NFS network and hosts fields in new UI

Added by Cyber Jock almost 3 years ago. Updated about 1 year ago.

Status:
Done
Priority:
Nice to have
Assignee:
Vaibhav Chauhan
Category:
GUI (new)
Target version:
Seen in:
TrueNAS - TrueNAS-9.10.2-U3
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

When creating NFS shares you have the option of setting "Authorized networks" and Authorized IP addresses or hosts". A TrueNAS customer got this backwards and was unable to identify the issue. The logs give the clue, but the customer didn't have the footer enabled. The system had a hostname of "192.168.2.1/24"

May 11 18:05:54 stars mountd3820: can't get address info for host 192.168.2.1/24
May 11 18:05:54 stars mountd3820: bad host 192.168.2.1/24, skipping
May 11 18:05:54 stars mountd3820: bad exports list line /mnt/tank 192.168.2.1/24

In the above example, the hostname or IP was added as an authorized network.

We should add some sane checks and let the WebGUI reject names that aren't clearly IPs or possible hostnames (a / character clearly won't represent an IP or hostname).

Associated revisions

Revision 409e3ad4 (diff)
Added by Erin Clark over 1 year ago

Add regex for ipv4 and ipv6 with cidr Ticket: #23923

Revision 7a62f823 (diff)
Added by Erin Clark over 1 year ago

Add IPv4 mapped IPv6 support to the regex just in case Ticket: #23923

Revision cfab0a87 (diff)
Added by Erin Clark over 1 year ago

Add IPv4 mapped IPv6 support to the regex just in case Ticket: #23923 (cherry picked from commit 7a62f823727827699d3f093c3d94e778c4e8a1e9)

History

#1 Avatar?id=14398&size=24x24 Updated by Kris Moore almost 3 years ago

  • Assignee set to Anonymous
  • Target version set to TrueNAS 11.1-U1

#2 Updated by Anonymous almost 3 years ago

  • Status changed from Unscreened to Screened

#3 Updated by Bartosz Prokop almost 3 years ago

  • Assignee changed from Anonymous to Bartosz Prokop

#4 Updated by Dru Lavigne over 2 years ago

  • Project changed from TrueNAS to FreeNAS
  • Category changed from Middleware to Middleware
  • Target version deleted (TrueNAS 11.1-U1)

This bug is not specific to TrueNAS.

#5 Updated by Dru Lavigne over 2 years ago

  • Category changed from Middleware to GUI (new)
  • Assignee changed from Bartosz Prokop to Lola Yang
  • Target version set to 11.2-BETA1

Lolad: please load balance. If a middleware piece is needed, please create a separate ticket for William.

#6 Updated by Lola Yang over 2 years ago

  • Assignee changed from Lola Yang to Daisuke Imai

#7 Updated by Dru Lavigne about 2 years ago

  • Status changed from Screened to Unscreened
  • Assignee changed from Daisuke Imai to Erin Clark

Erin: please load balance.

#8 Updated by Erin Clark about 2 years ago

  • Status changed from Unscreened to Screened

#9 Updated by Dru Lavigne about 2 years ago

  • Status changed from Screened to Not Started

#10 Avatar?id=13649&size=24x24 Updated by Ben Gadd almost 2 years ago

  • Due date set to 03/09/2018

#11 Avatar?id=13649&size=24x24 Updated by Ben Gadd almost 2 years ago

  • Due date deleted (03/09/2018)
  • Target version changed from 11.2-BETA1 to 11.3

#12 Avatar?id=13649&size=24x24 Updated by Ben Gadd almost 2 years ago

  • Due date set to 07/20/2018

#13 Avatar?id=13649&size=24x24 Updated by Ben Gadd almost 2 years ago

  • Target version changed from 11.3 to Backlog

#14 Avatar?id=13649&size=24x24 Updated by Ben Gadd almost 2 years ago

  • Severity set to New

#15 Updated by Dru Lavigne over 1 year ago

  • Subject changed from Sanity check to input data for NFS sharing to Add validation for NFS network/hosts fields
  • Target version changed from Backlog to 11.2-RC1

#16 Updated by Erin Clark over 1 year ago

  • Assignee changed from Erin Clark to Vaibhav Chauhan

#17 Updated by Dru Lavigne over 1 year ago

  • Target version changed from 11.2-RC1 to 11.2-RC2

#18 Updated by Vaibhav Chauhan over 1 year ago

  • Status changed from Not Started to In Progress

#19 Updated by Vaibhav Chauhan over 1 year ago

  • Status changed from In Progress to Ready for Testing

#20 Updated by Dru Lavigne over 1 year ago

  • Subject changed from Add validation for NFS network/hosts fields to Add validation for NFS network and hosts fields
  • Needs Merging changed from Yes to No

#21 Updated by Dru Lavigne over 1 year ago

  • Subject changed from Add validation for NFS network and hosts fields to Add validation for NFS network and hosts fields in new UI

#22 Updated by Jeff Ervin over 1 year ago

36981

Test Failed FreeNAS-11.2-INTERNAL29

You get the validation with the Authorized Networks input, but not the Authorized Hosts and IP Addresses area. Should the save button be grayed out when there's an issue with an input field on a page? I could still access this (though it didn't save the info, after I backed out and came back in) (See screenshot)

#24 Updated by Dru Lavigne over 1 year ago

  • Needs Doc changed from Yes to No

#26 Updated by Vaibhav Chauhan over 1 year ago

  • Status changed from Failed Testing to In Progress
  • Assignee changed from Vaibhav Chauhan to Jeff Ervin

#28 Updated by Dru Lavigne over 1 year ago

  • Status changed from In Progress to Ready for Testing
  • Assignee changed from Jeff Ervin to Vaibhav Chauhan

#29 Updated by Erin Clark over 1 year ago

  • Status changed from Ready for Testing to In Progress

#31 Updated by Dru Lavigne over 1 year ago

  • Status changed from In Progress to Ready for Testing

#32 Updated by Jeff Ervin over 1 year ago

39795
39804
39813

Test Passed FreeNAS-11.2-INTERNAL41

Received test case from Vaibhav Chauhan. Values inputted as specified. Option to save is unavailable for erroneous entries. Save available for accurate entries.

#33 Updated by Dru Lavigne over 1 year ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF