Feature #23978
Enable VLAN priority code point (vlanpcp) for CoS classification
Description
It would be great and extremely interesting in datacenter environments to have control about the VLAN priority code point to classify storage traffic on a given VLAN interface.
FreeBSD 11.0-STABLE [[https://svnweb.freebsd.org/base?view=revision&revision=301496]] already supports this, and it's just a question of enabling a field on the web interface to set the 3 byte value of the CoS field on the 802.1q frame.
I've done simple tests on FreeNAS 11.0-RC and I was able to set the vlanpcp over the CLI:
[root@freenas ~]# ifconfig vlan1 vlan1: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500 options=3<RXCSUM,TXCSUM> ether 00:0c:29:06:33:14 nd6 options=9<PERFORMNUD,IFDISABLED> media: Ethernet autoselect (1000baseT <full-duplex>) status: active vlan: 10 vlanpcp: 0 parent interface: em0 groups: vlan [root@freenas ~]# ifconfig vlan1 vlanpcp 4 [root@freenas ~]# ifconfig vlan1 vlan1: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500 options=3<RXCSUM,TXCSUM> ether 00:0c:29:06:33:14 nd6 options=9<PERFORMNUD,IFDISABLED> media: Ethernet autoselect (1000baseT <full-duplex>) status: active vlan: 10 vlanpcp: 4 parent interface: em0 groups: vlan [root@freenas ~]
Enabling this would be breakthrough for implement Lossless iSCSI traffic on DCB Enabled switches that relies on CoS Classification to match the iSCSI traffic.
Associated revisions
History
#1
Updated by William Grzybowski over 3 years ago
- Status changed from Unscreened to 15
Can't you just use the auxiliary options field for that?
#2
Updated by Vinícius Ferrão over 3 years ago
Definitely I can do this. But since it's a new feature from 11.0-STABLE and it's working on FreeNAS 11.0-RC backend would be really cool if this got a field on the web interface.
The major reason I'm asking this is because of the visibility and placement of FreeNAS/TrueNAS on the Datacenter. Some comercial appliances already does that as part of it's DCB [[https://en.wikipedia.org/wiki/Data_center_bridging]] implementation. NetApp for instance does this transparently: [[https://kb.netapp.com/support/s/article/ka21A0000000kgkQAA/does-the-storage-system-set-the-cos-field-on-a-vlan-tagged-frame]]
And finally, it appears to be a really simple feature to be implemented on the web interface. CoS 4 is the commonly used value for iSCSI traffic for instance, a simply checkbox with something like: "Enable this VLAN for CoS tagging" and defaulting to vlanpcp 4 would be sufficient and error free.
#3
Updated by William Grzybowski over 3 years ago
- Status changed from 15 to Screened
- Target version set to 11.1
#4
Updated by William Grzybowski over 3 years ago
- Status changed from Screened to Fix In Progress
#5
Updated by William Grzybowski over 3 years ago
- Status changed from Fix In Progress to Needs Developer Review
- Assignee changed from William Grzybowski to Marcelo Araujo
#6
Updated by Marcelo Araujo over 3 years ago
- Status changed from Needs Developer Review to Reviewed by Developer
- Assignee changed from Marcelo Araujo to William Grzybowski
LGTM!
#7
Updated by William Grzybowski over 3 years ago
- Status changed from Reviewed by Developer to Ready For Release
#8
Updated by Dru Lavigne over 3 years ago
- Subject changed from Enable VLAN priority code point (vlanpcp) for CoS classification on Web Interface to Enable VLAN priority code point (vlanpcp) for CoS classification
#9
Updated by Dru Lavigne over 3 years ago
- Target version changed from 11.1 to 11.1-BETA1
#10
Updated by Dru Lavigne about 3 years ago
- Status changed from Ready For Release to Resolved
#11
Updated by Nick Wolff about 3 years ago
- Needs QA changed from Yes to No
- QA Status Test Passes FreeNAS added
- QA Status deleted (
Not Tested)
Verified priority is setting on interface properly and also via tcpdump. Test passes