Project

General

Profile

Bug #24071

Add VM device to API

Added by Vaibhav Chauhan almost 2 years ago. Updated over 1 year ago.

Status:
Resolved
Priority:
No priority
Assignee:
Vaibhav Chauhan
Category:
Middleware
Target version:
11.1-BETA1
Seen in:
Master - FreeNAS Nightlies
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
Yes
Needs Merging:
Yes
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

had a conversation with marcelo, he convinced me to use websocket instead of REST API. which is fine by me.

I need following items from marcelo. ()

1). need more elaborate examples in VM section http://10.211.1.193/api/docs/#vm, which specifies how a websocket calls with args would look like,

midclt call vm.update '1' '{"devices": [{"dtype": "VNC", "attributes": {"wait": true, "vnc_port": "9100", "vnc_resolution": "640x480"}}, {"dtype": "NIC", "attributes": {"type": "VIRTIO", "mac": "00:a0:98:FF:FF:CC"}}, {"dtype": "CDROM", "attributes": {"path": null}}, {"dtype": "DISK", "attributes": {"path": "/dev/", "type": ""}}, {"dtype": "NIC", "attributes": {"type": "", "mac": ""}}, {"dtype": "VNC", "attributes": {"wait": true, "vnc_port": "2026", "vnc_resolution": "1024x768"}}]}'

2). clearly, state the limitations of the existing calls in the documentation.

Subtasks

Bug #24072: please provide the following for 24071Closed: Not ApplicableMarcelo Araujo

Associated revisions

Revision 0df70901 (diff)
Added by vaibhav-rbs over 1 year ago

WIP commit

Ticket: #24071

Revision 3c52cee8 (diff)
Added by vaibhav-rbs over 1 year ago

WIP commit

Ticket: #24071

Revision 7ce4bc48 (diff)
Added by Vaibhav Chauhan over 1 year ago

Added Bool method to utils.

Ticket: #24071

Revision 59dd1eaf (diff)
Added by vaibhav-rbs over 1 year ago

websocket API payload should be an Object.

Ticket: #24071

Revision 63b5409f (diff)
Added by vaibhav-rbs over 1 year ago

Remove RestService imports and initilization as it's not needed anymore.

Ticket: #24071

History

#1 Updated by Vaibhav Chauhan almost 2 years ago

  • Subject changed from VM edit makes use of websocket instead of REST API. to VM device edit makes use of websocket instead of REST API.

#2 Avatar?id=14398&size=24x24 Updated by Kris Moore almost 2 years ago

  • Target version changed from 11.0 to 11.1

#3 Updated by Vaibhav Chauhan over 1 year ago

  • Status changed from Unscreened to Screened

#4 Updated by Vaibhav Chauhan over 1 year ago

  • Status changed from Screened to Resolved

#5 Updated by Dru Lavigne over 1 year ago

  • Subject changed from VM device edit makes use of websocket instead of REST API. to Add VM device to API

#6 Updated by Dru Lavigne over 1 year ago

  • Target version changed from 11.1 to 11.1-BETA1

#7 Updated by Joe Maloney over 1 year ago

  • Needs QA changed from Yes to No
  • QA Status deleted (Not Tested)

Also available in: Atom PDF