Project

General

Profile

Bug #24086

afp global auxiliary parameters not applied properly

Added by Nathan Labrum over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
No priority
Assignee:
Brandon Schneider
Category:
OS
Target version:
Seen in:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
Yes
Needs Doc:
Yes
Needs Merging:
Yes
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

When attempting to change the hostname used for afp shares the hostname configured isn't applied. Looking at the afp.conf file it appears that the global aux parameter is appended incorrectly as it adds a b' ' to the parameter.

[Global]
        uam list = uams_dhx.so uams_dhx2.so
        max connections = 50
        mimic model = RackMac
        vol dbnest = yes
        b'hostname = media-afp'
        map acls = rights
        chmod request = preserve

Modifying the /usr/local/libexec/nas/generate_afpd_conf.py from

    if afp.afp_srv_global_aux:
        cf_contents.append("\t%s\n" % afp.afp_srv_global_aux.encode('utf8'))

to
    if afp.afp_srv_global_aux:
        cf_contents.append("\t%s\n" % afp.afp_srv_global_aux)

fixes the issue as the afp.conf is now generated as
[Global]
    uam list = uams_dhx.so uams_dhx2.so
    max connections = 50
    mimic model = RackMac
    vol dbnest = yes
    hostname = media-afp
    map acls = rights
    chmod request = preserve

Something is broken when attempting to encode the global aux parameters to utf8.

Associated revisions

Revision 2a73371a (diff)
Added by Brandon Schneider over 3 years ago

Fix bad Python 2 -> 3 conversion for afp gloabl auxiliary parameters. Ticket: #24086

Revision 9d439092 (diff)
Added by Brandon Schneider over 3 years ago

Fix bad Python 2 -> 3 conversion for afp gloabl auxiliary parameters. Ticket: #24086

History

#1 Avatar?id=14398&size=24x24 Updated by Kris Moore over 3 years ago

  • Assignee changed from Suraj Ravichandran to Brandon Schneider
  • Target version set to 11.0

Brandon, looks like an easy fix and you like Apple... ;)

#2 Updated by Brandon Schneider over 3 years ago

  • Status changed from Unscreened to 15
  • Assignee changed from Brandon Schneider to Kris Moore

#3 Avatar?id=14398&size=24x24 Updated by Kris Moore over 3 years ago

  • Status changed from 15 to Reviewed
  • Assignee changed from Kris Moore to Brandon Schneider

Lgtm

#4 Updated by Vaibhav Chauhan over 3 years ago

  • Status changed from Reviewed to Merged

#5 Updated by Dru Lavigne over 3 years ago

This is showing in the U3 query-should it's target version be updated?

#6 Avatar?id=14398&size=24x24 Updated by Kris Moore over 3 years ago

  • Target version changed from 11.0 to 11.0-RC3

#7 Updated by Vaibhav Chauhan over 3 years ago

  • Status changed from Merged to Resolved

Also available in: Atom PDF