Project

General

Profile

Bug #24180

Don't show stacktraces

Added by John Hixson over 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
Nice to have
Assignee:
ChenTao Wang
Category:
GUI (new)
Seen in:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
Yes
Needs Doc:
Yes
Needs Merging:
Yes
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Yes, I have to actually make a ticket for this. Let's get rid of stack traces wherever they may be and show well formatted errors instead.

Associated revisions

Revision a8e54144 (diff)
Added by ChenTao Wang almost 3 years ago

Adding an error dialog component, Ticket: #24180

Revision 355e24ab
Added by Kris Moore almost 3 years ago

Merge pull request #58 from freenas/chentao-fix-#24180 Adding an error dialog component, Ticket: #24180

History

#1 Updated by William Grzybowski over 3 years ago

  • Status changed from Unscreened to Screened

#2 Updated by William Grzybowski over 3 years ago

  • Target version changed from 49 to 11.1

#3 Updated by William Grzybowski over 3 years ago

  • Target version changed from 11.1 to 11.2-BETA1

#4 Updated by William Grzybowski over 3 years ago

  • Priority changed from No priority to Nice to have
  • Seen in changed from Unspecified to 11.0

#5 Updated by William Grzybowski about 3 years ago

  • Category changed from Middleware to GUI (new)
  • Status changed from Screened to Unscreened
  • Assignee changed from William Grzybowski to Erin Clark

This will only happen in new UI.

#6 Updated by Erin Clark about 3 years ago

  • Status changed from Unscreened to Screened

#7 Avatar?id=14398&size=24x24 Updated by Kris Moore almost 3 years ago

  • Assignee changed from Erin Clark to ChenTao Wang

Chen,

Here's what I'm thinking on how to do this. When we get an error back from the API (it may or may not contain a stack trace), we should have some generic modal dialog we can display in the UI. It should have an "expand" text / down arrow which can be clicked to show the raw output from the API (for debug purposes), but the primary text should be something relevant to the error that failed. I.E. in JS you'd call it after an error with some human readable text as the primary message, such as "Failed to create snapshot", "Failed to delete volume", etc etc.

This should be something we then share with the rest of the UI team so we can begin using this Standard Error dialog any place in the code possible, and not have each developer coding up their own errors everywhere.

#8 Updated by ChenTao Wang almost 3 years ago

  • Status changed from Screened to Needs Developer Review

#9 Updated by ChenTao Wang almost 3 years ago

ChenTao Wang wrote:

This error dialog modal can be called by the following code:

this.dialogService.errorReport("title", "description", "traceback -- error").subscribe((res) => { });

#10 Updated by Dru Lavigne almost 3 years ago

Chen: what is the URL to the PR for the reviewer?

#11 Updated by ChenTao Wang almost 3 years ago

#12 Updated by Dru Lavigne almost 3 years ago

  • Assignee changed from ChenTao Wang to Lola Yang

#13 Updated by Lola Yang almost 3 years ago

  • Status changed from Needs Developer Review to 15

PR is already merged to master branch.

#14 Updated by Lola Yang almost 3 years ago

  • Assignee changed from Lola Yang to ChenTao Wang

#15 Updated by Dru Lavigne almost 3 years ago

  • Status changed from 15 to Resolved
  • Target version changed from 11.2-BETA1 to Master - FreeNAS Nightlies

Also available in: Atom PDF