Project

General

Profile

Bug #24282

Make ctlstat -n option work reasonably for sparse LUN list

Added by Josh Paetzel about 2 years ago. Updated about 1 year ago.

Status:
Done
Priority:
Nice to have
Assignee:
Alexander Motin
Category:
OS
Target version:
Seen in:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Somewhere along the line lun numbering got added to ctl.conf.

root@fn:~ # grep ctl-lun /etc/ctl.conf
ctl-lun 5
ctl-lun 4
ctl-lun 9
ctl-lun 12
ctl-lun 13
ctl-lun 8

However this now mens that:

root@fn:~ # ctlstat
CPU

3%
3%
0%
5%
^C

I have to do ctlstat -n 13 to see all my luns, and I can only get the 13 number by grepping /etc/ctl.conf

root@fn:~ # cat /etc/version
FreeNAS-11-MASTER-201705160408 (c9c8d95)

History

#1 Updated by Alexander Motin about 2 years ago

  • Status changed from Unscreened to Screened

It's a valid complain, though previously it shown only first three LUNs by default, so it was not exactly perfect either. `ctlstat -t` may be more useful as default to see full stats.

#2 Updated by Dru Lavigne almost 2 years ago

  • Status changed from Screened to 46

Sasha: do you have a target version for this one?

#3 Updated by Alexander Motin almost 2 years ago

  • Status changed from 46 to Screened
  • Priority changed from No priority to Nice to have
  • Target version set to 11.2-BETA1

I don't have specific target for it. It is from "nice to have" area, so it can wait while I have time or other reason to get that area.

#4 Updated by Alexander Motin over 1 year ago

  • Status changed from Screened to Fix In Progress

I've committed a patch to FreeBSD head at r326273.

#5 Updated by Dru Lavigne over 1 year ago

  • Status changed from Fix In Progress to Resolved
  • Target version changed from 11.2-BETA1 to 12.0

Already in upstream, we'll wait for it in 12.

#6 Updated by Dru Lavigne over 1 year ago

  • Status changed from Resolved to Fix In Progress
  • Target version changed from 12.0 to 11.2-BETA1

After discussion with Sasha, he will backport this to FreeBSD 11. Retargeting to 11.2.

#7 Updated by Alexander Motin over 1 year ago

  • Subject changed from the defaults for ctlstat don't play nicely with the new ctl.conf config to ctlstat don't play nicely with sparse LUNs
  • Status changed from Fix In Progress to Ready For Release

I've merged my ctlstat changes into 11-stable branch. Should be ready for 11.2.

#8 Updated by Dru Lavigne over 1 year ago

  • Subject changed from ctlstat don't play nicely with sparse LUNs to Make ctlstat -n option work reasonably for sparse LUN list
  • Status changed from Ready For Release to Done
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#9 Updated by Alexander Motin over 1 year ago

#10 Updated by Dru Lavigne about 1 year ago

  • Status changed from Done to Ready for Testing

#11 Updated by Eric Turgeon about 1 year ago

  • Status changed from Ready for Testing to Passed Testing
  • Severity set to New
  • Needs QA changed from Yes to No

This looks to work fine now.

#12 Updated by Dru Lavigne about 1 year ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF