Project

General

Profile

Feature #24337

Add disk description to title of disk reporting graphs

Added by Rex Wheeler over 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Nice to have
Assignee:
Suraj Ravichandran
Category:
Middleware
Target version:
11.1-BETA1
Estimated time:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
Yes
Needs Merging:
Yes
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:

Description

Currently the disk reporting graphs show the device name of each disk. It would be helpful if the titles for the disk graphs also included the user defined description field for the disk. When I look at the disk graphs, I frequently need to go look at the disk list to correlate device names to the actual drives. Navigating to the disk list is an extra step that could be easily eliminated when asking questions like "Which drive was the ZIL and which was the Cache?" or "Hey that device is really busy, which drive is it?" Having the description in the graph title would make screen captures of the graphs more useful.

Screenshots from 11.0-RC3 suggesting how the change might look. If this ends up in the new UI, it would need to work with the whatever the new UI layout is, but the point is that when looking at disk performance graphs, it would be nice to have the user defined disk label displayed along with the device name:


disk_list.JPG (36.3 KB) disk_list.JPG Rex Wheeler, 06/02/2017 09:27 AM
disk_graph.JPG (90.8 KB) disk_graph.JPG Rex Wheeler, 06/02/2017 09:27 AM
11343
11344

Associated revisions

Revision dd97fd85 (diff)
Added by Suraj Ravichandran over 3 years ago

Add generic cache_with_refresh decorator to middlewred utils. Ticket: #24337

Revision 06c4c621 (diff)
Added by Suraj Ravichandran over 3 years ago

Add disk description to title of disk reporting graphs Ticket: #24337

Revision 876bb134 (diff)
Added by Suraj Ravichandran over 3 years ago

Remove this first cache (will have to find some other way to solve the timeout issues in some disk reporting graphs) This was breaking the build. Ticket: #24337

Revision 65b9729d (diff)
Added by Suraj Ravichandran over 3 years ago

Clear race condition that was causing the decorator to return None sometimes. Ticket: #24337

Revision 38d0c137 (diff)
Added by Suraj Ravichandran over 3 years ago

Add generic cache_with_refresh decorator to middlewred utils. Ticket: #24337

Revision c5ed83c7 (diff)
Added by Suraj Ravichandran over 3 years ago

Add disk description to title of disk reporting graphs Ticket: #24337

Revision 5987073a (diff)
Added by Suraj Ravichandran over 3 years ago

Remove this first cache (will have to find some other way to solve the timeout issues in some disk reporting graphs) This was breaking the build. Ticket: #24337

Revision 8faf8f24 (diff)
Added by Suraj Ravichandran over 3 years ago

Clear race condition that was causing the decorator to return None sometimes. Ticket: #24337

History

#1 Updated by Suraj Ravichandran over 3 years ago

  • Status changed from Unscreened to Screened
  • Priority changed from No priority to Nice to have
  • Target version set to 11.1

I agree with you.

#2 Updated by Stuart Espey over 3 years ago

Suraj Ravichandran wrote:

I agree with you.

I'd like this feature too

#3 Updated by Suraj Ravichandran over 3 years ago

  • Status changed from Screened to Needs Developer Review
  • Assignee changed from Suraj Ravichandran to William Grzybowski
  • Target version changed from 11.1 to 11.0-U1

#4 Updated by William Grzybowski over 3 years ago

  • Status changed from Needs Developer Review to Unscreened
  • Assignee changed from William Grzybowski to Suraj Ravichandran

This breaks the build, trying to access middleware during build time (migration run)

Also, can it wait for 11.1?

#5 Updated by Suraj Ravichandran over 3 years ago

  • Status changed from Unscreened to Fix In Progress
  • Target version changed from 11.0-U1 to 11.1
  • % Done changed from 0 to 90

Sure, removed the build breaking bits, will fix in a non-build breaking way later, for now its good

#6 Updated by Suraj Ravichandran over 3 years ago

  • Status changed from Fix In Progress to Needs Developer Review
  • Assignee changed from Suraj Ravichandran to William Grzybowski
  • % Done changed from 90 to 100

Hey william, I found the right fix to what we discussed yesterday (it was indeed an issue with the decorator)

I am however still keeping this or 11.1 (soak time and such per your suggestion)

Please review it again when you get the time.

Thanks

#7 Updated by William Grzybowski over 3 years ago

  • Assignee changed from William Grzybowski to Suraj Ravichandran

lgtm

#8 Updated by William Grzybowski over 3 years ago

  • Status changed from Needs Developer Review to Reviewed

#9 Avatar?id=14398&size=24x24 Updated by Kris Moore over 3 years ago

  • Status changed from Reviewed to Reviewed by Developer

#10 Updated by Dru Lavigne over 3 years ago

  • Status changed from Reviewed by Developer to Ready For Release
  • Target version changed from 11.1 to 11.1-BETA1

#11 Updated by Dru Lavigne about 3 years ago

  • Status changed from Ready For Release to Resolved

#12 Updated by Bonnie Follweiler about 3 years ago

  • Needs QA changed from Yes to No
  • QA Status Test Passes FreeNAS added
  • QA Status deleted (Not Tested)

It passes as long as the FreeNAS is rebooted after the description is saved

Also available in: Atom PDF