Project

General

Profile

Bug #25061

Traceback if gateway is empty

Added by William Grzybowski over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Critical
Assignee:
William Grzybowski
Category:
GUI (new)
Target version:
Seen in:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
Yes
Needs Doc:
Yes
Needs Merging:
Yes
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

FullRaw
AttributeError: 'str' object has no attribute 'exploded'
  File "django/core/handlers/exception.py", line 39, in inner
    response = get_response(request)
  File "django/core/handlers/base.py", line 249, in _legacy_get_response
    response = self._get_response(request)
  File "django/core/handlers/base.py", line 178, in _get_response
    response = middleware_method(request, callback, callback_args, callback_kwargs)
  File "freenasUI/freeadmin/middleware.py", line 162, in process_view
    return login_required(view_func)(request, *view_args, **view_kwargs)
  File "django/contrib/auth/decorators.py", line 23, in _wrapped_view
    return view_func(request, *args, **kwargs)
  File "freenasUI/freeadmin/options.py", line 208, in wrapper
    return self._admin.admin_view(view)(*args, **kwargs)
  File "django/utils/decorators.py", line 149, in _wrapped_view
    response = view_func(request, *args, **kwargs)
  File "django/views/decorators/cache.py", line 57, in _wrapped_view_func
    response = view_func(request, *args, **kwargs)
  File "freenasUI/freeadmin/site.py", line 142, in inner
    return view(request, *args, **kwargs)
  File "freenasUI/freeadmin/options.py", line 551, in edit
    valid &= mf.is_valid(formsets=formsets)
  File "freenasUI/common/forms.py", line 136, in is_valid
    valid = super(ModelForm, self).is_valid()
  File "django/forms/forms.py", line 169, in is_valid
    return self.is_bound and not self.errors
  File "django/forms/forms.py", line 161, in errors
    self.full_clean()
  File "django/forms/forms.py", line 370, in full_clean
    self._clean_fields()
  File "django/forms/forms.py", line 391, in _clean_fields
    value = getattr(self, 'clean_%s' % name)()
  File "freenasUI/network/forms.py", line 564, in clean_gc_ipv4gateway
    return val
  File "freenasUI/network/forms.py", line 563, in clean_gc_ipv4gateway
    if c.call('routes.ipv4gw_reachable', val.exploded):

Associated revisions

Revision 421f94fb (diff)
Added by William Grzybowski over 4 years ago

fix(gui): make sure gateway is not empty, avoiding traceback Ticket: #25061

Revision 7316cb4c (diff)
Added by William Grzybowski over 4 years ago

fix(gui): make sure gateway is not empty, avoiding traceback Ticket: #25061 (cherry picked from commit 421f94fbd4578e4bc5bca4c9a0fd1e376be81ba2)

Revision c2046c89 (diff)
Added by William Grzybowski over 4 years ago

fix(gui): make sure gateway is not empty, avoiding traceback Ticket: #25061 (cherry picked from commit 421f94fbd4578e4bc5bca4c9a0fd1e376be81ba2)

Revision 41992345 (diff)
Added by William Grzybowski over 4 years ago

fix(gui): make sure gateway is not empty, avoiding traceback Ticket: #25061

History

#2 Updated by William Grzybowski over 4 years ago

  • Status changed from Screened to Needs Developer Review
  • Assignee changed from William Grzybowski to Marcelo Araujo

#3 Updated by Marcelo Araujo over 4 years ago

  • Status changed from Needs Developer Review to Reviewed by Developer
  • Assignee changed from Marcelo Araujo to William Grzybowski

LGTM!

#4 Updated by Vaibhav Chauhan over 4 years ago

  • Status changed from Reviewed by Developer to 42

changes were merged by kmoore,

#5 Updated by Joe Maloney over 4 years ago

  • Status changed from 42 to Ready For Release

#6 Updated by Joe Maloney over 4 years ago

  • QA Status Test Passes added
  • QA Status deleted (Not Tested)

Without setting gateway I tested with 10.20.0.204 after a fresh install, and confirmed this works as expected.

#7 Updated by Vaibhav Chauhan over 4 years ago

  • Status changed from Ready For Release to Resolved

Also available in: Atom PDF