Project

General

Profile

Bug #25101

Replace SMB min/max protocol fields with sysctls

Added by Stilez y over 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Nice to have
Assignee:
John Hixson
Category:
GUI (new)
Target version:
Seen in:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
Yes
Needs Merging:
Yes
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

The UI lets the minimum Samba version be left empty ("---------") but there isn't an entry in the drop-down list so one (apparently) can't leave the max version empty on saving the screen, or return it to "unset" if it's been used one time.

Can an "unset" option be added to the SELECT list for this control?

(Note, using 11.0 old UI, might need fixing in new UI as well)

Associated revisions

Revision dd80f81c (diff)
Added by John Hixson over 1 year ago

Set default value for SMB minimum protocol

Ticket: #25101

Revision 0adebe27 (diff)
Added by John Hixson over 1 year ago

Set default value for SMB minimum protocol

Ticket: #25101
(cherry picked from commit db1bf13d2752d692cc5f96570683526f15b7ed74)

Revision 04c6f2a1 (diff)
Added by John Hixson over 1 year ago

0012 -> 0013 : Lame.

Ticket: #25101

Revision 4e8d3a66 (diff)
Added by John Hixson over 1 year ago

0012 -> 0013 : Lame.

Ticket: #25101
(cherry picked from commit 04c6f2a11487bd0cfa559316d93899659b9d0298)

Revision 3680ee9c (diff)
Added by John Hixson over 1 year ago

Default to LANMAN1

Ticket: #25101

Revision c8a0e5aa (diff)
Added by John Hixson over 1 year ago

Default to LANMAN1

Ticket: #25101
(cherry picked from commit 3680ee9cc285e6ba5a1f26b610b697c7b93566b0)

Revision 691f59d8 (diff)
Added by John Hixson over 1 year ago

Set default value for SMB minimum protocol

Ticket: #25101

Revision 8a2df5c1 (diff)
Added by John Hixson over 1 year ago

0012 -> 0013 : Lame.

Ticket: #25101

Revision f2d6e546 (diff)
Added by John Hixson over 1 year ago

Default to LANMAN1

Ticket: #25101

Revision ac418004 (diff)
Added by Dru Lavigne about 1 year ago

Mention min/max protocol.
Ticket: #25101

History

#1 Updated by Dru Lavigne over 1 year ago

  • Assignee changed from Release Council to William Grzybowski

#2 Updated by William Grzybowski over 1 year ago

  • Status changed from Unscreened to Screened
  • Priority changed from No priority to Nice to have
  • Target version set to 11.1

#3 Updated by Stilez y over 1 year ago

On an aside, it isn't clear in the GUI that "SMB3" actually means "any version of 3.x" rather than "Version 3 original version only". In other words SMB3 and SMB3_00 are easily confused.

As a trivial change affecting GUI only and not middleware, can I suggest changing the dropdown UI text "-----", "SMB2" and "SMB3" in min+max, to read

----   ->       "(none)" 

SMB2   ->       "SMB2.*"   
            or: "SMB2 (any variant)" 

SMB3   ->       "SMB3.*" 
            or: "SMB3 (any variant)"

or similar, which aren't as ambiguous.

#4 Updated by an odos over 1 year ago

Stilez y wrote:

On an aside, it isn't clear in the GUI that "SMB3" actually means "any version of 3.x" rather than "Version 3 original version only". In other words SMB3 and SMB3_00 are easily confused.

As a trivial change affecting GUI only and not middleware, can I suggest changing the dropdown UI text "-----", "SMB2" and "SMB3" in min+max, to read

[...]

or similar, which aren't as ambiguous.

Well, technically the smb.conf manpage states

By default SMB3 selects the SMB3_11 variant.
The distinction between "any SMB3.x protocol" and "SMB3.11" is important if you set SMB3 to be "server min protocol" ;-)

#5 Updated by Stilez y over 1 year ago

"Technically" isn't a big deal compared to "helpful", when it comes to making the UI more straightforward without cost.

Sure, people who use samba in CLI may know the small print. But as FreeNAS has a NAS appliance webUI approach and is rather more geared to suit those who haven't read the man pages as well .... ;-) maybe we could make that (or a similar) edit anyway and avoid assuming a depth of knowledge that most users surely won't be expected to have :)

#6 Updated by William Grzybowski over 1 year ago

  • Status changed from Screened to Unscreened
  • Assignee changed from William Grzybowski to John Hixson

I am not sure of the side effects of doing this. Over to John since he is the Samba master.

#7 Updated by John Hixson over 1 year ago

  • Status changed from Unscreened to Needs Developer Review
  • Assignee changed from John Hixson to Release Council
  • Target version changed from 11.1 to 11.0-U3

"Fixed". I have a bad feeling about this. I'd really like the min and max protocol knobs to be hidden ;-) The values for these are negotiated by the protocol. Occasionally setting them is necessary or desired, but most of the time these are fiddled with when it isn't necessary thus causing things to break and bringing more tickets ;-)

commit:db1bf13d2752d692cc5f96570683526f15b7ed74
pull request: https://github.com/freenas/freenas/pull/270

#8 Updated by an odos over 1 year ago

John Hixson wrote:

"Fixed". I have a bad feeling about this. I'd really like the min and max protocol knobs to be hidden ;-) The values for these are negotiated by the protocol. Occasionally setting them is necessary or desired, but most of the time these are fiddled with when it isn't necessary thus causing things to break and bringing more tickets ;-)

commit:db1bf13d2752d692cc5f96570683526f15b7ed74
pull request: https://github.com/freenas/freenas/pull/270

John, out of curiosity is there a reason why FreeNAS defaults to "Core" for min protocol when Samba defaults to "LANMAN1"?

#9 Updated by Dru Lavigne over 1 year ago

  • Assignee changed from Release Council to Timur Bakeyev

#10 Updated by Timur Bakeyev over 1 year ago

  • Status changed from Needs Developer Review to Reviewed by Developer
  • Assignee changed from Timur Bakeyev to Release Council

Looks good to me, but I second the question - why CORE is the default?

#11 Updated by Dru Lavigne over 1 year ago

  • Assignee changed from Release Council to John Hixson

#12 Updated by Vaibhav Chauhan over 1 year ago

  • Status changed from Reviewed by Developer to Unscreened

as discussed on telegram we will have to rework this change

#13 Updated by Vaibhav Chauhan over 1 year ago

  • Target version changed from 11.0-U3 to 11.1

retargeting to 11.1

#14 Updated by John Hixson over 1 year ago

  • Status changed from Unscreened to Closed: Not Applicable

This isn't a thing in master, which will become 11.1

#15 Updated by Dru Lavigne over 1 year ago

  • Target version changed from 11.1 to N/A

#16 Updated by Dru Lavigne about 1 year ago

  • Subject changed from Cannot leave Samba max version empty to Replace SMB min/max protocol fields with sysctls
  • Status changed from Closed: Not Applicable to Resolved
  • Target version changed from N/A to 11.1-BETA1

#17 Updated by Joe Maloney about 1 year ago

  • Needs QA changed from Yes to No
  • QA Status Test Passes FreeNAS added
  • QA Status deleted (Not Tested)

Also available in: Atom PDF