Project

General

Profile

Bug #25106

Fix adtool traceback

Added by Kveldúlfur Þrastarson almost 4 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Important
Assignee:
John Hixson
Category:
OS
Target version:
Seen in:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
Yes
Needs Doc:
Yes
Needs Merging:
Yes
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Trying to use Active directory service results in a "active directory failed to reload" message and a debug log complaining about a type error:

Jul 12 12:04:16 freenas /adtool: [common.freenasldap:2349] ldap modify error: argument 1 must be str, not bytes
Traceback (most recent call last):
File "/usr/local/www/freenasUI/common/freenasldap.py", line 2342, in disable_machine_account
str(userAccountControl)
File "/usr/local/www/freenasUI/common/freenasldap.py", line 1852, in _modify
return handle._modify(dn, modlist)
File "/usr/local/www/freenasUI/common/freenasldap.py", line 501, in _modify
res = self._handle.modify_ext_s(dn, modlist)
File "/usr/local/lib/python3.6/site-packages/ldap/ldapobject.py", line 537, in modify_ext_s
msgid = self.modify_ext(dn,modlist,serverctrls,clientctrls)
File "/usr/local/lib/python3.6/site-packages/ldap/ldapobject.py", line 534, in modify_ext
return self._ldap_call(self._l.modify_ext,dn,modlist,RequestControlTuples(serverctrls),RequestControlTuples(clientctrls))
File "/usr/local/lib/python3.6/site-packages/ldap/ldapobject.py", line 263, in _ldap_call
Jul 12 12:04:16 freenas /adtool: result = func(args,*kwargs)
TypeError: argument 1 must be str, not bytes
Jul 12 12:04:16 freenas /adtool: [common.freenasldap:2352] FreeNAS_ActiveDirectory_Base.disable_machine_account: leave

computer object preserved.png (35.6 KB) computer object preserved.png Joe Maloney, 08/28/2017 12:34 PM
12323

Associated revisions

Revision 220de961 (diff)
Added by John Hixson over 3 years ago

Don't disable machine account - no longer necessary Ticket: #25106

Revision fafdbeb9 (diff)
Added by John Hixson over 3 years ago

Don't disable machine account - no longer necessary Ticket: #25106 (cherry picked from commit 220de96193ab58c48e1b5eb8c83189c1a4f36141)

Revision baced73b (diff)
Added by John Hixson over 3 years ago

Don't disable machine account - no longer necessary Ticket: #25106

History

#1 Updated by Kveldúlfur Þrastarson almost 4 years ago

  • File debug-freenas-20170712121038.txz added

#2 Updated by Kveldúlfur Þrastarson almost 4 years ago

  • File debug.log added

#3 Updated by Dru Lavigne almost 4 years ago

  • Assignee changed from Release Council to John Hixson
  • Seen in changed from Unspecified to 11.0-U1

#4 Updated by John Hixson almost 4 years ago

  • Status changed from Unscreened to Screened
  • Target version set to 11.1

#5 Updated by John Hixson over 3 years ago

  • Status changed from Screened to Needs Developer Review
  • Assignee changed from John Hixson to Release Council

#6 Updated by Dru Lavigne over 3 years ago

  • Assignee changed from Release Council to Timur Bakeyev

#7 Updated by Timur Bakeyev over 3 years ago

  • Status changed from Needs Developer Review to Reviewed by Developer
  • Assignee changed from Timur Bakeyev to Release Council

Looks good to me

#8 Updated by Dru Lavigne over 3 years ago

  • Assignee changed from Release Council to John Hixson

#9 Updated by John Hixson over 3 years ago

#10 Updated by Dru Lavigne over 3 years ago

  • File deleted (debug-freenas-20170712121038.txz)

#11 Updated by Dru Lavigne over 3 years ago

  • File deleted (debug.log)

#12 Updated by Dru Lavigne over 3 years ago

  • Private changed from Yes to No

#13 Updated by John Hixson over 3 years ago

  • Target version changed from 11.1 to 11.0-U3

#14 Updated by Vaibhav Chauhan over 3 years ago

  • Status changed from Reviewed by Developer to 47
  • Assignee changed from John Hixson to Joe Maloney
  • Priority changed from No priority to Important

#15 Updated by Joe Maloney over 3 years ago

12323

As shown in the screenshot I have verified that the machine account is preserved when joining in disjoining. The object is updated rather than destroyed, and recreated.

#16 Updated by Dru Lavigne over 3 years ago

  • Assignee changed from Joe Maloney to John Hixson

#17 Updated by Dru Lavigne over 3 years ago

  • Subject changed from adtool TypeError: argument 1 must be str, not bytes to Fix adtool traceback

#18 Updated by Vaibhav Chauhan over 3 years ago

  • Status changed from Ready For Release to Resolved

Also available in: Atom PDF