Project

General

Profile

Bug #25455

Pass S3 configuration options to Minio daemon

Added by Ben Agricola about 4 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority:
No priority
Assignee:
Marcelo Araujo
Category:
OS
Seen in:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
Yes
Needs Doc:
Yes
Needs Merging:
Yes
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

The code that loads minio settings in /etc/rc.conf.local does not handle all of the settings that are exposed by the S3 Service GUI - particularly, the bind IP and port which are entered into the UI appear to be completely ignored (amongst others).

It also appears that once enabled, it is not possible to disable the S3 service again since the variable is always set to 'YES' regardless of the contents of the s3_enable var.

        while read s3_enable s3_bindip s3_bindport s3_access_key \
                s3_secret_key s3_browser s3_mode s3_disks; do
                cat <<-__MINIO__
                        minio_enable="YES" 
                        minio_disks="${s3_disks}" 
                        minio_env="\\
                        MINIO_ACCESS_KEY=${s3_access_key} \\
                        MINIO_SECRET_KEY=${s3_secret_key} \\
                        " 
__MINIO__
                if [ "${s3_browser}" = "0" ]; then
                        echo MINIO_BROWSER=off
                fi
        done

My quick fix to test this is below:

        while read s3_enable s3_bindip s3_bindport s3_access_key \
                s3_secret_key s3_browser s3_mode s3_disks; do
                cat <<-__MINIO__
                        minio_enable="${s3_enable}" 
                        minio_disks="${s3_disks}" 
                        minio_address="${s3_bindip}:${s3_bindport}" 
                        minio_env="\\
                        MINIO_ACCESS_KEY=${s3_access_key} \\
                        MINIO_SECRET_KEY=${s3_secret_key} \\
                        " 
__MINIO__
                if [ "${s3_browser}" = "0" ]; then
                        echo MINIO_BROWSER=off
                fi
        done

With this, the bind ip and port at least are correctly passed to Minio.

Associated revisions

Revision a38fa7c6 (diff)
Added by Marcelo Araujo about 4 years ago

fix(s3): Make the configuration options from UI to be passed to daemon. Ticket: #25455 Submitted by: Ben Agricola.

Revision 44985e88 (diff)
Added by Marcelo Araujo about 4 years ago

fix(s3): Make the configuration options from UI to be passed to daemon. Ticket: #25455 Submitted by: Ben Agricola.

History

#1 Updated by Dru Lavigne about 4 years ago

  • Assignee changed from Release Council to Marcelo Araujo

Marcelo: does this go to you or William?

#2 Updated by Marcelo Araujo about 4 years ago

  • Status changed from Unscreened to Screened
  • Target version set to 11.1

#3 Updated by Marcelo Araujo about 4 years ago

  • Status changed from Screened to Reviewed by Developer
  • Assignee changed from Marcelo Araujo to William Grzybowski

Ben, thanks for the patch!

#4 Updated by Marcelo Araujo about 4 years ago

  • Status changed from Reviewed by Developer to Needs Developer Review

Ooops, I changed to the wrong status.

#5 Updated by William Grzybowski about 4 years ago

  • Status changed from Needs Developer Review to Reviewed by Developer
  • Assignee changed from William Grzybowski to Marcelo Araujo

#6 Updated by Dru Lavigne about 4 years ago

  • Subject changed from S3 (Minio) configuration options from UI not passed to daemon to Pass S3 configuration options to Minio daemon

#7 Updated by Dru Lavigne almost 4 years ago

  • Status changed from Reviewed by Developer to Ready For Release
  • Target version changed from 11.1 to 11.1-BETA1

#8 Updated by Dru Lavigne almost 4 years ago

  • Status changed from Ready For Release to Resolved

#9 Updated by Nick Wolff almost 4 years ago

What is the expected effect of the Enable Browser checkbox in settings. Checked or unchecked I can get to http://10.20.20.139:9003/minio/login . Only visible difference is once check UI button pops up.

#10 Updated by John Hixson almost 4 years ago

Nick Wolff wrote:

What is the expected effect of the Enable Browser checkbox in settings. Checked or unchecked I can get to http://10.20.20.139:9003/minio/login . Only visible difference is once check UI button pops up.

The expected effect is that the minio browser (web UI) is enabled ;-) If it's up when not checked, it's a bug.

#11 Updated by Nick Wolff almost 4 years ago

Ok as I expected but wanted to double check Marcelo do you want me to open additional bug or is this related enough that I should have this test fails.

#12 Updated by Dru Lavigne almost 4 years ago

  • Status changed from Resolved to Unscreened
  • Assignee changed from Marcelo Araujo to John Hixson
  • Target version changed from 11.1-BETA1 to 11.1

#13 Updated by Nick Wolff almost 4 years ago

  • QA Status Test Fails FreeNAS added
  • QA Status deleted (Not Tested)

#14 Updated by John Hixson almost 4 years ago

  • Status changed from Unscreened to Screened

#15 Avatar?id=14398&size=24x24 Updated by Kris Moore almost 4 years ago

  • Target version changed from 11.1 to 11.1-U1

#16 Updated by Dru Lavigne almost 4 years ago

  • Status changed from Screened to Resolved
  • Assignee changed from John Hixson to Marcelo Araujo
  • Target version changed from 11.1-U1 to Master - FreeNAS Nightlies

Also available in: Atom PDF