Bug #25479
Fix traceback when creating snapshot with existing name
Description
Hi,
Trying to create a ZFS snapshot with an existing name does not work (as expected) and crashes the GUI instead of reporting an error message.
Here is the stack trace:
Environment:
Software Version: FreeNAS-11.0-U2 (e417d8aa5)
Request Method: POST
Request URL: http://hive/storage/snapshot/create/sata-z/movies/
Traceback:
File "/usr/local/lib/python3.6/site-packages/django/core/handlers/exception.py" in inner
39. response = get_response(request)
File "/usr/local/lib/python3.6/site-packages/django/core/handlers/base.py" in _legacy_get_response
249. response = self._get_response(request)
File "/usr/local/lib/python3.6/site-packages/django/core/handlers/base.py" in _get_response
178. response = middleware_method(request, callback, callback_args, callback_kwargs)
File "./freenasUI/freeadmin/middleware.py" in process_view
162. return login_required(view_func)(request, *view_args, **view_kwargs)
File "/usr/local/lib/python3.6/site-packages/django/contrib/auth/decorators.py" in _wrapped_view
23. return view_func(request, *args, **kwargs)
File "./freenasUI/storage/views.py" in manualsnap
777. form.commit(fs)
File "./freenasUI/storage/forms.py" in commit
1846. len(snapvms))
File "./freenasUI/middleware/notifier.py" in zfs_mksnap
3303. raise MiddlewareError("Snapshot could not be taken: %s" % err)
Exception Type: MiddlewareError at /storage/snapshot/create/sata-z/movies/
Exception Value: [MiddlewareError: b"Snapshot could not be taken: cannot create snapshot 'sata-z/movies@manual-20170806': dataset already exists\n"]
It is reproductible at will...
Associated revisions
History
#1
Updated by Yves REMY over 3 years ago
- File debug-hive-20170806212046.txz added
#2
Updated by Dru Lavigne over 3 years ago
- Assignee changed from Release Council to William Grzybowski
- Seen in changed from Unspecified to 11.0-U2
#3
Updated by William Grzybowski over 3 years ago
- Status changed from Unscreened to Screened
- Priority changed from No priority to Important
- Target version set to 11.1
#4
Updated by William Grzybowski over 3 years ago
- Status changed from Screened to Ready For Release
- Private changed from Yes to No
#5
Updated by William Grzybowski over 3 years ago
- File deleted (
debug-hive-20170806212046.txz)
#6
Updated by Dru Lavigne over 3 years ago
- Subject changed from Duplicate zfs snapshot GUI crash to Fix traceback when creating snapshot with existing name
#7
Updated by Dru Lavigne over 3 years ago
- Target version changed from 11.1 to 11.1-BETA1
#8
Updated by Bonnie Follweiler over 3 years ago
- Needs QA changed from Yes to No
- QA Status Test Passes FreeNAS added
- QA Status deleted (
Not Tested)
in FreeNAS-11-MASTER-201710120511 It will not allow me to create a duplicate and let's me know that the dataset already exists
#9
Updated by Dru Lavigne over 3 years ago
- Status changed from Ready For Release to Resolved