Project

General

Profile

Bug #26165

Send email when scrub finishes

Added by Caleb St. John about 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
No priority
Assignee:
William Grzybowski
Category:
OS
Target version:
Seen in:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
Yes
Needs Doc:
Yes
Needs Merging:
Yes
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Related projects 1 project

Description

When email alerts are enabled and a scrub begins, we send an email notifying the customer a scrub has started. However, we do not send an email when the scrub has finished.

Can we either.
1. remove the initial email that is sent on scrub start
2. send an email after a scrub has finished


Subtasks

Bug #26181: Need ZFS to send a devd event when scrub/resilver finishesClosed: Behaves correctlyAlexander Motin

Associated revisions

Revision f667a1f8 (diff)
Added by William Grzybowski about 1 year ago

feat(middlewared/pool): send email when scrub finishes

Ticket: #26165

Revision baf655ed (diff)
Added by Dru Lavigne about 1 year ago

Mention email when scrub finishes.
Ticket: #26165

Revision 08947f60 (diff)
Added by William Grzybowski about 1 year ago

fix(middlewared/zfs): sending email when scrub finishes

Ticket: #26165

Revision ac9d8834 (diff)
Added by William Grzybowski about 1 year ago

fix(middlewared/zfs): sending email when scrub finishes

Ticket: #26165
(cherry picked from commit 08947f60d72dd433a621203a73f29977ebf4ad79)

History

#1 Updated by Caleb St. John about 1 year ago

  • Assignee changed from Release Council to Ash Gokhale

#2 Updated by Ash Gokhale about 1 year ago

Seems reasonable following POLA discipline as a customer was expecting it, and was disappointed by it's absence. Would require polling the scrub once started.

#3 Updated by Dru Lavigne about 1 year ago

  • 1 added project (FreeNAS)
  • Status changed from Untriaged to Unscreened
  • Assignee changed from Ash Gokhale to William Grzybowski

#4 Updated by Dru Lavigne about 1 year ago

  • 1 deleted project (FreeNAS)
  • Project changed from TrueNAS to FreeNAS
  • Category changed from OS to OS
  • Private changed from No to Yes

#5 Updated by Ash Gokhale about 1 year ago

  • Priority changed from No priority to Nice to have

#6 Updated by Joshua Sirrine about 1 year ago

Just want to add my 2 cents to this. The scrub emails began because customers complained of poor performance without any email as to why. So instead of removing the scrub initiation emails, I'd recommend we simply add the email at the end that the scrub finished.

#7 Updated by William Grzybowski about 1 year ago

  • Status changed from Unscreened to Screened
  • Target version set to 11.2-BETA1

This is non-trivial because it requires ZFS to send a "scrub ended" event. Creating a subticket to Alexander can take a look.

#8 Updated by Alexander Motin about 1 year ago

All those scrub/resilver events are reported to devd. Just need to be wired.

#9 Updated by William Grzybowski about 1 year ago

My bad, thanks Alexander.

#10 Updated by William Grzybowski about 1 year ago

  • Status changed from Screened to Needs Developer Review
  • Assignee changed from William Grzybowski to Vladimir Vinogradenko
  • Target version changed from 11.2-BETA1 to 11.1-RC1

#11 Updated by Dru Lavigne about 1 year ago

  • Description updated (diff)
  • Private changed from Yes to No

#12 Updated by Dru Lavigne about 1 year ago

  • Subject changed from send email when scrub finishes to Send email when scrub finishes

#13 Updated by Vladimir Vinogradenko about 1 year ago

  • Status changed from Needs Developer Review to Reviewed by Developer
  • Assignee changed from Vladimir Vinogradenko to William Grzybowski

#14 Updated by William Grzybowski about 1 year ago

  • Status changed from Reviewed by Developer to Ready For Release

#15 Updated by Dru Lavigne about 1 year ago

  • Status changed from Ready For Release to Resolved

#16 Updated by Bonnie Follweiler about 1 year ago

  • Status changed from Resolved to Unscreened
  • QA Status Test Fails TrueNAS added
  • QA Status deleted (Not Tested)

The mini sent the "scrub started" email at 11:00 am, the scrub is finished but the system didn't send the "scrub finished" email

#17 Updated by Bonnie Follweiler about 1 year ago

  • QA Status Test Passes FreeNAS added
  • QA Status deleted (Test Fails TrueNAS)

#18 Updated by Bonnie Follweiler about 1 year ago

  • QA Status Test Fails FreeNAS added
  • QA Status deleted (Test Passes FreeNAS)

#19 Updated by William Grzybowski about 1 year ago

  • Status changed from Unscreened to Needs Developer Review
  • Assignee changed from William Grzybowski to Vladimir Vinogradenko
  • Target version changed from 11.1-RC1 to 11.1
  • Seen in changed from 11.0-U2.2 to 11.1-RC1

#20 Updated by Vladimir Vinogradenko about 1 year ago

  • Status changed from Needs Developer Review to Reviewed by Developer
  • Assignee changed from Vladimir Vinogradenko to William Grzybowski

#21 Updated by William Grzybowski about 1 year ago

  • Status changed from Reviewed by Developer to Ready For Release
  • QA Status Not Tested added
  • QA Status deleted (Test Fails FreeNAS)

#22 Updated by Bonnie Follweiler about 1 year ago

  • Needs QA changed from Yes to No
  • QA Status Test Passes FreeNAS added
  • QA Status deleted (Not Tested)

Got this in my email after the scrub finished:
scrub of pool 'lockedvol' finished

#23 Updated by Bonnie Follweiler about 1 year ago

  • Needs QA changed from No to Yes

#24 Updated by Dru Lavigne about 1 year ago

  • Target version changed from 11.1 to 11.1-RC2

#25 Updated by Dru Lavigne about 1 year ago

  • Target version changed from 11.1-RC2 to 11.1-RC3

#26 Updated by Dru Lavigne about 1 year ago

  • Status changed from Ready For Release to Resolved

Also available in: Atom PDF