Project

General

Profile

Bug #26344

Preserve leading space in MOTD banner field

Added by Chris Heerschap about 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Nice to have
Assignee:
William Grzybowski
Category:
GUI (new)
Target version:
Seen in:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
Yes
Needs Merging:
Yes
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:

Various

ChangeLog Required:
No

Description

Related to https://bugs.freenas.org/issues/26097 - If the entry in the MOTD Banner field in System/Advanced has leading spaces on the first line, those spaces are discarded when the entry is saved.

Example:

Entering this into the MOTD Banner field:

           _   _    _    ____
          | \ | |  / \  / ___|
          |  \| | / _ \ \___ \
          | |\  |/ ___ \ ___) |
          |_| \_/_/   \_\____/

submits okay in the System Advanced tab, but switching to another tab and back has the MOTD Banner field rendered without the leading space in the first line only:

_   _    _    ____
          | \ | |  / \  / ___|
          |  \| | / _ \ \___ \
          | |\  |/ ___ \ ___) |
          |_| \_/_/   \_\____/

An easy workaround is to replace the first space with any character, then subsequent spacing is preserved.

Confirmed in the old UI as well as the new.

26097 was related to omitted quotes, and I'm guessing this is as well.

Associated revisions

Revision 14e0dd6f (diff)
Added by William Grzybowski about 1 year ago

fix(gui): do not strip motd field

Ticket: #26344

History

#1 Updated by Dru Lavigne about 1 year ago

  • Assignee changed from Release Council to William Grzybowski

#2 Updated by William Grzybowski about 1 year ago

  • Status changed from Unscreened to Needs Developer Review
  • Assignee changed from William Grzybowski to Vladimir Vinogradenko
  • Priority changed from No priority to Nice to have
  • Target version set to 11.1

#3 Updated by Vladimir Vinogradenko about 1 year ago

  • Status changed from Needs Developer Review to Reviewed by Developer
  • Assignee changed from Vladimir Vinogradenko to William Grzybowski

#4 Updated by William Grzybowski about 1 year ago

  • Status changed from Reviewed by Developer to Ready For Release
  • Target version changed from 11.1 to 11.1-RC1

#5 Updated by Dru Lavigne about 1 year ago

  • Subject changed from MOTD Banner field does not preserve leading space to Preserve leading space in MOTD banner field

#6 Updated by Dru Lavigne about 1 year ago

  • Status changed from Ready For Release to Resolved

#7 Updated by Nick Wolff about 1 year ago

  • QA Status Test Passes FreeNAS added
  • QA Status deleted (Not Tested)

#8 Updated by Bonnie Follweiler about 1 year ago

  • Needs QA changed from Yes to No

Also available in: Atom PDF