Project

General

Profile

Bug #26594

Only show detach button when the boot pool is mirrored

Added by Bonnie Follweiler almost 2 years ago. Updated over 1 year ago.

Status:
Done
Priority:
Nice to have
Assignee:
Waqar Ahmed
Category:
Middleware
Target version:
Seen in:
Severity:
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Although the outcome is what we desire - not detaching the only boot device, when I tried it I got a Traceback error rather than an error message.

Request Method: POST
Request URL: http://10.231.1.76/system/bootenv/pool/detach/ada2p2/
Software Version: FreeNAS-11.1-RC1 (ff06285bd)
Exception Type: ClientException
Exception Value:

[EUNKNOWN] Can detach disks from mirrors and spares only

Exception Location: /usr/local/lib/python3.6/site-packages/middlewared/client/client.py in call, line 394
Server time: Fri, 10 Nov 2017 07:37:11 -0800

Traceback
Environment:

Software Version: FreeNAS-11.1-RC1 (ff06285bd)
Request Method: POST
Request URL: http://10.231.1.76/system/bootenv/pool/detach/ada2p2/

Traceback:
File "/usr/local/lib/python3.6/site-packages/django/core/handlers/exception.py" in inner
42. response = get_response(request)
File "/usr/local/lib/python3.6/site-packages/django/core/handlers/base.py" in _legacy_get_response
249. response = self._get_response(request)
File "/usr/local/lib/python3.6/site-packages/django/core/handlers/base.py" in _get_response
178. response = middleware_method(request, callback, callback_args, callback_kwargs)
File "./freenasUI/freeadmin/middleware.py" in process_view
162. return login_required(view_func)(request, *view_args, **view_kwargs)
File "/usr/local/lib/python3.6/site-packages/django/contrib/auth/decorators.py" in _wrapped_view
23. return view_func(request, *args, **kwargs)
File "./freenasUI/system/views.py" in bootenv_pool_detach
497. c.call('boot.detach', label)
File "./freenasUI/system/views.py" in bootenv_pool_detach
497. c.call('boot.detach', label)
File "/usr/local/lib/python3.6/site-packages/middlewared/client/client.py" in call
394. raise ClientException(c.error, c.errno, c.trace, c.extra)

Exception Type: ClientException at /system/bootenv/pool/detach/ada2p2/
Exception Value: [EUNKNOWN] Can detach disks from mirrors and spares only

Request information
GET

No GET data
POST
Variable Value
__form_id 'form_str'
FILES

No FILES data
COOKIES
Variable Value
csrftoken 'clFzU96Kb3DtsS2NpD0MxYK5X33Hyk4NF8vNdi5mbtJuYYtF0gfCLO1EcG3AVdhQ'
fntreeSaveStateCookie 'root%2Croot%2F1%2Croot%2F1%2F5%2Croot%2F1%2F6%2Croot%2F66%2Croot%2F12%2Croot%2F1%2F8%2Croot%2F69%2Croot%2F1%2F7%2Croot%2F137%2Croot%2F167'
sessionid 'osezzl6x3n1sjwokxw1tvp3j9uoke61i'
META
Variable Value


Related issues

Copied to FreeNAS - Bug #29229: Only show detach button when the boot pool is mirroredDone
Copied to FreeNAS - Bug #32406: Only show detach button when the boot pool is mirroredDone

History

#1 Updated by William Grzybowski almost 2 years ago

  • Status changed from Unscreened to Screened
  • Priority changed from No priority to Nice to have
  • Target version set to 11.3

#2 Avatar?id=14398&size=24x24 Updated by Kris Moore over 1 year ago

  • Status changed from Screened to Not Started

#3 Updated by William Grzybowski over 1 year ago

  • Assignee changed from William Grzybowski to Waqar Ahmed
  • Target version changed from 11.3 to 11.2-RC2

Waqar, this might be a bit more complicated but a low hanging fruit, a good learning exercise. The Detach button should not show when boot device is not a mirror.

Let me know if you have questions.

#4 Updated by Waqar Ahmed over 1 year ago

  • Status changed from Not Started to In Progress
  • % Done changed from 0 to 90

#5 Updated by Waqar Ahmed over 1 year ago

  • Status changed from In Progress to Done
  • % Done changed from 90 to 100

#6 Updated by Dru Lavigne over 1 year ago

  • Subject changed from Get a Traceback message when trying to detatch a non mirrored boot device to Only show detach button when the boot pool is mirrored
  • Target version changed from 11.2-RC2 to 11.2-BETA1
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#7 Updated by Dru Lavigne over 1 year ago

Bonnie: can you please make a note that this needs to be tested in both the old UI and new UI.

#8 Updated by Warren Block over 1 year ago

  • Copied to Bug #29229: Only show detach button when the boot pool is mirrored added

#9 Updated by Bonnie Follweiler over 1 year ago

16698
16701
16704

In FreeNAS-11-MASTER-201804170410
In the new GUI the Detach Pool option is still there (screenshot provided)
In the old UI you can only Edit
In the boot you can replace (screenshots provided)

#10 Updated by Dru Lavigne over 1 year ago

  • Status changed from Unscreened to Failed Testing

#11 Updated by Dru Lavigne over 1 year ago

  • Copied to Bug #32406: Only show detach button when the boot pool is mirrored added

#12 Updated by Dru Lavigne over 1 year ago

  • Status changed from Failed Testing to Done
  • QA Status Test Passes FreeNAS added
  • QA Status deleted (Test Fails FreeNAS)

#13 Updated by William Grzybowski over 1 year ago

  • Category changed from GUI (new) to Middleware

Also available in: Atom PDF