FreeNAS

Checking into this further it appears that 9.10U1 did not include zfs_space & zfsacl VFS objects in the drop-down menu as they are "always enabled." However 11.0 has added them to the menu and was removed from the note as an "Always enabled" object under table 10.4.2 in the User Guide under Sharing > SMB.

Yes. Adding zfsacl resolved the issue. I took it a bit further and matched my existing shares to a newly created share and added:

zfs_space
zfsacl
streams_xattr
aio_pthread

Dru Lavigne wrote:

John: should there be a migration for this?

There is a migration for this already. I'm not sure what went wrong here, but it seems as though the migration (and perhaps others) did not run. Can you see if /data/update.failed exists?

/data/update.failed does not exist. I am going to attempt an upgrade again either tonight or tomorrow night and pull the debugs again.

When reading AD and ldap dumps I noticed that a few of the shares had zfs_space zfsacl on them. These shares were the ones that allowed me to open them but they did not allow me to edit the ACL's. After I went through and applied zfs_space zfsacl to them I verified all shares showed ACL's and allowed me to edit. I'm curious why if zfs_space zfsacl was indeed listed on the shares why it did not 'register' until after re-applying them.

When I go through it again I'm hoping to have a better understanding of this. While I'm doing this is there anything you all would like me to look for?

Sure thing. Here is the output both commands generated on 9.10.2-U1

[root@galaxy] ~# sqlite3 /data/freenas-v1.db "select * from sharing_cifs_share" 
/mnt/vol1/documents|1||documents|0|1|0||0|||0||0|0|1|1
/mnt/vol1/backups|1||backups|0|2|0||0|||0||0|0|2|1
/mnt/vol1/media|1||media|0|3|0||0|||0||0|0|3|1
/mnt/vol1/vhd|1||vhd|0|7|0||0|||0||0|0|4|1
/mnt/vol1/backups/lauri|1||lauri|0|2|0||0|||0||0|0|5|1
/mnt/vol1/userdata|1||userdata|0|8|0||0||windows ad datastore|0|aio_pthread,streams_xattr|1|0|6|1
/mnt/vol1/software|1||software|0||0||0|||0|aio_pthread,streams_xattr|0|0|7|1
/mnt/vol1/pictures|1||pictures|0||0||0|||0|aio_pthread,streams_xattr|0|0|8|1

[root@galaxy] ~# sqlite3 /data/freenas-v1.db ".dump sharing_cifs_share" 
PRAGMA foreign_keys=OFF;
BEGIN TRANSACTION;
CREATE TABLE "sharing_cifs_share" ("cifs_path" varchar(255), "cifs_default_permissions" bool NOT NULL, "cifs_hostsallow" text NOT NULL, "cifs_name" varchar(120) NOT NULL, "cifs_guestok" bool NOT NULL, "cifs_storage_task_id" integer NULL, "cifs_showhiddenfiles" bool NOT NULL, "cifs_hostsdeny" text NOT NULL, "cifs_ro" bool NOT NULL, "cifs_auxsmbconf" text NOT NULL, "cifs_comment" varchar(120) NOT NULL, "cifs_home" bool NOT NULL, "cifs_vfsobjects" varchar(255) NOT NULL, "cifs_recyclebin" bool NOT NULL, "cifs_guestonly" bool NOT NULL, "id" integer PRIMARY KEY, "cifs_browsable" bool NOT NULL);
INSERT INTO "sharing_cifs_share" VALUES('/mnt/vol1/documents',1,'','documents',0,1,0,'',0,'','',0,'',0,0,1,1);
INSERT INTO "sharing_cifs_share" VALUES('/mnt/vol1/backups',1,'','backups',0,2,0,'',0,'','',0,'',0,0,2,1);
INSERT INTO "sharing_cifs_share" VALUES('/mnt/vol1/media',1,'','media',0,3,0,'',0,'','',0,'',0,0,3,1);
INSERT INTO "sharing_cifs_share" VALUES('/mnt/vol1/vhd',1,'','vhd',0,7,0,'',0,'','',0,'',0,0,4,1);
INSERT INTO "sharing_cifs_share" VALUES('/mnt/vol1/backups/lauri',1,'','lauri',0,2,0,'',0,'','',0,'',0,0,5,1);
INSERT INTO "sharing_cifs_share" VALUES('/mnt/vol1/userdata',1,'','userdata',0,8,0,'',0,'','windows ad datastore',0,'aio_pthread,streams_xattr',1,0,6,1);
INSERT INTO "sharing_cifs_share" VALUES('/mnt/vol1/software',1,'','software',0,NULL,0,'',0,'','',0,'aio_pthread,streams_xattr',0,0,7,1);
INSERT INTO "sharing_cifs_share" VALUES('/mnt/vol1/pictures',1,'','pictures',0,NULL,0,'',0,'','',0,'aio_pthread,streams_xattr',0,0,8,1);
COMMIT;

Great, thanks a lot!

/mnt/vol1/documents|1||documents|0|1|0||0|||0||0|0|1|1
/mnt/vol1/backups|1||backups|0|2|0||0|||0||0|0|2|1
/mnt/vol1/media|1||media|0|3|0||0|||0||0|0|3|1
/mnt/vol1/vhd|1||vhd|0|7|0||0|||0||0|0|4|1
/mnt/vol1/backups/lauri|1||lauri|0|2|0||0|||0||0|0|5|1
/mnt/vol1/userdata|1||userdata|0|8|0||0||windows ad datastore|0|aio_pthread,streams_xattr|1|0|6|1
/mnt/vol1/software|1||software|0||0||0|||0|aio_pthread,streams_xattr|0|0|7|1
/mnt/vol1/pictures|1||pictures|0||0||0|||0|aio_pthread,streams_xattr|0|0|8|1

I think that nails it. Shares, which didn't have anything in the vfs_objects field were not upgraded to get zfsacl module.

Thanks a lot, again, for the provided information, that helped us to locate the problem.

At this point, I guess, it's OK to close the ticket?

Just to clarify would this be considered expected behavior?

I would define it as a bug in the migration process, so it's going to be fixed in 11.1-U1.

Got it thanks. Just to add to this - in the 9.10.2-U1 dump I pulled. Under CIFS it shows zfsacl and zfs_space for vfs objects

Example¶

[backups]
    path = /mnt/vol1/backups
    printable = no
    veto files = /.snapshot/.windows/.mac/.zfs/
    writeable = yes
    browseable = yes
    shadow:snapdir = .zfs/snapshot
    shadow:sort = desc
    shadow:localtime = yes
    shadow:format = auto-%Y%m%d.%H%M-1d
    shadow:snapdirseverywhere = yes
    vfs objects = shadow_copy2 zfs_space zfsacl
    hide dot files = yes
    guest ok = no
    nfs4:mode = special
    nfs4:acedup = merge
    nfs4:chown = true
    zfsacl:acesort = dontcare

Master:
https://github.com/freenas/freenas/pull/827

11.1-stable
https://github.com/freenas/freenas/pull/828

11.0-stable
https://github.com/freenas/freenas/pull/829

truenas-11.0-stable
https://github.com/freenas/freenas/pull/830