Project

General

Profile

Bug #27271

Prevent generating some /etc files from temporarily blocking middlewared

Added by William Grzybowski over 1 year ago. Updated 10 months ago.

Status:
Done
Priority:
Important
Assignee:
William Grzybowski
Category:
Middleware
Target version:
Seen in:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

[2017/12/14 01:17:32] (WARNING) middlewared._loop_monitor_thread():984 - Task seems blocked:  File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 863, in _call
    return await methodobj(*args)
  File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 109, in __next__
    return self.gen.send(None)
  File "/usr/local/lib/python3.6/site-packages/middlewared/plugins/etc.py", line 141, in generate_all
    await self.generate(name)
  File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 109, in __next__
    return self.gen.send(None)
  File "/usr/local/lib/python3.6/site-packages/middlewared/plugins/etc.py", line 112, in generate
    rendered = await renderer.render(path)
  File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 109, in __next__
    return self.gen.send(None)
  File "/usr/local/lib/python3.6/site-packages/middlewared/plugins/etc.py", line 18, in render
    tmpl = Template(filename=path)
  File "/usr/local/lib/python3.6/site-packages/mako/template.py", line 338, in __init__
    module = self._compile_from_file(path, filename)
  File "/usr/local/lib/python3.6/site-packages/mako/template.py", line 412, in _compile_from_file
    data = util.read_file(filename)
  File "/usr/local/lib/python3.6/site-packages/mako/util.py", line 367, in read_file
    data = fp.read()

Associated revisions

Revision d2f6f6fe (diff)
Added by William Grzybowski over 1 year ago

fix(middlewared/etc): run all mako code within a thread

While I'm here replace middleware client with local middleware
`call_sync` calls.

Ticket: #27271

Revision ad70603a (diff)
Added by William Grzybowski over 1 year ago

fix(middlewared/etc): run all mako code within a thread

While I'm here replace middleware client with local middleware
`call_sync` calls.

Ticket: #27271

History

#1 Updated by William Grzybowski over 1 year ago

  • Status changed from Screened to Needs Developer Review
  • Assignee changed from William Grzybowski to Bartosz Prokop

#2 Updated by Bartosz Prokop over 1 year ago

  • Status changed from Needs Developer Review to Reviewed by Developer
  • Assignee changed from Bartosz Prokop to William Grzybowski

#3 Updated by William Grzybowski over 1 year ago

  • Status changed from Reviewed by Developer to Ready For Release

#4 Updated by Dru Lavigne about 1 year ago

  • Subject changed from Generating some /etc files may temporarily block middlewared to Prevent generating some /etc files from temporarily blocking middlewared
  • Status changed from Ready For Release to Done
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#5 Updated by Dru Lavigne 12 months ago

  • Status changed from Done to Ready for Testing

#6 Updated by William Grzybowski 10 months ago

  • Severity set to New
  • Needs QA changed from Yes to No

#7 Updated by Dru Lavigne 10 months ago

  • Status changed from Ready for Testing to Done

Also available in: Atom PDF