Set the default setting for the SMB -> Sharing -> SMB -> Apply Default Permissions checkbox to checked
As per ticket 26964 we want this setting to always be false except for when the user checks the box and saves. I have done the UI side of this in a PR but there may be some value in having the middleware set the db value to 0 as well so I am making a ticket for this
#7 Updated by John Hixson over 2 years ago
Timur Bakeyev wrote:
https://github.com/freenas/freenas/pull/1108 for the master
I have some issues with this ticket. We need to do 2 things here:
1. On new shares, we need to set the permissions the way they currently get set (which this button does).
2. Many users need the ability the reset permissions at all.
I don't have a problem with removing the button, but we need (1) to happen when a new share is created without users having to do any extra work. (2) should be available in this dialog somewhere, but I leave that to the UI experts.
#8 Updated by Timur Bakeyev over 2 years ago
If I understand you correctly (2) comes out of the box with this PR. Whenever you check
Default permissions they'll be reset with
The (1) I missed. Well, original ticket also :) So, I guess, we need to distinct
edit share actions and for the first one automatically pre-check the
Default permissions checkbox.
Does this sound right?
#10 Updated by John Hixson over 2 years ago
Timur Bakeyev wrote:
To clarify, I didn't remove the button, I moved it from the
forms, so it's not persistent anymore. Checking it would initiate reset permissions action, but that won't be kept in the config DB - it's an immediate action.
I apologize for the misinterpretation. Andrew & myself figured out what was going on here after a lengthy discussion ;-) So it sounds like everything is working as it should, provided (1) and (2) are met.
#14 Updated by Bonnie Follweiler over 2 years ago
- File Screen Shot 2018-05-04 at 11.15.54 AM.png Screen Shot 2018-05-04 at 11.15.54 AM.png added
- File Screen Shot 2018-05-04 at 11.16.10 AM.png Screen Shot 2018-05-04 at 11.16.10 AM.png added
- Status changed from Ready for Testing to Failed Testing
- Severity set to New
I created a brand new VM using the latest FreeNAS Nightlies (FreeNAS-11.2-MASTER-201805040904)
In the old UI:
If you create an SMB share in the Wizard the Default Permissions is unchecked
If you go to Sharing -> Windows (SMB) -> Add Windows (SMB) Share the Default Permissions box is checked
In the new UI it is unchecked by default
#15 Updated by Bonnie Follweiler over 2 years ago
After a conversation with Timur i have learned that, the Wizard in the old UI is not handling the "Default Permissions" correctly. Also the new GUI is not correct when creating an SMB share. I will create a ticket for the new GUI and assign it to Erin