Project

General

Profile

Bug #27892

I can promote all datasets

Added by Ice BoosteR over 2 years ago. Updated over 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
Erin Clark
Category:
GUI (new)
Seen in:
Severity:
Reason for Closing:
Reason for Blocked:
Needs QA:
Yes
Needs Doc:
Yes
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Hi,
as in the documentation:
Promote Dataset: only applies to clones. When a clone is promoted, the origin filesystem becomes a clone of the clone making it possible to destroy the filesystem that the clone was created from. Otherwise, a clone can not be destroyed while its origin filesystem exists.

This does not apply to 11.1-U1
I can promote whatever dataset I want and have afterwards the possiblity to pormote it again. This datasets are fresh, and not cloned.

promote.png (57.4 KB) promote.png Ice BoosteR, 01/20/2018 05:24 PM
14005

Subtasks

Feature #28876: Add API to promote datasetsDoneWilliam Grzybowski
Bug #31053: Make dataset promotion workDoneErin Clark

Related issues

Related to FreeNAS - Feature #28858: Volume Page - Total Feature Set Parent.Done2018-03-05
Related to FreeNAS - Bug #31050: Do not spawn another thread on call_sync middleware callDone

Associated revisions

Revision 1787e88e (diff)
Added by Erin Clark over 2 years ago

Use websocket call for dataset promotion Ticket: #31050 #27892

Revision 2ace1e9e (diff)
Added by Erin Clark over 2 years ago

Try to detect dataset type to see if it should be promotable (WIP) Ticket: #27892

Revision bcab0957 (diff)
Added by Erin Clark over 2 years ago

Snapshot clone shouldn't by default clone the snapshot into its origin (adding a - instead of a / is how the old ui generates the clone name) Ticket: #27892

Revision 9fef52eb (diff)
Added by Erin Clark over 2 years ago

Only allow promoting of clone datasets Ticket: #27892

History

#1 Updated by Dru Lavigne over 2 years ago

  • Assignee changed from Release Council to Erin Clark
  • Target version set to 11.2-BETA1

Erin: something to correct for the new UI.

#2 Updated by Erin Clark over 2 years ago

  • Category changed from 129 to GUI (new)
  • Assignee changed from Erin Clark to Peter Southwell
  • Priority changed from No priority to Expected

Would you like to fix this while you are working on the dashboard options Pete? Promote should be hidden if the dataset is not a clone

#3 Updated by Dru Lavigne over 2 years ago

  • Status changed from Unscreened to Not Started

#4 Updated by Peter Southwell over 2 years ago

  • Status changed from Not Started to In Progress

#5 Avatar?id=13649&size=24x24 Updated by Ben Gadd over 2 years ago

  • Due date set to 03/09/2018

#6 Updated by Peter Southwell over 2 years ago

  • Related to Feature #28858: Volume Page - Total Feature Set Parent. added

#7 Updated by Peter Southwell over 2 years ago

There is also no clone Im seeing.. In the new UI!!!

#8 Updated by Peter Southwell over 2 years ago

  • Status changed from In Progress to Blocked

I have all the code in place.. Just need the url now.. All the dialogs come up.

Because it's the wrong url.. Instead of promoting the dataset we get the error.. When the url is correct it'll promote just fine and that's just a simple string chagne.

So this is done... once the api gets baked.

#9 Updated by Peter Southwell over 2 years ago

  • Status changed from Blocked to In Progress

#10 Updated by Peter Southwell over 2 years ago

  • Status changed from In Progress to Blocked

#11 Updated by Peter Southwell over 2 years ago

There is a stub present in the UI now.. that calls the API.. and shows error for the moment.. Whilest it bakes on back end :)

#12 Updated by Erin Clark over 2 years ago

  • Status changed from Blocked to Not Started

This ticket is no longer blocked, could you please try to fix this before code freeze?

#13 Updated by Peter Southwell over 2 years ago

  • Assignee changed from Peter Southwell to Erin Clark

looks like this is enforced at the middlewier level.

#14 Updated by Erin Clark over 2 years ago

  • Blocked by Bug #31050: Do not spawn another thread on call_sync middleware call added

#15 Updated by Erin Clark over 2 years ago

  • Blocked by deleted (Bug #31050: Do not spawn another thread on call_sync middleware call)

#16 Updated by Erin Clark over 2 years ago

  • Related to Bug #31050: Do not spawn another thread on call_sync middleware call added

#17 Updated by Erin Clark over 2 years ago

  • Target version changed from 11.2-BETA1 to 11.2-RC2

I have fixed dataset promotion to work in the new UI in this ticket https://redmine.ixsystems.com/issues/31053. Since I am having difficulty with pool.dataset.query for the time being and since the middleware keeps dataset promotion from happening to non-promotable datasets I will work on getting this done by 11.2.

#18 Updated by Erin Clark over 2 years ago

  • Status changed from Not Started to In Progress

#19 Updated by Erin Clark over 2 years ago

  • Status changed from In Progress to Done

#20 Updated by Dru Lavigne over 2 years ago

  • Target version changed from 11.2-RC2 to Master - FreeNAS Nightlies
  • Needs Merging changed from Yes to No

Also available in: Atom PDF