Project

General

Profile

Feature #28215

Avatar?id=14398&size=50x50

Allow force deletion of datasets in middleware and alert If busy

Added by Kris Moore over 1 year ago. Updated 7 months ago.

Status:
Done
Priority:
Nice to have
Assignee:
William Grzybowski
Category:
Middleware
Target version:
Estimated time:
Severity:
Low Medium
Reason for Closing:
Reason for Blocked:
Needs QA:
Yes
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:

Description

As mentioned by John Sanderson, it would be nice to have the middleware properly detect if we cannot delete a clone or dataset if its busy, and then provide an option to "force". Example being when somebody left a SSH session open with their shell still sitting on the cloned dataset mountpoint. They had no idea it was still running but then the UI couldn't unmount and remove the clone properly.


Related issues

Has duplicate FreeNAS - Feature #53039: Allow force deletion of datasets through v1 and v2 APIClosed
Copied to FreeNAS - Feature #59496: Detect Busy Clones / Datasets and promptClosed

Associated revisions

Revision a7bdafe0 (diff)
Added by William Grzybowski 11 months ago

feat(middlewared/pool): allow to force deletion of datasets If umounting a dataset fails EBUSY error will be raised. Ticket: #28215

Revision d95e4f04 (diff)
Added by William Grzybowski 11 months ago

feat(middlewared/pool): allow to force deletion of datasets If umounting a dataset fails EBUSY error will be raised. Ticket: #28215

Revision e1e1c903 (diff)
Added by William Grzybowski 9 months ago

feat(middlewared/pool): allow to force deletion of datasets If umounting a dataset fails EBUSY error will be raised. Ticket: #28215 (cherry picked from commit d95e4f04eb9131b61cf2e7cb291ef6313aad9805)

History

#1 Updated by Alexander Motin over 1 year ago

I suppose the original problem was in just missing error reporting. Having busy status reported could make behavior more user-friendly, and it would be a reasonable minimum to expect.

What's about further improvements, I guess we could parse fstat output to find processes having files open, but not sure how informative it can be for average end user. Also not sure how full is that information, since it seems at least ZVOLs files opened by kernel are not reported there.

One more related issue is that IIRC forceful destruction for ZVOLs is not working at this point due to the way they are implemented on FreeBSD. It would be nice to have, but would require non-trivial changes.

#2 Avatar?id=13649&size=24x24 Updated by Ben Gadd over 1 year ago

  • Target version changed from 11.3 to Backlog

#3 Updated by Bug Clerk 11 months ago

  • Status changed from Not Started to In Progress

#4 Updated by William Grzybowski 11 months ago

  • Copied to Feature #59496: Detect Busy Clones / Datasets and prompt added

#5 Updated by Bug Clerk 11 months ago

  • Status changed from In Progress to Ready for Testing

#6 Updated by Bug Clerk 11 months ago

  • Target version changed from Backlog to 11.3

#7 Updated by William Grzybowski 11 months ago

  • Has duplicate Feature #53039: Allow force deletion of datasets through v1 and v2 API added

#8 Updated by Dru Lavigne 10 months ago

  • Subject changed from Detect Busy Clones / Datasets and prompt to Allow force deletion of datasets in middleware and alert If busy
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#9 Updated by Dru Lavigne 9 months ago

  • Target version changed from 11.3 to 11.3-BETA1

#10 Updated by Dru Lavigne 9 months ago

  • Status changed from Ready for Testing to Done

#12 Updated by Dru Lavigne 7 months ago

  • Target version changed from 11.3-BETA1 to 11.3-ALPHA1

Also available in: Atom PDF