Project

General

Profile

Bug #28247

Set the default value of scrub delay to 4 and resilver delay to 2

Added by Warren Block almost 3 years ago. Updated almost 3 years ago.

Status:
Done
Priority:
Important
Assignee:
Sean Fagan
Category:
OS
Target version:
11.1-U2
Seen in:
11.1-U1
Severity:
Med High
Reason for Closing:
Reason for Blocked:
Needs QA:
Yes
Needs Doc:
Yes
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

With the addition of the sequential scrub/resilver code, vfs.zfs.scrub_delay and vfs.zfs.resilver_delay default to zero. Normally, these default to a scrub delay of 4 and a resilver delay of 2. These delays effectively limit the maximum IOPS that can be used by a scrub or resilver, leaving some capacity available for normal use of the system.

The standard defaults of 4 for scrub and 2 for resilver should be restored.

For more information: https://www.freebsd.org/doc/handbook/zfs-advanced.html#zfs-advanced-tuning

History

#1 Updated by Sean Fagan almost 3 years ago

  • Status changed from Not Started to In Progress

#2 Avatar?id=14398&size=24x24 Updated by Kris Moore almost 3 years ago

  • Status changed from In Progress to Done
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

Merged!

#3 Updated by Dru Lavigne almost 3 years ago

  • Status changed from Done to In Progress

Sean: what is the PR for the commit to master?

#4 Updated by Dru Lavigne almost 3 years ago

  • Subject changed from Scrub delay and resilver delay default to zero to Set the default value of scrub delay to 4 and resilver delay to 2
  • Needs Doc changed from No to Yes

#5 Updated by Sean Fagan almost 3 years ago

  • Status changed from In Progress to Blocked

This needs review, and the PR needs to be merged in.

#6 Updated by Alexander Motin almost 3 years ago

This is indeed not merged to 11.1-stable. Do you have any suspicions about it?

#7 Updated by Sean Fagan almost 3 years ago

No, it's a trivial change, but it still affect behaviuor and should be reviewed and QA'd.

#8 Updated by Alexander Motin almost 3 years ago

QA'd -- sure. What's for review, I don't see a pull request, otherwise I'd say it looks good to me.

#9 Updated by Sean Fagan almost 3 years ago

  • Status changed from Blocked to In Progress

Ah, no PR for 11-master. Let me fix that tomorrow or tonight.

#10 Avatar?id=14398&size=24x24 Updated by Kris Moore almost 3 years ago

  • Status changed from In Progress to Done

Did the PR back into freenas/11.1-stable and cherry-pick into freenas/master for you :)

https://github.com/freenas/os/pull/88

Also available in: Atom PDF