Project

General

Profile

Bug #28438

iocage jail bpf setting fails

Added by A B over 3 years ago. Updated over 3 years ago.

Status:
Done
Priority:
No priority
Assignee:
Lola Yang
Category:
GUI (new)
Severity:
Reason for Closing:
Not Applicable
Reason for Blocked:
Needs QA:
Yes
Needs Doc:
Yes
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Edit a iocage jail and try to unselect and select bpf under Custom properties:

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 150, in call_method
    result = await self.middleware.call_method(self, message)
  File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 128, in throw
    return self.gen.throw(type, value, traceback)
  File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 904, in call_method
    return await self._call(message['method'], serviceobj, methodobj, params, app=app)
  File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 128, in throw
    return self.gen.throw(type, value, traceback)
  File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 882, in _call
    return await self.run_in_thread(methodobj, *args)
  File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 128, in throw
    return self.gen.throw(type, value, traceback)
  File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 845, in run_in_thread
    return await self.run_in_thread_pool(self.__threadpool, method, *args, **kwargs)
  File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 128, in throw
    return self.gen.throw(type, value, traceback)
  File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 841, in run_in_thread_pool
    await task
  File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/lib/python3.6/site-packages/middlewared/schema.py", line 506, in nf
    return f(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/middlewared/plugins/jail.py", line 127, in do_update
    iocage.set(p, plugin)
  File "/usr/local/lib/python3.6/site-packages/iocage/lib/iocage.py", line 1421, in set
    iocjson.json_set_value(prop)
  File "/usr/local/lib/python3.6/site-packages/iocage/lib/ioc_json.py", line 734, in json_set_value
    value, conf = self.json_check_prop(key, value, conf)
  File "/usr/local/lib/python3.6/site-packages/iocage/lib/ioc_json.py", line 1237, in json_check_prop
    silent=self.silent)
  File "/usr/local/lib/python3.6/site-packages/iocage/lib/ioc_common.py", line 81, in logit
    _callback({"level": level, "message": msg}, exit_on_error)
  File "/usr/local/lib/python3.6/site-packages/iocage/lib/ioc_common.py", line 60, in callback
    raise RuntimeError(message)
RuntimeError: True is not a valid value for bpf.
Value must be no or yes__

Version:
FreeNAS-11-MASTER-201802120712

History

#1 Updated by Dru Lavigne over 3 years ago

  • Category set to GUI (new)
  • Assignee changed from Release Council to Anonymous
  • Target version set to 11.2-BETA1

#2 Updated by Anonymous over 3 years ago

  • Assignee changed from Anonymous to Brandon Schneider

looking at the traceback it would seem that the middleware call is expecting yes or no but we are trying to pass True or False in. Brandon is there any reason that this call couldn't take True or False instead of yes or no?

#3 Updated by Brandon Schneider over 3 years ago

Erin: This is passing the variables straight through to the API of iocage. I alerted Lola to this issue a week or so ago, not sure if she fixed it yet.

#4 Updated by Anonymous over 3 years ago

  • Assignee changed from Brandon Schneider to Anonymous

Ah I see there is some code to control this in master but maybe it may need some testing, does this still happen in the latest nightly? I will investigate this too

#5 Updated by A B over 3 years ago

Erin Clark wrote:

Ah I see there is some code to control this in master but maybe it may need some testing, does this still happen in the latest nightly? I will investigate this too

I'm sorry. I'm currently using the latest stable again because I don't have a testing enviroment. Can't help you at the moment for testing.

#6 Updated by Anonymous over 3 years ago

  • Assignee changed from Anonymous to Xin Tan

#7 Avatar?id=13649&size=24x24 Updated by Ben Gadd over 3 years ago

  • Due date set to 03/09/2018

#8 Updated by Xin Tan over 3 years ago

  • Assignee changed from Xin Tan to Lola Yang

Giving ticket back to Lola because she's more familiar with Jails

#9 Updated by Lola Yang over 3 years ago

  • Status changed from Not Started to Closed

Already fixed it. Please try the latest nightly. Thanks.

#10 Updated by Dru Lavigne over 3 years ago

  • Target version changed from 11.2-BETA1 to N/A
  • Reason for Closing set to Not Applicable

#11 Updated by Lola Yang over 3 years ago

  • Status changed from Closed to In Progress
  • Assignee changed from Lola Yang to Anonymous
  • Target version changed from N/A to 11.2-BETA1

#12 Updated by Lola Yang over 3 years ago

Lola Yang wrote:

Already fixed it. Please try the latest nightly. Thanks.

I am sorry. I fixed this bug in jail add component about one month ago but forgot the jail edit component. The PR #434 will fix it. Thanks.

#13 Updated by Anonymous over 3 years ago

  • Status changed from In Progress to Done

#14 Updated by Anonymous over 3 years ago

  • Assignee changed from Anonymous to Lola Yang

#15 Updated by Dru Lavigne over 3 years ago

  • Target version changed from 11.2-BETA1 to Master - FreeNAS Nightlies
  • Needs Merging changed from Yes to No

Also available in: Atom PDF