Inconsistent Casing of Labels in the new UI
I have been developing automation test scripts for the new FreeNAS Web-UI in which I am using the Labels for a few elements since for those elements IDs have not been assigned (which is ok, since I have figured a way to locate an element with labels).
Since I am using the label for element location, selenium web driver searches for the label specified in the script. I have been observing multiple changes in the label names with every nightly which is breaking the tests completely...I will list a few examples:
1. The Edit option when clicking on action button in the user list changed ("Edit" to "EDIT" and now back to "Edit") but the Delete remains the same-" Delete"
2. The "OK" has been changed to "Ok" in the user delete confirmation box...
It would be very much appreciated if a certain standard is set for the elements(some naming convention) so that everyone follows that, and there is consistency with the labels...
It takes a lot of time to diagnose and correct an error in the script for miniature change like "OK" to "Ok", to see that it has again been renamed to the original form...which I don't mind doing but it seems redundant and that time can be used at other places!
Pete has added IDs for unique elements which has made my life much easier than before, but not all elements have IDs(which is ok) that is why I really think some naming convention for the Labels would be very helpful to avoid chaos in the long run...
#2 Updated by Erin Clark over 2 years ago
- Assignee changed from Erin Clark to Xin Tan
From here on out action labels will be capital followed by lowercase (i.e. Edit, Delete, Ok, so on) but message keys will still be NAMESPACE.ALL_CAPS. This should make it easier to translate buttons and menu items since the key will be the English phrase (unless it has a space in it, in which case it will need to be formatted differently). See https://github.com/freenas/webui/pull/424