Project

General

Profile

Bug #28982

Temporary fix to silence "@job(pipe=True) leaking file descriptors" messages

Added by Vladimir Vinogradenko over 1 year ago. Updated over 1 year ago.

Status:
Done
Priority:
Critical
Assignee:
Vladimir Vinogradenko
Category:
Middleware
Target version:
Seen in:
TrueNAS - Nightlies
Severity:
Reason for Closing:
Reason for Blocked:
Needs QA:
Yes
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Related projects 1 project

Description

https://github.com/freenas/freenas/blob/master/src/middlewared/middlewared/job.py#L210

File descriptors are allocated here but there is no guarantee that they will be closed eventually. Job is responsible for closing them and it may fail.


Related issues

Copied to FreeNAS - Bug #29044: Rework middlewared pipes so that file descriptors won't leakDone

Associated revisions

Revision d5e1c720 (diff)
Added by Vladimir Vinogradenko over 1 year ago

fix(middleware): Ugly hack to close file descriptors opened by mail.send

Ticket: #28982

History

#1 Updated by William Grzybowski over 1 year ago

Release Concil, this will lead to undesirable side effects of middlewared on long term. It will lockup the process and deny requests.

#2 Updated by Dru Lavigne over 1 year ago

  • Category set to Middleware
  • Target version changed from N/A to TrueNAS 11.1-U2

#3 Updated by Dru Lavigne over 1 year ago

  • Target version changed from TrueNAS 11.1-U2 to TrueNAS 11.1-U3

#4 Updated by William Grzybowski over 1 year ago

  • Copied to Bug #29044: Rework middlewared pipes so that file descriptors won't leak added

#5 Updated by William Grzybowski over 1 year ago

We have decided to not fix the underlying issue, but just to mitigate it by explicitly closing file descriptors on some jobs.

This is just for U3 because the changeset is too big.

#6 Updated by Vladimir Vinogradenko over 1 year ago

  • Status changed from Not Started to In Progress

#7 Updated by Vladimir Vinogradenko over 1 year ago

  • Status changed from In Progress to Done

#8 Updated by Dru Lavigne over 1 year ago

  • Subject changed from @job(pipe=True) leaking file descriptors to Temporary fix to silence "@job(pipe=True) leaking file descriptors" messages
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No
  • Hide from ChangeLog changed from No to Yes

This one is not committed to master as it is a temporary hack.

#9 Updated by Dru Lavigne over 1 year ago

  • Project changed from TrueNAS to FreeNAS
  • Category changed from Middleware to Middleware
  • Target version changed from TrueNAS 11.1-U3 to 11.1-U3
  • Migration Needed deleted (No)
  • Hide from ChangeLog deleted (Yes)
  • Support Department Priority deleted (0)

Also available in: Atom PDF