Project

General

Profile

Bug #29185

Add --pidfile flag to middlewared

Added by William Grzybowski over 1 year ago. Updated about 1 year ago.

Status:
Done
Priority:
No priority
Assignee:
Brandon Schneider
Category:
Middleware
Target version:
Severity:
High
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Since last middlewared rc.d changes:

freenas# service middlewared stop
Stopping middlewared.
Waiting for PIDS: 272.
freenas# ps axuww|grep midd
root       7886  23.0  4.1  70160  62264  -  R    09:03    0:02.62 python3.6: middlewared (python3.6)
root        270   0.0  0.1   6344   1360  -  Ss   08:50    0:00.00 daemon: /usr/local/bin/middlewared[7886] (daemon)

Associated revisions

Revision f160b0d2 (diff)
Added by Brandon Schneider over 1 year ago

fix(rc.d): Don't stomp on daemon's pid

Previous behavior would overwrite the pid of the daemon process, thus rc.d is killing the wrong process.

Ticket: #29185

Revision 3daddc9e (diff)
Added by Brandon Schneider over 1 year ago

feat(rc.d): --pidfile flag

Previous behavior would overwrite the pid of the daemon process, thus rc.d would kill the wrong process.

Middlewared no longer has a daemon mode, and always runs in foreground. To allow daemon(8) to control the pidfile, we have a flag for debug to create a pidfile in the absence of daemon(8)

Ticket: #29185

Revision 26f0a2d5 (diff)
Added by Brandon Schneider over 1 year ago

feat(rc.d): --pidfile flag

Previous behavior would overwrite the pid of the daemon process, thus rc.d would kill the wrong process.

Middlewared no longer has a daemon mode, and always runs in foreground. To allow daemon(8) to control the pidfile, we have a flag for debug to create a pidfile in the absence of daemon(8)

Ticket: #29185

Revision 61832f82 (diff)
Added by Brandon Schneider over 1 year ago

feat(rc.d): --pidfile flag (#948)

  • feat(rc.d): --pidfile flag

Previous behavior would overwrite the pid of the daemon process, thus rc.d would kill the wrong process.

Middlewared no longer has a daemon mode, and always runs in foreground. To allow daemon(8) to control the pidfile, we have a flag for debug to create a pidfile in the absence of daemon(8)

Ticket: #29185

  • Remove unused variable
  • We don't want TRACE as production default

William noted this to me

History

#1 Updated by Brandon Schneider over 1 year ago

  • Status changed from Not Started to In Progress

#2 Updated by Brandon Schneider over 1 year ago

  • Status changed from In Progress to Done
  • Needs Merging changed from Yes to No

#3 Updated by Dru Lavigne over 1 year ago

  • Subject changed from Cannot gracefully stop middlewared to Add --pidfile flag to middlewared
  • Needs Doc changed from Yes to No

#4 Updated by Dru Lavigne about 1 year ago

  • Status changed from Done to Ready for Testing

#5 Updated by William Grzybowski about 1 year ago

  • Needs QA changed from Yes to No

#6 Updated by Dru Lavigne about 1 year ago

  • Status changed from Ready for Testing to Done

Also available in: Atom PDF