Project

General

Profile

Bug #30010

Fix UI display bug for iSCSI LUNs

Added by Joshua Sirrine about 1 year ago. Updated 10 months ago.

Status:
Done
Priority:
Important
Assignee:
Waqar Ahmed
Category:
Middleware
Target version:
Seen in:
Severity:
Low Medium
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Related projects 1 project

Description

In certain circumstances there are situations where the long-removed "auto" function for iscsi LUN numbering will reassert itself in some kind of edge case. This happens when setting up a new LUN and assigning it to zero. When you click the OK button to add it, the zero is replaced with AUTO. This does not automatically happen for all circumstances. Investigation with Ash revealed the code that is broken creating this:

class ISCSITargetToExtentResourceMixin(object):

class Meta:
resource_name = 'services/iscsi/targettoextent'

def dehydrate(self, bundle):
bundle = super(ISCSITargetToExtentResourceMixin, self).dehydrate(
bundle
)
if self.is_webclient(bundle.request):
if bundle.obj.iscsi_lunid is None:
bundle.data['iscsi_lunid'] = 'Auto'
bundle.data['iscsi_target'] = bundle.obj.iscsi_target
bundle.data['iscsi_extent'] = bundle.obj.iscsi_extent
else:
bundle.data['iscsi_target'] = bundle.obj.iscsi_target.id
bundle.data['iscsi_extent'] = bundle.obj.iscsi_extent.id
return bundle

This is on my personal system, so is not accessible via the VPN. If there is anything I can do to assist, please let me know via RC.

The screenshots attached are from FeeNAS 11.1-U1.

2018-03-16_09h23_09.jpg (371 KB) 2018-03-16_09h23_09.jpg Joshua Sirrine, 03/16/2018 09:30 AM
2018-03-16_09h23_16.jpg (361 KB) 2018-03-16_09h23_16.jpg Joshua Sirrine, 03/16/2018 09:30 AM
15217
15223

Associated revisions

Revision 751507ce (diff)
Added by Waqar Ahmed 12 months ago

Bug fix for iscsi target to extent display where 0 lunid is displayed as auto
ticket: #30010

Revision dae57caa (diff)
Added by Waqar Ahmed 12 months ago

Lun id made a non-nullable field
ticket: #30010

Revision a00d829d (diff)
Added by Waqar Ahmed 12 months ago

Lun id made a non-nullable field
ticket: #30010

History

#1 Updated by Dru Lavigne about 1 year ago

  • Category set to Middleware
  • Assignee set to William Grzybowski
  • Target version changed from N/A to TrueNAS 11.2

#2 Updated by William Grzybowski about 1 year ago

  • Status changed from Not Started to Blocked
  • Reason for Blocked set to Waiting for feedback

I dont understand, the screenshot clearly shows this does not happen when LUN ID == 0, neither the code says that.

You seem to have a legacy entry with NULL, which means Auto, so what is the issue?

#3 Updated by William Grzybowski about 1 year ago

Scratch that, it is using Auto but that is not the offending code.

Better leave that part to developers : D

#4 Updated by William Grzybowski about 1 year ago

  • Status changed from Blocked to Not Started
  • Reason for Blocked deleted (Waiting for feedback)

#5 Updated by Dru Lavigne about 1 year ago

  • Project changed from TrueNAS to FreeNAS
  • Category changed from Middleware to Middleware
  • Target version changed from TrueNAS 11.2 to 11.3
  • Migration Needed deleted (No)
  • Hide from ChangeLog deleted (No)
  • Support Department Priority deleted (0)

William: once this is removed in the old UI, please pass to Erin for the new UI.

#6 Updated by William Grzybowski about 1 year ago

  • Severity set to Low Medium

#7 Avatar?id=13649&size=24x24 Updated by Ben Gadd 12 months ago

  • Target version changed from 11.3 to Backlog

#8 Updated by William Grzybowski 12 months ago

  • Assignee changed from William Grzybowski to Waqar Ahmed
  • Target version changed from Backlog to 11.2-RC2
  • Needs Merging changed from Yes to No

#9 Updated by Waqar Ahmed 12 months ago

  • Status changed from Not Started to In Progress

#10 Updated by Waqar Ahmed 12 months ago

  • Status changed from In Progress to Ready for Testing

#11 Updated by Dru Lavigne 12 months ago

  • Subject changed from Fully remove the "auto" feature from WebGUI to Fix UI display bug for iSCSI LUNs
  • Target version changed from 11.2-RC2 to 11.2-BETA1

#12 Updated by Paul Walker 10 months ago

  • Status changed from Ready for Testing to Passed Testing
  • Needs QA changed from Yes to No

Behavior seems to have changed in the new UI it will not let you use zero. If you leave it blank it will auto sequence the lun id's.
Tested in FreeNAS-11.2-INTERNAL7

#13 Updated by Dru Lavigne 10 months ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF