Project

General

Profile

Feature #30180

Add MSDOSFS locale into pool.import_disk dialog

Added by Vladimir Vinogradenko over 1 year ago. Updated over 1 year ago.

Status:
Done
Priority:
Important
Assignee:
Erin Clark
Category:
GUI (new)
Estimated time:
Severity:
Reason for Closing:
Reason for Blocked:
Waiting for feedback
Needs QA:
Yes
Needs Doc:
Yes
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:

Description

pool.import_disk now accepts 4 arguments. Third (after fs_type, before dst_path) is msdosfs_locale. It is empty string if fs_type is not msdosfs. If fs_type is msdosfs it is either empty string (default) or one of locales selected from dropdown list. List of locales can be obtained by pool.import_disk_msdosfs_locales


Related issues

Related to FreeNAS - Bug #27842: Add "MSDOSFS locale" field to Import Disk screenDone

Associated revisions

Revision 370cf92c (diff)
Added by Erin Clark over 1 year ago

Add msdosfs_locale to import disk (WIP) Ticket: #30180

Revision 9757d8c1 (diff)
Added by Erin Clark over 1 year ago

Add msdosfs locale to disk import and fix the ui so it works with the new api Ticket: #30180

Revision 752094c7 (diff)
Added by Dru Lavigne over 1 year ago

Add MSDOSFS locale field to docs. Ticket: #30180

Revision 6b77c189 (diff)
Added by Dru Lavigne over 1 year ago

Add MSDOSFS locale field to docs. Ticket: #30180

History

#1 Updated by Dru Lavigne over 1 year ago

  • Category set to GUI (new)
  • Target version set to 11.2-RC2

#2 Updated by Vladimir Vinogradenko over 1 year ago

Proper API is:

pool.import_disk now accepts 4 arguments. Third (after fs_type, before dst_path) is fs_options. It is {} if fs_type is not msdosfs. If fs_type is msdosfs it is {'locale': ''} where locale is either empty string (default) or one of locales selected from dropdown list. List of locales can be obtained by pool.import_disk_msdosfs_locales

#3 Updated by Dru Lavigne over 1 year ago

  • Related to Bug #27842: Add "MSDOSFS locale" field to Import Disk screen added

#4 Updated by Erin Clark over 1 year ago

how do I test this filesystem type?

#5 Updated by Vladimir Vinogradenko over 1 year ago

Create file on the flash drive, copy this into name: "Привет"

Set locale to ru_RU.UTF-8

Run import, it should succeed and file name should be preserved

#6 Updated by Erin Clark over 1 year ago

  • Status changed from Not Started to Blocked
  • Reason for Blocked set to Waiting for feedback

I'm having problems getting the api to work, I try this

[ "da0", "msdosfs", {}, "/mnt/somepoo/anotherset/someset" ]

and this

[ "da0", "msdosfs", { msdosfs_locale: "ru_RU.UTF-8" }, "/mnt/somepoo/anotherset/someset" ]

but it tells me "Mount failed (exit code 1): mount_msdosfs: da0: No such file or directory"

but if I do "mount -t msdosfs /dev/da0s1 someset" it succeeds.

#7 Updated by Erin Clark over 1 year ago

I think I see the problem, it doesn't even show me my da0s1

#8 Updated by Erin Clark over 1 year ago

I am using this call this.ws.call("disk.get_unused", [true]), is that still correct?

#9 Updated by Dru Lavigne over 1 year ago

  • Assignee changed from Erin Clark to Vladimir Vinogradenko

#10 Updated by Erin Clark over 1 year ago

  • Status changed from Blocked to Screened
  • Assignee changed from Vladimir Vinogradenko to Erin Clark

After talking with vladimir I have it figured out

#12 Updated by Erin Clark over 1 year ago

  • Status changed from Screened to In Progress
  • Assignee changed from Erin Clark to Lola Yang

Could you review lola?

#13 Updated by Lola Yang over 1 year ago

  • Status changed from In Progress to Done
  • Assignee changed from Lola Yang to Erin Clark

#14 Updated by Dru Lavigne over 1 year ago

  • Target version changed from 11.2-RC2 to Master - FreeNAS Nightlies
  • Needs Merging changed from Yes to No

Also available in: Atom PDF