Project

General

Profile

Bug #31299

Separate S.M.A.R.T. email addresses with spaces

Added by Mattias Svahn about 1 year ago. Updated 10 months ago.

Status:
Done
Priority:
Important
Assignee:
Vladimir Vinogradenko
Category:
Middleware
Target version:
Seen in:
Severity:
Low Medium
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

If adding more than one e-mail address i smartd service gui, you get an error.

email_error.JPG (30.8 KB) email_error.JPG Mattias Svahn, 04/12/2018 01:49 AM
LegacyUISMARTemails-2018-06-13.png (32.5 KB) LegacyUISMARTemails-2018-06-13.png Michael Reynolds, 06/13/2018 08:22 AM
SMARTemailnotificationaddresses-2018-06-13.png (116 KB) SMARTemailnotificationaddresses-2018-06-13.png Michael Reynolds, 06/13/2018 10:18 AM
output.mp4 (480 KB) output.mp4 Zackary Welch, 06/13/2018 02:30 PM
16473
18430
18436

Related issues

Related to FreeNAS - Bug #34951: Separate S.M.A.R.T. email addresses with spacesDone

Associated revisions

Revision 9df067a5 (diff)
Added by Vladimir Vinogradenko about 1 year ago

Doc should say that SMART emails should be separated with spaces

TIcket: #31299

Revision 36162ba5 (diff)
Added by Vladimir Vinogradenko about 1 year ago

Fix poor representation of validation errors for elements of lists that are only splitted by middleware_clean

Ticket: #31299

Revision f97ba70e (diff)
Added by Vladimir Vinogradenko about 1 year ago

smartd config uses commas to separate emails so let's store it that way

Ticket: #31299

Revision 06433c8d (diff)
Added by Dru Lavigne 12 months ago

SMART email to report now supports multiple email addresses.
Ticket: #31299

Revision 0c391a62 (diff)
Added by Dru Lavigne 12 months ago

SMART email to report now supports multiple email addresses.
Ticket: #31299

Revision 15a9e236 (diff)
Added by Vladimir Vinogradenko 10 months ago

fix(oldguit): Show smart_email as space-separated instead of comma-separated

Ticket: #31299

Revision 0641fa51 (diff)
Added by Vladimir Vinogradenko 10 months ago

fix(oldgui): Show smart_email as space-separated instead of comma-separated

Ticket: #31299

Revision 47afd75d (diff)
Added by Vladimir Vinogradenko 10 months ago

fix(oldgui): Show smart_email as space-separated instead of comma-separated

Ticket: #31299

History

#1 Updated by Mattias Svahn about 1 year ago

  • Seen in changed from Unspecified to 11.1-U4

#2 Updated by Dru Lavigne about 1 year ago

  • Private changed from No to Yes
  • Reason for Blocked set to Need additional information

Mattias: to confirm, is this in the old UI or the new UI?

Also, please attach a debug (System -> Advanced -> Save Debug) to this ticket.

#3 Updated by Mattias Svahn about 1 year ago

  • Reason for Blocked deleted (Need additional information)

the old UI

#4 Updated by Mattias Svahn about 1 year ago

  • File debug-freenas08-20180405083141.tgz added

#5 Updated by Dru Lavigne about 1 year ago

  • Category changed from GUI (new) to Middleware
  • Assignee changed from Release Council to William Grzybowski
  • Target version set to 11.2-RC2

#6 Updated by William Grzybowski about 1 year ago

  • Assignee changed from William Grzybowski to Vladimir Vinogradenko
  • Target version changed from 11.2-RC2 to 11.3
  • Severity set to Low Medium

#7 Updated by Vladimir Vinogradenko about 1 year ago

  • Status changed from Unscreened to Screened
  • Priority changed from No priority to Important

#8 Updated by Vladimir Vinogradenko about 1 year ago

  • Status changed from Screened to Blocked
  • Reason for Blocked set to Waiting for feedback

Mattias, what error? I can't find any in the logs you've attached.

#9 Updated by Mattias Svahn about 1 year ago

16473

see attachmed image.

#10 Updated by Vladimir Vinogradenko about 1 year ago

  • Status changed from Blocked to Ready for Testing

#11 Updated by Dru Lavigne about 1 year ago

  • Subject changed from more than one e-mail addresse in smartd problem to Separate S.M.A.R.T. email addresses with spaces
  • Target version changed from 11.3 to 11.2-BETA1
  • Needs Merging changed from Yes to No

#12 Updated by Dru Lavigne about 1 year ago

  • File deleted (debug-freenas08-20180405083141.tgz)

#13 Updated by Dru Lavigne about 1 year ago

  • Private changed from Yes to No

#15 Updated by Michael Reynolds 10 months ago

18430

This ticket is not done. New comment to address the issues.

#16 Updated by Michael Reynolds 10 months ago

  • Status changed from Passed Testing to Failed Testing
  • Needs QA changed from No to Yes

#17 Updated by Michael Reynolds 10 months ago

18436

Currently, the legacy UI allows email addresses to be entered using commas or spaces.
The webui only allows space separated entries. See SMARTemailnotificationaddresses-2018-06-13.png The screenshot shows comma and web seperated entries, and the error given.

Both UIs display email addresses in the comma separated form.

Asked Vladimir to clarify the following:
Are email addresses stored comma separated, and should be entered comma separated?
Should we allow comma or space separated entries? (both?)
Should the UI display multiple emails address entries in space or comma separated format?

Once we get these answer, I'll update this ticket to get everything updated/corrected.

The webui tooltip (and userguide entries) need to be updated to reflect that multiple notification email addresses can be entered, and the prefered format.

#18 Updated by Michael Reynolds 10 months ago

Spoke to Vladimir, he said:

We want it[the email address field) to both accept and display them[multiple email addresses in the field] as space separated
Comma-separated should not be a thing

He'll work on this ticket

#19 Updated by Michael Reynolds 10 months ago

Legacy UI allows comma separated emails entries, should only allow space separated.

#20 Updated by Vladimir Vinogradenko 10 months ago

  • Status changed from Failed Testing to Ready for Testing

#21 Updated by Michael Reynolds 10 months ago

Update webui tooltip with multiple email entries instruction
https://github.com/freenas/webui/pull/880

#22 Avatar?id=55038&size=24x24 Updated by Zackary Welch 10 months ago

Fails testing in the new UI. Emails can be separated by spaces, but using ', ' or ',' causes an error. This is problematic when multiple emails were added via spaces, since they are changed to comma separation which fails when you save settings.

#23 Avatar?id=55038&size=24x24 Updated by Zackary Welch 10 months ago

This also occurs in the old UI. It's fine for input to be validated by separating with spaces, but when they are changed to commas that causes the input to fail. When configuring the service the previously entered emails should probably be parsed back into space separation.

#24 Updated by Vladimir Vinogradenko 10 months ago

Zackary, the one on video is new UI bug. Please report it to the new UI team.

Same behavior in old UI was fixed 3 hours ago. There was no build since then, you were testing old code.

#25 Avatar?id=55038&size=24x24 Updated by Zackary Welch 10 months ago

Sorry, didn't notice how recent those updates were. I will go report it to the new UI them then.

#26 Avatar?id=55038&size=24x24 Updated by Zackary Welch 10 months ago

#27 Updated by Dru Lavigne 10 months ago

  • Related to Bug #34951: Separate S.M.A.R.T. email addresses with spaces added

#28 Updated by Michael Reynolds 10 months ago

  • Status changed from Ready for Testing to Passed Testing
  • Reason for Blocked deleted (Waiting for feedback)
  • Needs QA changed from Yes to No

legacy UI accepts and displays email addresses in space separated format

#29 Updated by Dru Lavigne 10 months ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF