Project

General

Profile

Bug #31674

Do not spawn another middleware thread if only the thread id is different

Added by Bonnie Follweiler about 1 year ago. Updated about 1 year ago.

Status:
Done
Priority:
No priority
Assignee:
William Grzybowski
Category:
Middleware
Target version:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

I updated the mini to FreeNAS-11-MASTER-201804100626

After the update I get a Critical Alert red light, in the Legacy UI, and when I click on it I get a Traceback message.
There is no alert notification in the new GUI

CRITICAL: April 10, 2018, 12:52 p.m. - Unable to run alert source 'HasUpdate' Traceback (most recent call last): File "/usr/local/lib/python3.6/site-packages/middlewared/plugins/alert.py", line 323, in run_source alerts = (await alert_source.check()) or [] File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 128, in throw return self.gen.throw(type, value, traceback) File "/usr/local/lib/python3.6/site-packages/middlewared/alert/base.py", line 91, in check return await self.middleware.run_in_thread(self.check_sync) File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 128, in throw return self.gen.throw(type, value, traceback) File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 875, in run_in_thread return await self.run_in_executor(self.__threadpool, method, *args, **kwargs) File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 128, in throw return self.gen.throw(type, value, traceback) File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 872, in run_in_executor return await loop.run_in_executor(pool, functools.partial(method, *args, **kwargs)) File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run result = self.fn(*self.args, **self.kwargs) File "/usr/local/lib/python3.6/site-packages/middlewared/plugins/../alert/source/update.py", line 32, in check_sync path = self.middleware.call_sync("notifier.get_update_location") File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 1010, in call_sync return fut.result() File "/usr/local/lib/python3.6/concurrent/futures/_base.py", line 425, in result return self.__get_result() File "/usr/local/lib/python3.6/concurrent/futures/_base.py", line 384, in _get_result raise self._exception File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 928, in _call return methodobj(*args) File "/usr/local/www/freenasUI/middleware/notifier.py", line 1607, in get_update_location with client as c: File "/usr/local/www/freenasUI/middleware/client.py", line 20, in __enter local.client = Client() File "/usr/local/lib/python3.6/site-packages/middlewared/client/client.py", line 310, in init raise e File "/usr/local/lib/python3.6/site-packages/middlewared/client/client.py", line 304, in init self._ws.connect() File "/usr/local/lib/python3.6/site-packages/middlewared/client/client.py", line 169, in connect rv = super(WSClient, self).connect() File "/usr/local/lib/python3.6/site-packages/ws4py/client/_init__.py", line 215, in connect bytes = self.sock.recv(128) socket.timeout: timed out

Associated revisions

Revision dbb3c564 (diff)
Added by William Grzybowski about 1 year ago

fix(middlwared): do not spawn thread only if thread id is different

Ticket: #31674

Revision b9262a7e (diff)
Added by William Grzybowski about 1 year ago

fix(middlwared): do not spawn thread only if thread id is different

Ticket: #31674

Revision 7a9bb9dd (diff)
Added by William Grzybowski about 1 year ago

fix(middlwared): do not spawn thread only if thread id is different

Ticket: #31674
(cherry picked from commit b9262a7e7d86edb5f058f39f7b4a487bf992c0fb)

Revision 587a63ab (diff)
Added by William Grzybowski about 1 year ago

fix(middlwared): do not spawn thread only if thread id is different

Ticket: #31674
(cherry picked from commit b9262a7e7d86edb5f058f39f7b4a487bf992c0fb)

History

#1 Updated by Bonnie Follweiler about 1 year ago

  • File debug-bonniemini-20180410074725.tgz added

#2 Updated by Bonnie Follweiler about 1 year ago

  • Private changed from No to Yes

#3 Updated by William Grzybowski about 1 year ago

  • Status changed from Unscreened to Screened

#4 Updated by William Grzybowski about 1 year ago

  • Status changed from Screened to Not Started

#5 Updated by William Grzybowski about 1 year ago

  • Status changed from Not Started to In Progress
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#6 Updated by William Grzybowski about 1 year ago

  • Status changed from In Progress to Ready for Testing

#7 Updated by Dru Lavigne about 1 year ago

  • Subject changed from After the latest Nightlies update I get a Critical Alert Tracebackin the old GUI and no alert notification in the new GUI to Do not spawn another middleware thread if only the thread id is different

#8 Updated by Dru Lavigne about 1 year ago

  • File deleted (debug-bonniemini-20180410074725.tgz)

#9 Updated by Dru Lavigne about 1 year ago

  • Private changed from Yes to No

#10 Updated by Bonnie Follweiler about 1 year ago

  • Status changed from Ready for Testing to Passed Testing
  • Severity set to New
  • Needs QA changed from Yes to No

Test Passed in FreeNAS-11.2-INTERNAL8

#11 Updated by Dru Lavigne about 1 year ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF