Project

General

Profile

Bug #32535

Mount ZFS dataset before setting share type

Added by Joe Maloney 12 months ago. Updated 10 months ago.

Status:
Done
Priority:
No priority
Assignee:
William Grzybowski
Category:
Middleware
Target version:
Severity:
Med High
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

```
Error: Traceback (most recent call last):
File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 151, in call_method
result = await self.middleware.call_method(self, message)
File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 129, in throw
return self.gen.throw(type, value, traceback)
File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 984, in call_method
return await self._call(message['method'], serviceobj, methodobj, params, app=app)
File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 129, in throw
return self.gen.throw(type, value, traceback)
File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 923, in call
return await methodobj(*args)
File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 129, in throw
return self.gen.throw(type, value, traceback)
File "/usr/local/lib/python3.6/site-packages/middlewared/service.py", line 254, in create
f'{self._config.namespace}.create', self, self.do_create, [data]
File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 129, in throw
return self.gen.throw(type, value, traceback)
File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 923, in _call
return await methodobj(*args)
File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 129, in throw
return self.gen.throw(type, value, traceback)
File "/usr/local/lib/python3.6/site-packages/middlewared/schema.py", line 604, in nf
return await f(*args, **kwargs)
File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 129, in throw
return self.gen.throw(type, value, traceback)
File "/usr/local/lib/python3.6/site-packages/middlewared/plugins/pool.py", line 625, in do_create
'notifier.change_dataset_share_type', data['name'], data['share_type'].lower()
File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 129, in throw
return self.gen.throw(type, value, traceback)
File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 988, in call
return await self._call(name, serviceobj, methodobj, params, pipes=pipes)
File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 129, in throw
return self.gen.throw(type, value, traceback)
File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 938, in _call
return await self.run_in_thread(methodobj, *args)
File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 129, in throw
return self.gen.throw(type, value, traceback)
File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 875, in run_in_thread
return await self.run_in_executor(self.
_threadpool, method, *args, **kwargs)
File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 129, in throw
return self.gen.throw(type, value, traceback)
File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 872, in run_in_executor
return await loop.run_in_executor(pool, functools.partial(method, *args, **kwargs))
File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run
result = self.fn(*self.args, **self.kwargs)
File "/usr/local/www/freenasUI/middleware/notifier.py", line 3601, in change_dataset_share_type
self.dataset_init_apple_meta_file(dataset)
File "/usr/local/www/freenasUI/middleware/notifier.py", line 3576, in dataset_init_apple_meta_file
with open("%s/.apple" % path, "w") as f:
FileNotFoundError: [Errno 2] No such file or directory: '/mnt/mac_tank/test3/.apple'
```

This is happening in nightly build FreeNAS-11-MASTER-201804200410. To reproduce create a dataset, and under share type choose Mac as shown in the screenshot.

Associated revisions

Revision b36f64a2 (diff)
Added by William Grzybowski 12 months ago

fix(middlewared/pool): mount zfs dataset before set share type

Ticket: #32535

Revision 867a082d (diff)
Added by William Grzybowski 12 months ago

fix(middlewared/pool): mount zfs dataset before set share type

Ticket: #32535

Revision 6c504966 (diff)
Added by William Grzybowski 12 months ago

fix(middlewared/pool): mount zfs dataset before set share type

Ticket: #32535

History

#1 Updated by Dru Lavigne 12 months ago

  • Assignee changed from Release Council to William Grzybowski
  • Target version set to 11.2-RC2

#2 Updated by William Grzybowski 12 months ago

  • Status changed from Unscreened to In Progress
  • Severity set to Med High

#3 Updated by William Grzybowski 12 months ago

  • Status changed from In Progress to Ready for Testing
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#4 Updated by Dru Lavigne 12 months ago

  • Subject changed from Issue creating dataset with Mac share type to Mount ZFS dataset before setting share type

#5 Updated by Dru Lavigne 12 months ago

  • Target version changed from 11.2-RC2 to 11.2-BETA1

#6 Updated by William Grzybowski 10 months ago

  • Needs QA changed from Yes to No

#7 Updated by Dru Lavigne 10 months ago

  • Status changed from Ready for Testing to Done

Also available in: Atom PDF