Convert iSCSI targets to use entity-form in new UI
A few commits ago fieldsets were implemented in entity-form. Since then I've since noticed that not all of the forms were implementing that feature. As it turns out those forms aren't using entity-form. Competing form implementations in the code base is not a good thing. Now in order for fieldsets to be available to all forms, I'd have to rewrite it for every form implementation in the code base.
I suggest we adapt all the forms in the UI to use entity-form. If entity-form doesn't provide the required functionality, we should be using typescript's inheritance to extend entity-form in a new class. That way any new features added to entity-form would be passed down the inheritance chain. This would not only avoid duplication of effort, but improve the consistency of how our forms look and behave.
#8 Updated by Lola Yang over 1 year ago
- Status changed from Screened to In Progress
The jails section (jails add/edit component) use expand panels, not simply entity-form, so we cannot convert to an entity-form based component that could apply all the layout related changes of entity-form.
For the iscsi targets section, I convert it to an entity-form based component and use WS call instead of rest call.
#12 Updated by Dru Lavigne over 1 year ago
- Subject changed from Convert all forms in UI to use or extend a base class (entity-form) to Convert iSCSI targets to use entity-form in new UI
- Status changed from In Progress to Ready for Testing
- Needs Doc changed from Yes to No
- Needs Merging changed from Yes to No