Project

General

Profile

Bug #33036

Convert iSCSI targets to use entity-form in new UI

Added by Damian Szidiropulosz almost 2 years ago. Updated over 1 year ago.

Status:
Done
Priority:
No priority
Assignee:
Lola Yang
Category:
GUI (new)
Target version:
Seen in:
Severity:
Low
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

A few commits ago fieldsets were implemented in entity-form. Since then I've since noticed that not all of the forms were implementing that feature. As it turns out those forms aren't using entity-form. Competing form implementations in the code base is not a good thing. Now in order for fieldsets to be available to all forms, I'd have to rewrite it for every form implementation in the code base.

I suggest we adapt all the forms in the UI to use entity-form. If entity-form doesn't provide the required functionality, we should be using typescript's inheritance to extend entity-form in a new class. That way any new features added to entity-form would be passed down the inheritance chain. This would not only avoid duplication of effort, but improve the consistency of how our forms look and behave.


Related issues

Has duplicate FreeNAS - Bug #52204: Adding iSCSI Target with invalid characters shows no error message.Closed

History

#1 Updated by Erin Clark almost 2 years ago

  • Status changed from Unscreened to Screened

#2 Updated by Erin Clark over 1 year ago

  • Severity changed from New to Low

#3 Updated by Dru Lavigne over 1 year ago

  • Target version changed from 11.3 to 11.2-RC1

#5 Updated by Erin Clark over 1 year ago

  • Assignee changed from Erin Clark to Lola Yang

#7 Updated by Dru Lavigne over 1 year ago

  • Target version changed from 11.2-RC1 to 11.2-RC2

#8 Updated by Lola Yang over 1 year ago

  • Status changed from Screened to In Progress

The jails section (jails add/edit component) use expand panels, not simply entity-form, so we cannot convert to an entity-form based component that could apply all the layout related changes of entity-form.
For the iscsi targets section, I convert it to an entity-form based component and use WS call instead of rest call.

master: https://github.com/freenas/webui/pull/1354
stable: https://github.com/freenas/webui/pull/1355

#9 Updated by Lola Yang over 1 year ago

  • Related to Bug #52204: Adding iSCSI Target with invalid characters shows no error message. added

#10 Updated by Dru Lavigne over 1 year ago

  • Related to deleted (Bug #52204: Adding iSCSI Target with invalid characters shows no error message.)

#11 Updated by Dru Lavigne over 1 year ago

  • Has duplicate Bug #52204: Adding iSCSI Target with invalid characters shows no error message. added

#12 Updated by Dru Lavigne over 1 year ago

  • Subject changed from Convert all forms in UI to use or extend a base class (entity-form) to Convert iSCSI targets to use entity-form in new UI
  • Status changed from In Progress to Ready for Testing
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#14 Updated by Bonnie Follweiler over 1 year ago

  • Status changed from Ready for Testing to Passed Testing
  • Needs QA changed from Yes to No

Test Passed in FreeNAS-11.2-INTERNAL32

#15 Updated by Dru Lavigne over 1 year ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF