Project

General

Profile

Bug #33567

Jails -> Wizard Jail Name allows invalid characters

Added by Michael Reynolds over 2 years ago. Updated over 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
Michael Reynolds
Category:
GUI (new)
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
Yes
Needs Doc:
Yes
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Jail Names can only contain alphanumeric characters, dashes, or underscores. The Jail Name field allows invalid characters to be entered for a Jail Name.

When invalid characters are found, the Jail Name field should turn red and the Next button should be disabled.

This happens when the Jail Name is left blank as shown in the first screenshot.

Invalid characters used for a Jail Name are shown in the second screenshot. Notice the Jail Networking step is lit up as clicking Next was allowed, then went back to the first step to grab the screenshot.

https://stackoverflow.com/questions/5887678/alphanumeric-dash-and-underscore-but-no-spaces-regular-expression-check-javascr#5887729 may be helpful for the regex needed.

BlankJailName2018-05-14.png (35.1 KB) BlankJailName2018-05-14.png Michael Reynolds, 05/14/2018 05:35 PM
InvalidJailName2018-05-14.png (40.3 KB) InvalidJailName2018-05-14.png Michael Reynolds, 05/14/2018 05:35 PM
17460
17463

Related issues

Has duplicate FreeNAS - Bug #33606: Jails -> Add -> Jails Name field allows invalid charactersClosed

History

#1 Updated by Michael Reynolds over 2 years ago

This was an easy regex
submitted PR https://github.com/freenas/webui/pull/734 to fix
Actually resolved in https://github.com/freenas/webui/pull/748

#2 Updated by Dru Lavigne over 2 years ago

  • Status changed from Unscreened to In Progress
  • Assignee changed from Erin Clark to Michael Reynolds

#3 Updated by Michael Reynolds over 2 years ago

  • Status changed from In Progress to Ready for Testing

I've verified this works myself ready for verification/merging :)

#4 Updated by Michael Reynolds over 2 years ago

  • Status changed from Ready for Testing to In Progress

#5 Updated by Michael Reynolds over 2 years ago

This bug was actually resolved in PR https://github.com/freenas/webui/pull/748

#6 Updated by Dru Lavigne over 2 years ago

  • Status changed from In Progress to Done
  • Target version changed from 11.2-BETA1 to Master - FreeNAS Nightlies
  • Needs Merging changed from Yes to No

#7 Updated by Dru Lavigne over 2 years ago

  • Related to Bug #33606: Jails -> Add -> Jails Name field allows invalid characters added

#8 Updated by Dru Lavigne over 2 years ago

  • Related to deleted (Bug #33606: Jails -> Add -> Jails Name field allows invalid characters)

#9 Updated by Dru Lavigne over 2 years ago

  • Has duplicate Bug #33606: Jails -> Add -> Jails Name field allows invalid characters added

Also available in: Atom PDF