Project

General

Profile

Bug #33588

VM Wizard does not report errors at submit time

Added by Anonymous over 3 years ago. Updated over 3 years ago.

Status:
Done
Priority:
No priority
Assignee:
Vaibhav Chauhan
Category:
GUI (new)
Seen in:
Severity:
High
Reason for Closing:
Reason for Blocked:
Needs QA:
Yes
Needs Doc:
Yes
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

I was trying to create a vm on a drive that didn't have enough space for it and noticed it does not report an error. Upon further investigation I notice that the code just closes the loader and does nothing with the error:

```
this.ws.call('pool.dataset.create', [payload]).subscribe(res => {
for (const device of vm_payload["devices"]){
if (device.dtype === "DISK"){
const orig_hdd = device.attributes.path;
device.attributes.path = '/dev/zvol/' + orig_hdd
};
};
this.ws.call('vm.create', [vm_payload]).subscribe(vm_res => {
this.loader.close();
this.router.navigate(['/vm']);
});
},(error) => {
this.loader.close();
});

```

A nice sprinkling of this.dialogService.errorReport(T("Error creating VM"), res.reason, res.trace.formatted) should do the trick (you may also want to do this for the dataset creation too.

History

#1 Updated by Vaibhav Chauhan over 3 years ago

  • Assignee changed from Vaibhav Chauhan to Anonymous

please review: https://github.com/freenas/webui/pull/750

for dataset form we dont need to implement it as code flow allows you to have an error dialog in entity-form itself.

#2 Updated by Anonymous over 3 years ago

  • Status changed from Unscreened to In Progress

#3 Updated by Anonymous over 3 years ago

  • Status changed from In Progress to Done
  • Assignee changed from Anonymous to Vaibhav Chauhan

#4 Updated by Dru Lavigne over 3 years ago

  • Target version changed from 11.2-BETA1 to Master - FreeNAS Nightlies
  • Needs Merging changed from Yes to No

Also available in: Atom PDF