Project

General

Profile

Feature #33648

Add password toggle button to new UI

Added by Timothy Moore II over 2 years ago. Updated almost 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
Dennis Mullen
Category:
GUI (new)
Target version:
Estimated time:
Severity:
Low Medium
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:

Description

I'm testing the new UI with a FreeNAS system updated to the latest 11 Nightly version.

I noticed that many of the "Password" fields in forms obscure the text entered. I think users will expect to have a toggle button to make the text they're typing visible. It may even be more beneficial to users/administrators to make the text visible by default (maybe have a global toggle in System/General?).

UPS Password.png (118 KB) UPS Password.png Jeff Ervin, 09/06/2018 06:57 AM
Password Toggle Fix.png (81.6 KB) Password Toggle Fix.png Jeff Ervin, 09/07/2018 06:14 AM
28748
29184

Related issues

Related to FreeNAS - Feature #45303: Create font port of Material iconsDone

Associated revisions

Revision 438583bd (diff)
Added by Dennis Mullen about 2 years ago

rough draft of button to toggle pw visibility Ticket: #33648

Revision 19c8dd78 (diff)
Added by Dennis Mullen about 2 years ago

Get PW toggle working and placed on entity forms Ticket: #33648

Revision ea9c534d (diff)
Added by Dennis Mullen about 2 years ago

Get password toggle button working throughout the app Ticket: #33648

History

#1 Updated by Erin Clark over 2 years ago

  • Status changed from Unscreened to Screened

#2 Updated by Erin Clark about 2 years ago

  • Status changed from Screened to Unscreened
  • Assignee changed from Erin Clark to Dennis Mullen

#3 Updated by Dennis Mullen about 2 years ago

  • Status changed from Unscreened to Screened

#4 Updated by Dennis Mullen about 2 years ago

  • Status changed from Screened to In Progress

#6 Updated by Dru Lavigne about 2 years ago

  • Target version changed from Backlog to 11.2-BETA3

#7 Updated by Erin Clark about 2 years ago

  • Status changed from In Progress to Ready for Testing

#8 Updated by Dru Lavigne about 2 years ago

  • Subject changed from Add button to make passwords visible to Add password toggle button to new UI
  • Needs Merging changed from Yes to No

#9 Updated by Aaron St. John about 2 years ago

  • Status changed from Ready for Testing to Failed Testing

Tested on FreeNAS-11.2-MASTER-201808070859.

First thing I checked was the login screen. Password was always obscured.

Checked, when creating a user, if the password could be hidden/shown. This was working.

Checked locking a pool. When creating a passphrase for an encrypted pool it is always obscured.

I've checked the "Needs Design Doc" because I'm not sure if y'all would want to make EVERYTHING have the option to be shown/hidden.
Perhaps hide passphrases always, but give the option to show/hide passwords? Also, things that say "Secret Key" are always shown. Is this a desired trait?

#10 Updated by Dennis Mullen about 2 years ago

  • Status changed from Failed Testing to In Progress

New PR 1212

#11 Updated by Dru Lavigne about 2 years ago

  • Status changed from In Progress to Ready for Testing

#12 Updated by Jeff Ervin about 2 years ago

28748

Failed Testing FreeNAS-11.2-MASTER-201809050856

Service-->UPS / Monitoring password does not have toggle.

#13 Updated by Dennis Mullen about 2 years ago

New PR 1227 adds pw toggle to UPS services page

#14 Updated by Dru Lavigne about 2 years ago

  • Status changed from Failed Testing to Ready for Testing

#16 Updated by Jeff Ervin about 2 years ago

29184

Test Passes FreeNAS-11.2-MASTER-201809070900

#17 Updated by Jeff Ervin about 2 years ago

  • Status changed from Done to Passed Testing

#18 Updated by Dru Lavigne about 2 years ago

#19 Updated by Dru Lavigne about 2 years ago

  • Status changed from Passed Testing to Done

The "eyeball" will be added to the Guide once the port from the related ticket is available.

#20 Updated by Dru Lavigne almost 2 years ago

  • Needs Doc changed from Yes to No

Also available in: Atom PDF