Bug #34086
Create initial helptext file for groups as a model for all modules
Description
Long tooltip or other translatable strings are broken across lines and indented in the source for readability:
{ type : 'textarea', name : 'gc_domains', placeholder: T('Additional Domains'), tooltip : T('Add other domains to search, separated by spaces.\ Adding search domains can cause slow DNS lookups.'), },
However, this can result in the indentation being included in JSON or PO translation files. The conversion to or from PO needs to convert tabs to spaces and squash consecutive runs of spaces into a single space. This should be a trivial addition to the conversion, although exactly where and how to implement it is not so trivial.
This is something we should have in place before 11.2-beta1, or translators will have to rework many strings that have not actually changed.
Related issues
Associated revisions
History
#1
Updated by Dru Lavigne over 2 years ago
- Target version changed from 11.2-BETA1 to 11.2-RC2
#2
Updated by Dru Lavigne over 2 years ago
- Target version changed from 11.2-RC2 to 11.2-BETA3
#3
Updated by Dru Lavigne over 2 years ago
- Target version changed from 11.2-BETA3 to 11.2-RC2
#5
Updated by Dru Lavigne over 2 years ago
- Target version changed from 11.2-RC2 to 11.2-BETA3
#7
Updated by Dru Lavigne over 2 years ago
- Assignee changed from Warren Block to Anonymous
#8 Updated by Anonymous over 2 years ago
- Target version changed from 11.2-BETA3 to 11.2-RC1
#9 Updated by Anonymous over 2 years ago Private
This won't make it into the beta, pushing to RC1, will discuss on monday's meeting
#10 Updated by Anonymous over 2 years ago
- Status changed from Unscreened to In Progress
https://github.com/freenas/webui/pull/1211 this PR is for the proof of concept using groups, after we pull this one we will need to work on converting all of the other sections to use this model
#11
Updated by Dru Lavigne over 2 years ago
- Related to Umbrella #44889: Move strings from typescript files into helptext files added
#12
Updated by Lola Yang over 2 years ago
- Status changed from In Progress to Ready for Testing
#13
Updated by Dru Lavigne over 2 years ago
- Subject changed from Translatable strings have embedded runs of indentation which can interfere with translation to Create initial helptext file for groups as a model for all modules
- Needs Doc changed from Yes to No
- Needs Merging changed from Yes to No
#14
Updated by Bonnie Follweiler over 2 years ago
- Status changed from Ready for Testing to Passed Testing
- Needs QA changed from Yes to No
Test Passed in FreeNAS-11.2-MASTER-201809281304
#15
Updated by Dru Lavigne over 2 years ago
- Status changed from Passed Testing to Done