Project

General

Profile

Bug #34624

Add simple visual effect when clicking a navigation item in new UI

Added by Michael Reynolds 11 months ago. Updated 9 months ago.

Status:
Done
Priority:
No priority
Assignee:
Dennis Mullen
Category:
GUI (new)
Target version:
11.2-BETA2
Seen in:
Master - FreeNAS Nightlies
Severity:
Low
Reason for Closing:
Reason for Blocked:
Needs QA:
Yes
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Make the browser window small enough, or collapse the left menu
go to any section
Click the hamburger to open the menu
Click the blue text indicating the GUI is already at that section
nothing happens
The menu should collapse
or
if not dismiss, provide some other sort of visual indicator that the menu was clicked
Change the color of the text
do one of those fancy fills behind the text

*Please ping me on rocket if a video or screenshot is needed.

ClickMenuSectionOpen2018-06-08.mkv (795 KB) ClickMenuSectionOpen2018-06-08.mkv Michael Reynolds, 06/08/2018 02:27 PM
Click-Alert-2018-06-12.mkv (322 KB) Click-Alert-2018-06-12.mkv Michael Reynolds, 06/12/2018 09:58 AM
626.mkv (95.1 KB) 626.mkv Dennis Mullen, 06/26/2018 07:02 AM

Associated revisions

Revision 2221f525 (diff)
Added by Dennis Mullen 10 months ago

Adjust effect and timing
Ticket: #34624

History

#1 Updated by Erin Clark 11 months ago

  • Status changed from Unscreened to Screened

A video might help

#2 Updated by Michael Reynolds 10 months ago

In the attached video, the Jails section is open. Every time I mouse over the Jails menu option, I clicked it. More or less every time the Jails URL shows in the bottom left I clicked the Jails menu option.

I propose that when the menu is open and the section for the menu item clicked is already open, the menu should close.

#3 Updated by Erin Clark 10 months ago

  • Status changed from Screened to Unscreened
  • Assignee changed from Erin Clark to Dennis Mullen

#4 Updated by Dennis Mullen 10 months ago

  • Status changed from Unscreened to Screened

#5 Updated by Michael Reynolds 10 months ago

Found an example of what should happen when clicking a menu entry when already at that section.
See attached Click-Alert-2018-06-12.mkv video

The attached video is an example of what I meant with "Do one of those fancy fills behind the text"

#6 Updated by Dennis Mullen 10 months ago

Now in combined PR 974

PR 930

I went with the visual effect only. Difficult to reliably overwrite the default behavior, and the simple visual indicator is consistent with other apps (for an imperfect comparison, see attached vid on gmail.

#7 Updated by Dennis Mullen 10 months ago

  • Status changed from Screened to In Progress

#8 Updated by Dru Lavigne 10 months ago

  • Subject changed from After clicking on a menu choice when already at that section the menu should be dismissed to Add a simple visual effect on clicking a navigation item
  • Target version changed from Backlog to 11.2-BETA2

#9 Updated by Dennis Mullen 9 months ago

  • Status changed from In Progress to Ready for Testing

This one is in the build

#10 Updated by Dru Lavigne 9 months ago

  • Subject changed from Add a simple visual effect on clicking a navigation item to Add simple visual effect when clicking a navigation item in new UI
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#11 Updated by Michael Reynolds 9 months ago

  • Status changed from Ready for Testing to Passed Testing

Confirmed in 7-12 Nightly

Very simple but shows that the item was clicked.

#12 Updated by Dru Lavigne 9 months ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF