Project

General

Profile

Bug #34771

Catch any exceptions when updating a property

Added by Michael Reynolds over 2 years ago. Updated over 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
Brandon Schneider
Category:
Middleware
Target version:
Severity:
Medium
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Create a new jail with only the minimum required fields.
Click Add Jail
Enter a Jail Name (I used Jail-Go-Bye in the video)
Select a Release
Click Next
Leave everything blank here
Click Next
Click Submit

Now start this jail
Jail Options Menu -> Start (or select the jail and click the 'play' button)
Click the Jail Options button -> Edit
Set "DHCP Autoconfigure IPv4" option to enable networking autoconfigure
Click Save at the bottom of this screen
Get the Please Wait as the jail is reconfigured

Jail List loads
Jails are gone...

In the video, there was an existing jail, and the jail created to demo this bug.
After triggering the bug both jails are gone. (see note below)

See attached video DisappearingJails-2018-06-11.mkv

After a bit more research, the jails are gone only from the Jails section.
Go to Storage -> Pools
Expand the Pool that contains the iocage dataset and all the jails are there.

Reboot the FreeNAS, and the jails again show up as they should.
Luckily there is no data loss and seems to only be a visual/jails display issue.

Note: When creating this bug, I did the steps again. This time I had the 2 jails from creating the demo video.
Followed the steps again.
This time only the new jail disappeared...

There is no data loss, a reboot brings the "missing" jails back, and this is a fairly specific set of steps.
I'm not sure if this is a blocker or not...

I would say this set of steps may be done in the wild if a user creates a jail, starts that jail, then realizes "Ooops I can't do anything with this jail I forgot to add networking." User then go to Edit on the running jail, enables networking, and bam, potentially all of their jails disappear.

This bug was first discovered using the 6-6-2018 FreeNAS Nightly build. Confirmed and reported this bug against the current latest nightly (6-11-2018)

DisappearingJails-2018-06-11.mkv (1.85 MB) DisappearingJails-2018-06-11.mkv Michael Reynolds, 06/11/2018 10:16 AM
JailsInStorage-2018-06-11.png (145 KB) JailsInStorage-2018-06-11.png Michael Reynolds, 06/11/2018 10:17 AM
enableNetworkRunningJail-2018-06-20.png (58.9 KB) enableNetworkRunningJail-2018-06-20.png Michael Reynolds, 06/20/2018 09:54 AM
18370
19069

Related issues

Related to FreeNAS - Bug #35338: Jail disappear from API v2Closed

Associated revisions

Revision 2d887420 (diff)
Added by Brandon Schneider over 2 years ago

fix(plugins/jail): Catch any exceptions during updating a property Ticket: #34771

Revision 9575da11 (diff)
Added by Brandon Schneider over 2 years ago

fix(plugins/jail): Catch any exceptions during updating a property (#1345) Ticket: #34771

Revision 91e4f9b4 (diff)
Added by Brandon Schneider about 2 years ago

fix(plugins/jail): Catch any exceptions during updating a property (#1345) Ticket: #34771

History

#1 Updated by Erin Clark over 2 years ago

  • Assignee changed from Erin Clark to Lola Yang
  • Target version changed from Backlog to 11.2-BETA1

#2 Updated by Lola Yang over 2 years ago

  • Assignee changed from Lola Yang to Brandon Schneider

Brandon will investigate on the API side first, then he can toss it back to me depending on what's needed

#3 Updated by Brandon Schneider over 2 years ago

  • Subject changed from Jails disappear when enabling networking on a running jail. to Jails disappear when enabling dhcp on a running jail.
  • Status changed from Unscreened to In Progress
  • Severity changed from New to Medium

Lola has stated that Mike reports that this only occurs enabling dhcp on a running jail.

#4 Updated by Michael Reynolds over 2 years ago

Correct, I followed all of the steps up to the going into the Edit section. I didn't thoroughly test, but I enabled a few random options in the Jail Properties section and no jails disappeared.

Another thing that may help track this down, if I go into Edit when the jail is stopped, enable DHCP auto-config and click save, jails do not disappear either.

#5 Updated by Brandon Schneider over 2 years ago

  • Status changed from In Progress to Ready for Testing

#6 Updated by Brandon Schneider over 2 years ago

  • Category changed from GUI (new) to Middleware

#7 Updated by Brandon Schneider over 2 years ago

  • Status changed from Ready for Testing to In Progress

Has another commit needed in addition to that.

#8 Updated by Brandon Schneider over 2 years ago

  • Category changed from Middleware to GUI (new)
  • Status changed from In Progress to Not Started
  • Assignee changed from Brandon Schneider to Lola Yang

Middleware PR: https://github.com/freenas/freenas/pull/1345 This will require the UI to catch exceptions for do_update

#9 Updated by Lola Yang over 2 years ago

  • Status changed from Not Started to Done

Jail form component has error handler which can catch the exceptions.

#10 Updated by Dru Lavigne over 2 years ago

  • Subject changed from Jails disappear when enabling dhcp on a running jail. to Catch any exceptions when updating a property
  • Category changed from GUI (new) to Middleware
  • Status changed from Done to Ready for Testing
  • Assignee changed from Lola Yang to Brandon Schneider
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#11 Updated by Waqar Ahmed over 2 years ago

  • Related to Bug #35338: Jail disappear from API v2 added

#12 Updated by Michael Reynolds over 2 years ago

19069

Instead of jails disappearing an error dialog pops up
See enableNetworkRunningJail-2018-06-20.png

#13 Updated by Dru Lavigne over 2 years ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF