Project

General

Profile

Bug #34807

Minor edits in IPMI plugin

Added by Waqar Ahmed 11 months ago. Updated 10 months ago.

Status:
Done
Priority:
No priority
Assignee:
Waqar Ahmed
Category:
Middleware
Target version:
Seen in:
Severity:
Low Medium
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Few edits in IPMI plugin to make it use the latest validators available in Middlewared for validation and other minor edits

ipmi2.png (25.7 KB) ipmi2.png Rishabh Chauhan, 06/21/2018 08:31 AM
ipmisaved.png (20.7 KB) ipmisaved.png Rishabh Chauhan, 06/21/2018 08:31 AM
zeroes.png (25.4 KB) zeroes.png Zackary Welch, 06/29/2018 12:15 PM
19147
19150
20013

Associated revisions

Revision 09acccb3 (diff)
Added by Waqar Ahmed 11 months ago

Minor edits in IPMI plugin
Ticket: #34807

Revision c460b07e (diff)
Added by Waqar Ahmed 10 months ago

Minor edits in IPMI plugin
Ticket: #34807

History

#1 Updated by Waqar Ahmed 11 months ago

  • Status changed from Unscreened to In Progress

#2 Updated by Waqar Ahmed 11 months ago

  • Status changed from In Progress to Ready for Testing

#3 Updated by Dru Lavigne 11 months ago

  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#4 Updated by Rishabh Chauhan 10 months ago

19147
19150

FreeNAS-11.2-MASTER-201806210452
I tested a couple of scenarios and after discussing with Waqar we realized that there may be a few things need which needs fixing here.
After going through the added code, i realized there should be an error message when DHCP is not checked and static IP is not provided...
it successfully saves even if the IP is 0.0.0.0 or no IP at all without any error (Refer screen-shots)

#5 Updated by Waqar Ahmed 10 months ago

  • Status changed from Failed Testing to Ready for Testing

Explicit checks for None values have been added in Middlewared when DHCP is off. PR - https://github.com/freenas/freenas/pull/1413

#6 Updated by Dru Lavigne 10 months ago

  • Needs QA changed from No to Yes

#7 Avatar?id=55038&size=24x24 Updated by Zackary Welch 10 months ago

I will work on testing this one.

#8 Avatar?id=55038&size=24x24 Updated by Zackary Welch 10 months ago

  • File zeroes.png zeroes.png added
  • Status changed from Ready for Testing to Passed Testing
  • Needs QA changed from Yes to No
20013

I get an error when no IP, DNS, or Route is provided and DNS is off; however, 0.0.0.0 still works. This isn't technically invalid, but we might want some warning/docs about that. Also, what about greying the boxes when DHCP is enabled? Anyway, this passes.

#9 Updated by Dru Lavigne 10 months ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF