FreeNAS

In [4]: POST("/service/start/", {"service": "smartd", "service-control": {"onetime": True}}).text
Out[4]: 'false'

In [5]: POST("/service/start/", {"service": "smartd", "service-control": {"onetime": True}})
Out[5]: <Response [200]>

It is supposed to be this way.

Exception was fixed.

On the latest build this morning it is not fixed.

==================================================== test session starts =====================================================
platform freebsd12 -- Python 3.6.5, pytest-3.4.2, py-1.5.3, pluggy-0.6.0 -- /usr/local/bin/python3.6
cachedir: .pytest_cache
rootdir: /usr/home/ericbsd/projects/freenas/freenas/tests, inifile:
collected 8 items                                                                                                            

api2/smart.py::test_01_create_a_new_smarttest PASSED                                                                   [ 12%]
api2/smart.py::test_02_check_that_API_reports_new_smarttest PASSED                                                     [ 25%]
api2/smart.py::test_03_update_smarttest PASSED                                                                         [ 37%]
api2/smart.py::test_04_delete_smarttest PASSED                                                                         [ 50%]
api2/smart.py::test_05_enable_smartd_service_at_boot PASSED                                                            [ 62%]
api2/smart.py::test_06_look_smartd_service_at_boot PASSED                                                              [ 75%]
api2/smart.py::test_07_starting_smartd_service PASSED                                                                  [ 87%]
api2/smart.py::test_08_checking_to_see_if_smartd_service_is_running FAILED                                             [100%]

------------ generated xml file: /usr/home/ericbsd/projects/freenas/freenas/tests/results/smart_tests_result.xml -------------
========================================================== FAILURES ==========================================================
____________________________________ test_08_checking_to_see_if_smartd_service_is_running ____________________________________

    def test_08_checking_to_see_if_smartd_service_is_running():
        results = GET('/service/?service=smartd')
>       assert results.json()[0]["state"] == "RUNNING", results.text
E       AssertionError: [
E          {
E           "id": 18,
E           "service": "smartd",
E           "enable": true,
E           "state": "STOPPED",
E           "pids": []
E          }
E         ]
E       assert 'STOPPED' == 'RUNNING'
E         - STOPPED
E         + RUNNING

api2/smart.py:82: AssertionError
============================================ 1 failed, 7 passed in 22.46 seconds =============================================

Trying to start the service return 200 but failed to run, the state still STOPPED.

In [3]: GET('/service/?service=smartd').text
Out[3]: '[\n {\n  "id": 18,\n  "service": "smartd",\n  "enable": true,\n  "state": "STOPPED",\n  "pids": []\n }\n]'

In [4]: POST("/service/start/", {"service": "smartd", "service-control": {"onetime": True}})
Out[4]: <Response [200]>

In [5]: GET('/service/?service=smartd').text
Out[5]: '[\n {\n  "id": 18,\n  "service": "smartd",\n  "enable": true,\n  "state": "STOPPED",\n  "pids": []\n }\n]'

Service that does not exist should return an error code.

In [6]: POST("/service/start/", {"service": "smart", "service-control": {"onetime": True}})
Out[6]: <Response [200]>

In [7]: GET('/service/?service=smart').text
Out[7]: '[]'

POST("/service/start/", {"service": "dead", "service-control": {"onetime": True}})
Out[8]: <Response [200]>

link to the latest Incremental build
https://builds.ixsystems.com/jenkins/view/Builds/view/All/job/FreeNAS%20-%20Master%20-%20Incremental%20Build/3206/artifact/artifacts/iso/FreeNAS-11.2-MASTER-201806150906-91108b28e.iso

Step to reproduce the above with the iso liked above.

The iso is placed int the freenas/test/iso folder
It is run under a BHYVE build by ixautomation.

sudo ixautomation --run api2-tests --systype freenas --keep-alive

When it is done the result of IPython are done in the freenas/tests folder.

cd path/to/freenas/tests
sudo ipython-3.6

IT is done on A TrueOS machine.

So has I was told the service does only start on real ATA hardware, so only a CallError remain on this issue.

We cant add a CallError, we use it for arbitrary services that are not defined in database.

I am thinking we could use DEVICESCAN in smartd.conf if no disks support SMART.

We cant add a CallError, we use it for arbitrary services that are not defined in database.

So POST("/service/start/", {"service": "dead", "service-control": {"onetime": True}}) should just issue service dead start and return false (which it does)?

I am thinking we could use DEVICESCAN in smartd.conf if no disks support SMART.

Jun 17 08:05:59 freenas smartd[34183]: smartd 6.6 2017-11-05 r4594 [FreeBSD 11.1-STABLE amd64] (local build)
Jun 17 08:05:59 freenas smartd[34183]: Copyright (C) 2002-17, Bruce Allen, Christian Franke, www.smartmontools.org
Jun 17 08:05:59 freenas smartd[34183]: Opened configuration file /usr/local/etc/smartd.conf
Jun 17 08:05:59 freenas smartd[34183]: Drive: DEVICESCAN, implied '-a' Directive on line 1 of file /usr/local/etc/smartd.conf
Jun 17 08:05:59 freenas smartd[34183]: Configuration file /usr/local/etc/smartd.conf was parsed, found DEVICESCAN, scanning devices
Jun 17 08:05:59 freenas smartd[34183]: Device: /dev/ada0, opened
Jun 17 08:05:59 freenas smartd[34183]: Device: /dev/ada0, VBOX HARDDISK, S/N:VB574cb89c-65bf0f89, FW:1.0, 4.29 GB
Jun 17 08:05:59 freenas smartd[34183]: Device: /dev/ada0, not found in smartd database.
Jun 17 08:05:59 freenas smartd[34183]: Device: /dev/ada0, lacks SMART capability
Jun 17 08:05:59 freenas smartd[34183]: Device: /dev/ada0, to proceed anyway, use '-T permissive' Directive.
Jun 17 08:05:59 freenas smartd[34183]: Device: /dev/ada1, opened
Jun 17 08:05:59 freenas smartd[34183]: Device: /dev/ada1, VBOX HARDDISK, S/N:VB9f605184-8f6d0e32, FW:1.0, 4.29 GB
Jun 17 08:05:59 freenas smartd[34183]: Device: /dev/ada1, not found in smartd database.
Jun 17 08:05:59 freenas smartd[34183]: Device: /dev/ada1, lacks SMART capability
Jun 17 08:05:59 freenas smartd[34183]: Device: /dev/ada1, to proceed anyway, use '-T permissive' Directive.
Jun 17 08:05:59 freenas smartd[34183]: Device: /dev/cd0, opened
Jun 17 08:05:59 freenas smartd[34183]: Device: /dev/cd0, packet devices [this device CD/DVD] not SMART capable
Jun 17 08:05:59 freenas smartd[34183]: Unable to monitor any SMART enabled devices. Try debug (-d) option. Exiting...

It will still exit. The only way to prevent it from exiting is passing -q never to daemon which will require updating rc.conf depending on if we have found any SMART-enabled devices. In my opinion, it is not worth it.

It's been decided that we won't fix SMART on VM issue.

This bug is only visible when doing manual API calls. No QA is needed here.