Project

General

Profile

Bug #34951

Avatar?id=55038&size=50x50

Separate S.M.A.R.T. email addresses with spaces

Added by Zackary Welch 10 months ago. Updated 9 months ago.

Status:
Done
Priority:
No priority
Assignee:
Erin Clark
Category:
GUI (new)
Target version:
Severity:
Low Medium
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

This issue was just fixed in the old UI and also needs fixing in the new UI.
https://redmine.ixsystems.com/issues/26924

output.mp4 (480 KB) output.mp4 Zackary Welch, 06/13/2018 02:40 PM
SMART-email-CSV-2018-06-18.png (69.4 KB) SMART-email-CSV-2018-06-18.png Michael Reynolds, 06/18/2018 02:31 PM
18820

Related issues

Related to FreeNAS - Bug #31299: Separate S.M.A.R.T. email addresses with spacesDone

Associated revisions

Revision 772665d1 (diff)
Added by Erin Clark 10 months ago

Replace commas with spaces so that emails are formatted properly for SMART service

Ticket: #34951

Revision 5ec87241 (diff)
Added by Erin Clark 10 months ago

Fix comma seperated emails globally

Ticket: #34951

History

#1 Avatar?id=55038&size=24x24 Updated by Zackary Welch 10 months ago

The bug is that multiple emails need to be input in the S.M.A.R.T. service separated by spaces, but the tool tip does not say this. In addition, when saved correctly and reopened, the UI field shows the input separated by commas, which fails when going to save updated settings.

#2 Avatar?id=55038&size=24x24 Updated by Zackary Welch 10 months ago

Wrong ticket attached in OP. Correct related issue: https://redmine.ixsystems.com/issues/31299

#3 Updated by Dru Lavigne 10 months ago

  • Related to Bug #31299: Separate S.M.A.R.T. email addresses with spaces added

#4 Updated by Dru Lavigne 10 months ago

  • Assignee changed from Release Council to Erin Clark
  • Target version changed from Backlog to 11.2-BETA1

Erin: this one is needed for feature parity.

#5 Updated by Michael Reynolds 10 months ago

The new UI tooltip is fixed in this PR https://github.com/freenas/webui/pull/880
The field does display the values in CSV but should be space separated.

#6 Updated by Erin Clark 10 months ago

  • Status changed from Unscreened to In Progress

#7 Updated by Dru Lavigne 10 months ago

  • Status changed from In Progress to Done
  • Target version changed from 11.2-BETA1 to Master - FreeNAS Nightlies
  • Needs Merging changed from Yes to No

#8 Updated by Dru Lavigne 10 months ago

  • Assignee changed from Erin Clark to Michael Reynolds
  • Seen in changed from 11.2-BETA1 to Master - FreeNAS Nightlies

#9 Updated by Michael Reynolds 10 months ago

18820

Added a screenshot showing the current CSV emails addresses and not allowing space delimited entry

#10 Updated by Dru Lavigne 10 months ago

  • Related to Feature #26924: Add file-level encryption to Cloud Sync added

#11 Updated by Dru Lavigne 10 months ago

  • Status changed from Done to Failed Testing
  • Assignee changed from Michael Reynolds to Erin Clark
  • Target version changed from Master - FreeNAS Nightlies to 11.2-BETA2
  • Needs Merging changed from No to Yes

Erin: was a UI fix done for this one (other than the tooltip)? It is failing testing.

#12 Updated by Dru Lavigne 10 months ago

  • Related to deleted (Feature #26924: Add file-level encryption to Cloud Sync )

#13 Updated by Michael Reynolds 10 months ago

Space separated email addresses are valid input but emails addresses are still displayed in CSV format.

The error message is slightly confusing
On input of , the error message is

",': Should be valid E-Mail address"

Maybe enhance the error to include the value separator?

",': Should be valid E-Mail addresses separated by a space"

A comma is not allowed* in a valid email address. Perhaps we could send an error message specifically when a comma is used?

"A comma is not a valid character to use in an E-Mail address. Multiple E-Mail addresses should be separated by a space."

(*commas are allowed under special circumstances which we should not support anyway.)

#14 Updated by Erin Clark 10 months ago

  • Status changed from Failed Testing to In Progress
  • Assignee changed from Erin Clark to Lola Yang

Sorry about that, I have a PR now https://github.com/freenas/webui/pull/956, could you review Lola?

#15 Updated by Michael Reynolds 10 months ago

I've tested and confirmed this is fixed in the FIX-34951 branch

Waiting for this to make it in a release before marking Passed Testing officially

#16 Updated by Dru Lavigne 10 months ago

  • Target version changed from 11.2-BETA2 to 11.2-BETA1

#17 Updated by Erin Clark 10 months ago

  • Status changed from In Progress to Ready for Testing
  • Assignee changed from Lola Yang to Erin Clark

#18 Updated by Dru Lavigne 10 months ago

  • Needs Merging changed from Yes to No

#19 Updated by Michael Reynolds 10 months ago

  • Status changed from Ready for Testing to Passed Testing
  • Needs QA changed from Yes to No

Confirmed fixed in INTERNAL16

Also opened
https://redmine.ixsystems.com/issues/36563
https://redmine.ixsystems.com/issues/36568
to address the required error message improvements.

#20 Updated by Dru Lavigne 10 months ago

  • Status changed from Passed Testing to Done

#22 Updated by Dru Lavigne 9 months ago

  • Needs Doc changed from Yes to No

Also available in: Atom PDF